From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: s3c24xx: fix build error
Date: Tue, 7 Jan 2014 19:27:25 +0100 [thread overview]
Message-ID: <1389119245-2167-1-git-send-email-linus.walleij@linaro.org> (raw)
When enabling device tree on the S3C an additional build
bug appears in the Osiris DVS board file:
CC arch/arm/mach-s3c24xx/mach-osiris-dvs.o
archh/arm/mach-s3c24xx/mach-osiris-dvs.c:
In function ?osiris_dvs_notify?:
arch/arm/mach-s3c24xx/mach-osiris-dvs.c:77:4:
error: implicit declaration of function ?S3C2410_GPB?
[-Werror=implicit-function-declaration]
gpio_set_value(OSIRIS_GPIO_DVS, 1);
^
Fix this by explicitly including
<linux/platform_data/gpio-samsung-s3c24xx.h>
Reported-by: Arnd Bergmann <arnd@arndb.de>
Cc: Kukjin Kim <kgene.kim@samsung.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: linux-samsung-soc at vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
I have tentatively applied this to the GPIO tree so I
don't cause build regressions, ACKs are still
appreciated from the S3C maintainers.
---
arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c
index 45e74363aaa9..5b8af46c0d6b 100644
--- a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c
+++ b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c
@@ -16,6 +16,7 @@
#include <linux/platform_device.h>
#include <linux/cpufreq.h>
#include <linux/gpio.h>
+#include <linux/platform_data/gpio-samsung-s3c24xx.h>
#include <linux/i2c/tps65010.h>
--
1.8.3.1
next reply other threads:[~2014-01-07 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 18:27 Linus Walleij [this message]
2014-01-07 19:12 ` [PATCH] ARM: s3c24xx: fix build error Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389119245-2167-1-git-send-email-linus.walleij@linaro.org \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).