From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] reset: Add of_reset_control_get
Date: Wed, 08 Jan 2014 12:11:34 +0100 [thread overview]
Message-ID: <1389179494.4297.9.camel@pizza.hi.pengutronix.de> (raw)
In-Reply-To: <20140108103843.GA2941@lukather>
Am Mittwoch, den 08.01.2014, 11:38 +0100 schrieb Maxime Ripard:
> Hi Philipp,
>
> On Mon, Jan 06, 2014 at 06:42:51PM +0100, Philipp Zabel wrote:
> > Am Samstag, den 21.12.2013, 09:42 +0100 schrieb Thomas Petazzoni:
> > > Maxime, Philipp,
> > >
> > > On Fri, 20 Dec 2013 22:41:07 +0100, Maxime Ripard wrote:
> > > > In some cases, you might need to deassert from reset an hardware block that
> > > > doesn't associated to a struct device (CPUs, timers, etc.).
> > > >
> > > > Add a small helper to retrieve the reset controller from the device tree
> > > > without the need to pass a struct device.
> > > >
> > > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > > > ---
> > > > drivers/reset/core.c | 39 ++++++++++++++++++++++++++++++---------
> > > > include/linux/reset.h | 4 ++++
> > > > 2 files changed, 34 insertions(+), 9 deletions(-)
> > >
> > > I'd like to add that I have the exact same need as Maxime. Maxime needs
> > > of_reset_control_get() for timers, and in my case, I need it for CPUs,
> > > since I associated a reset controller to CPU nodes in my DT.
> > >
> > > Funnily, even though Maxime and I work like 3 meters away from each
> > > other, both of us came up independently with almost exactly the same
> > > implementation to solve the exact same problem, without talking to each
> > > other about this need. It's only yesterday that we discovered we've had
> > > to solve the same problem.
> > >
> > > So, definitely looking forward to seeing the feedback about this.
> > >
> > > Thanks!
> >
> > This looks like a useful addition. I'll reorder the GPIO reset patch for
> > this.
>
> How do you want to get this merged? You'll probably want to take this
> patch, and patches 2/3 and 3/3 depend on some patches merged by Daniel
> Lezcano (that I forgot to CC on this, I'll resend).
>
> Maybe the best way would be simply to merge this one for 3.14 through
> your branch, and merge the two other patches in 3.15.
Alright, this is applied to my branch. I'll wait a bit for feedback on
the GPIO reset patches and then send a pull request.
regards
Philipp
next prev parent reply other threads:[~2014-01-08 11:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 21:41 [PATCH 0/3] ARM: sunxi: Add A31 High Speed Timer Support Maxime Ripard
2013-12-20 21:41 ` [PATCH 1/3] reset: Add of_reset_control_get Maxime Ripard
2013-12-21 8:42 ` Thomas Petazzoni
2014-01-06 17:42 ` Philipp Zabel
2014-01-08 10:38 ` Maxime Ripard
2014-01-08 11:11 ` Philipp Zabel [this message]
2014-01-08 11:54 ` Maxime Ripard
2014-02-05 10:50 ` Maxime Ripard
2013-12-20 21:41 ` [PATCH 2/3] clocksource: sun5i: Add support for reset controller Maxime Ripard
2013-12-20 21:41 ` [PATCH 3/3] ARM: sun6i: a31: Add support for the High Speed Timers Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389179494.4297.9.camel@pizza.hi.pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).