linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 18/18] mfd: vexpress: Split sysreg functions into MFD cells
Date: Wed, 08 Jan 2014 16:17:19 +0000	[thread overview]
Message-ID: <1389197839.23721.31.camel@hornet> (raw)
In-Reply-To: <20140106104030.GI23772@lee--X1>

On Mon, 2014-01-06 at 10:40 +0000, Lee Jones wrote:
> > +static struct mfd_cell vexpress_sysreg_cells[] = {
> > +	{
> > +		.name = "syscon",
> > +		.of_compatible = "arm,vexpress-sysreg,sys_id",
> > +		.num_resources = 1,
> > +		.resources = (struct resource []) {
> > +			DEFINE_RES_MEM(SYS_ID, 0x4),
> > +		},
> > +		.platform_data = &vexpress_sysreg_sys_id_pdata,
> > +		.pdata_size = sizeof(vexpress_sysreg_sys_id_pdata),
> 
> Not sure how comfortable I am with using Device Tree and populating
> platform_data with information which by the looks of it you're
> planning to make persistent. What's stopping you from using a DT
> property to name the block, or better yet, just use the compatible
> string? Also, won't naming these blocks in DT also aid other OSes?

Right. This particular of_compatible string in the *_cells is a leftover
from previous versions of the patch. Only the gpio-related ones, as
mentioned in the example:

>  Example:
>         v2m_sysreg: sysreg at 10000000 {
>                 compatible = "arm,vexpress-sysreg";
>                 reg = <0x10000000 0x1000>;
> -               gpio-controller;
> -               #gpio-cells = <2>;
> +
> +               v2m_led_gpios: sys_led at 08 {
> +                       compatible = "arm,vexpress-sysreg,sys_led";
> +                       gpio-controller;
> +                       #gpio-cells = <2>;
> +               };
> +
> +               v2m_mmc_gpios: sys_mci at 48 {
> +                       compatible = "arm,vexpress-sysreg,sys_mci";
> +                       gpio-controller;
> +                       #gpio-cells = <2>;
> +               };
> +
> +               v2m_flash_gpios: sys_flash at 4c {
> +                       compatible = "arm,vexpress-sysreg,sys_flash";
> +                       gpio-controller;
> +                       #gpio-cells = <2>;
> +               };
>         };

are supposed for the sake the gpio users (and some of them don't exist
in some version of the sysregs).

> > +	return mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO,
> > +			vexpress_sysreg_cells,
> > +			ARRAY_SIZE(vexpress_sysreg_cells), mem, 0, 0);
> 
> Don't use 0 as NULL, you will cause a sparse error.

... and rightly so! ;-) Well spotted, thanks!

Pawe?

  reply	other threads:[~2014-01-08 16:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-23 16:23 [RFC 00/18] Versatile Express config rework Pawel Moll
     [not found] ` < 1387815830-8794-7-git-send-email-pawel.moll@arm.com>
     [not found] ` < 1387815830-8794-5-git-send-email-pawel.moll@arm.com>
2013-12-23 16:23 ` [RFC 05/18] driver core: Do not WARN when devres list is not empty at probe time Pawel Moll
     [not found] ` <1387815830-8794-4-git-send-email-pawel.moll@arm.com>
2013-12-23 17:26   ` [RFC 03/18] GPIO: gpio-generic: Add label to platform data Linus Walleij
2014-01-08 15:57     ` Pawel Moll
2014-01-14 10:30       ` Linus Walleij
2014-01-14 10:44         ` Pawel Moll
     [not found] ` <1387815830-8794-9-git-send-email-pawel.moll@arm.com>
2013-12-23 17:31   ` [RFC 08/18] hwmon: vexpress: Use regmap instead of custom interface Guenter Roeck
2014-01-08 15:57     ` Pawel Moll
     [not found] ` <1387815830-8794-3-git-send-email-pawel.moll@arm.com>
2013-12-23 19:28   ` [RFC 02/18] power/reset: vexpress: Use sched_clock as the time source John Stultz
2014-01-08 16:01     ` Pawel Moll
     [not found] ` <1387815830-8794-13-git-send-email-pawel.moll@arm.com>
2013-12-23 20:05   ` [RFC 12/18] clk: versatile: Split config options for sp810 and vexpress_osc Mike Turquette
2014-01-08 16:06     ` Pawel Moll
     [not found] ` <1387815830-8794-8-git-send-email-pawel.moll@arm.com>
2013-12-24 12:19   ` [RFC 07/18] regmap: debugfs: Always create "registers" & "access" files Mark Brown
2014-01-08 17:31     ` Pawel Moll
2014-01-08 18:00       ` Mark Brown
     [not found] ` <1387815830-8794-11-git-send-email-pawel.moll@arm.com>
2013-12-24 12:24   ` [RFC 10/18] regulator: vexpress: Use regmap instead of custom interface Mark Brown
2014-01-08 18:25     ` Pawel Moll
2014-01-09 13:35       ` Mark Brown
     [not found] ` <1387815830-8794-7-git-send-email-pawel.moll@arm.com>
2013-12-24 12:45   ` [RFC 06/18] regmap: Formalise use of non-bus context Mark Brown
2014-01-09 13:08     ` Pawel Moll
2014-01-09 13:34       ` Mark Brown
2014-01-09 15:47         ` Pawel Moll
2014-01-16 17:09       ` Grant Likely
2014-01-16 17:20         ` Pawel Moll
     [not found] ` <1387815830-8794-2-git-send-email-pawel.moll@arm.com>
2014-01-06  9:48   ` [RFC 01/18] mfd: syscon: Consider platform data a regmap config name Lee Jones
2014-01-06 10:20     ` Lee Jones
     [not found] ` <1387815830-8794-19-git-send-email-pawel.moll@arm.com>
2014-01-06 10:40   ` [RFC 18/18] mfd: vexpress: Split sysreg functions into MFD cells Lee Jones
2014-01-08 16:17     ` Pawel Moll [this message]
     [not found] ` <1387815830-8794-5-git-send-email-pawel.moll@arm.com>
2014-01-08 17:28   ` [RFC 04/18] driver core & of: Mark of_nodes of added device as populated Rob Herring
2014-01-16 17:03     ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389197839.23721.31.camel@hornet \
    --to=pawel.moll@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).