From: paul.gortmaker@windriver.com (Paul Gortmaker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 17/73] arm: fix implicit module.h use in mach-at91 gpio.h
Date: Tue, 21 Jan 2014 16:22:20 -0500 [thread overview]
Message-ID: <1390339396-3479-18-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1390339396-3479-1-git-send-email-paul.gortmaker@windriver.com>
We currently get __init_or_module from init.h (implicitly) but if
we move that to module.h we will get failures like this:
In file included from /home/paul/git/linux-head/arch/arm/include/asm/gpio.h:10:0,
from include/linux/gpio.h:48,
from include/linux/of_gpio.h:20,
from drivers/input/touchscreen/ads7846.c:30:
arch/arm/mach-at91/include/mach/gpio.h:191:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_GPIO_periph'
arch/arm/mach-at91/include/mach/gpio.h:192:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_A_periph'
arch/arm/mach-at91/include/mach/gpio.h:193:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_B_periph'
arch/arm/mach-at91/include/mach/gpio.h:194:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_C_periph'
arch/arm/mach-at91/include/mach/gpio.h:195:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_D_periph'
arch/arm/mach-at91/include/mach/gpio.h:196:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_gpio_input'
arch/arm/mach-at91/include/mach/gpio.h:197:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_gpio_output'
arch/arm/mach-at91/include/mach/gpio.h:198:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_deglitch'
arch/arm/mach-at91/include/mach/gpio.h:199:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_debounce'
arch/arm/mach-at91/include/mach/gpio.h:200:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_multi_drive'
arch/arm/mach-at91/include/mach/gpio.h:201:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_set_pulldown'
arch/arm/mach-at91/include/mach/gpio.h:202:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'at91_disable_schmitt_trig'
make[3]: *** [drivers/input/touchscreen/ads7846.o] Error 1
Fix it up in advance by including module.h explicitly.
Cc: Andrew Victor <linux@maxim.org.za>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
arch/arm/mach-at91/include/mach/gpio.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-at91/include/mach/gpio.h b/arch/arm/mach-at91/include/mach/gpio.h
index 5fc2377..78abd64 100644
--- a/arch/arm/mach-at91/include/mach/gpio.h
+++ b/arch/arm/mach-at91/include/mach/gpio.h
@@ -14,6 +14,7 @@
#define __ASM_ARCH_AT91RM9200_GPIO_H
#include <linux/kernel.h>
+#include <linux/module.h> /* for __init_or_module */
#include <asm/irq.h>
#define MAX_GPIO_BANKS 5
--
1.8.4.1
next prev parent reply other threads:[~2014-01-21 21:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 21:22 [PATCH RFC 00/73] tree-wide: clean up some no longer required #include <linux/init.h> Paul Gortmaker
2014-01-21 21:22 ` [PATCH 16/73] arm: include module.h in drivers/bus/omap_l3_smx.c Paul Gortmaker
2014-01-21 21:22 ` Paul Gortmaker [this message]
2014-01-21 21:22 ` [PATCH 18/73] arm: fix implicit #include <linux/init.h> in entry asm Paul Gortmaker
2014-01-21 21:22 ` [PATCH 19/73] arm: mach-s3c64xx mach-crag6410-module.c is not modular Paul Gortmaker
2014-01-23 13:16 ` Charles Keepax
2014-02-15 17:04 ` Kukjin Kim
2014-01-21 21:22 ` [PATCH 20/73] arm: use subsys_initcall in non-modular pl320 IPC code Paul Gortmaker
2014-01-21 21:44 ` Arnd Bergmann
2014-01-21 22:19 ` Paul Gortmaker
2014-01-21 21:22 ` [PATCH 21/73] arm: don't use module_init in non-modular mach-vexpress/spc.c code Paul Gortmaker
2014-01-21 21:22 ` [PATCH 27/73] drivers/clk: don't use module_init in clk-nomadik.c which is non-modular Paul Gortmaker
2014-01-31 23:17 ` Mike Turquette
2014-01-21 21:22 ` [PATCH 28/73] cpuidle: don't use modular platform register in non-modular ARM drivers Paul Gortmaker
2014-01-21 21:22 ` [PATCH 33/73] arm: delete non-required instances of include <linux/init.h> Paul Gortmaker
2014-01-22 7:00 ` [PATCH RFC 00/73] tree-wide: clean up some no longer required #include <linux/init.h> Stephen Rothwell
2014-01-23 0:38 ` Paul Gortmaker
2014-01-28 3:13 ` Benjamin Herrenschmidt
2014-01-28 16:21 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390339396-3479-18-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).