linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: paul.gortmaker@windriver.com (Paul Gortmaker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-next] drivers/clk: make max77686 driver bool for now
Date: Thu, 23 Jan 2014 14:32:15 -0500	[thread overview]
Message-ID: <1390505535-30229-1-git-send-email-paul.gortmaker@windriver.com> (raw)

Commit 3966c947f45911e093114371462687134d5e8d40 ("clk: max77686:
Refactor driver data handling") added a call to __clk_get_hw()
but this function is not exported (as __<name> is typically a
private/internal thing).

Hence this driver fails to build modular, and has been causing
allmodconfig build breakage in arch outside of just ARM.  Since
the only defconfig that uses it sets it as =y, lets just make
it non-modular for now.

Mike says that changes are pending to export similar functionality
in the future[1], so at that point in time, it can be returned to
tristate if desired.

[1] https://lkml.org/lkml/2014/1/20/21

Reported-by: SeongJae Park <sj38.park@gmail.com>
Cc: SeongJae Park <sj38.park@gmail.com>
Cc: Tomasz Figa <t.figa@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Mike Turquette <mturquette@linaro.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index efb508a..009fb9b 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -40,7 +40,7 @@ config COMMON_CLK_VERSATILE
 	  - Versatile Express
 
 config COMMON_CLK_MAX77686
-	tristate "Clock driver for Maxim 77686 MFD"
+	bool "Clock driver for Maxim 77686 MFD"
 	depends on MFD_MAX77686
 	---help---
 	  This driver supports Maxim 77686 crystal oscillator clock. 
-- 
1.8.5.2

             reply	other threads:[~2014-01-23 19:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 19:32 Paul Gortmaker [this message]
2014-01-27 21:52 ` [PATCH-next] drivers/clk: make max77686 driver bool for now Mike Turquette
2014-01-27 22:32   ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390505535-30229-1-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).