From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: kernel: use seq_puts() instead of seq_printf()
Date: Tue, 28 Jan 2014 21:00:50 -0800 [thread overview]
Message-ID: <1390971650.11756.49.camel@joe-AO722> (raw)
In-Reply-To: <001201cf1cae$2d60ce80$88226b80$%han@samsung.com>
On Wed, 2014-01-29 at 13:54 +0900, Jingoo Han wrote:
> On Wednesday, January 29, 2014 12:52 AM, Catalin Marinas wrote:
> > On Tue, Jan 28, 2014 at 01:36:18AM +0000, Jingoo Han wrote:
> > > For a constant format without additional arguments, use seq_puts()
> > > instead of seq_printf(). Also, it fixes the following checkpatch
> > > warning.
> > >
> > > WARNING: Prefer seq_puts to seq_printf
> > >
> > > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > > ---
> > > arch/arm64/kernel/setup.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> > > index c8e9eff..4507691 100644
> > > --- a/arch/arm64/kernel/setup.c
> > > +++ b/arch/arm64/kernel/setup.c
> > > @@ -416,7 +416,7 @@ static int c_show(struct seq_file *m, void *v)
> > > seq_printf(m, "%s ", hwcap_str[i]);
> > >
> > > seq_printf(m, "\nCPU implementer\t: 0x%02x\n", read_cpuid_id() >> 24);
> > > - seq_printf(m, "CPU architecture: AArch64\n");
> > > + seq_puts(m, "CPU architecture: AArch64\n");
> > > seq_printf(m, "CPU variant\t: 0x%x\n", (read_cpuid_id() >> 20) & 15);
> > > seq_printf(m, "CPU part\t: 0x%03x\n", (read_cpuid_id() >> 4) & 0xfff);
> > > seq_printf(m, "CPU revision\t: %d\n", read_cpuid_id() & 15);
> >
> > Just ignore the checkpatch warning. I prefer the consistency of
> > seq_printf() in this function.
>
> (+cc Joe Perches, Dan Carpenter)
>
> Personally, I don't like the checkpatch warning.
> However, I respect your opinion on the consistency.
> Thank you for your comment.
No worries from me.
I'm happy you can ignore checkpatch bleatings
you don't agree with.
It's a stupid little checker.
People are much smarter.
cheers, Joe
next prev parent reply other threads:[~2014-01-29 5:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 1:35 [PATCH 1/2] arm64: use num_possible_cpus() instead of NR_CPUS Jingoo Han
2014-01-28 1:36 ` [PATCH 2/2] arm64: kernel: use seq_puts() instead of seq_printf() Jingoo Han
2014-01-28 15:51 ` Catalin Marinas
2014-01-29 4:54 ` Jingoo Han
2014-01-29 5:00 ` Joe Perches [this message]
2014-01-28 10:11 ` [PATCH 1/2] arm64: use num_possible_cpus() instead of NR_CPUS Sudeep Holla
2014-01-29 5:31 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390971650.11756.49.camel@joe-AO722 \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).