From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] backlight: add PWM dependencies
Date: Tue, 4 Feb 2014 13:57:14 +0100 [thread overview]
Message-ID: <1391518634-6472-1-git-send-email-linus.walleij@linaro.org> (raw)
In some compilations the LM3630A and LP855X backlight drivers
fail like this:
drivers/built-in.o: In function `lm3630a_pwm_ctrl':
drivers/video/backlight/lm3630a_bl.c:168: undefined reference to `pwm_config'
drivers/video/backlight/lm3630a_bl.c:172: undefined reference to `pwm_disable'
drivers/video/backlight/lm3630a_bl.c:170: undefined reference to `pwm_enable'
drivers/built-in.o: In function `lp855x_pwm_ctrl':
drivers/video/backlight/lp855x_bl.c:249: undefined reference to `pwm_config'
drivers/video/backlight/lp855x_bl.c:253: undefined reference to `pwm_disable'
drivers/video/backlight/lp855x_bl.c:251: undefined reference to `pwm_enable'
This is because both drivers depend on the PWM framework, so
add this dependency to their Kconfig entries.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/video/backlight/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index 5a3eb2ecb525..0604c3348761 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -371,6 +371,7 @@ config BACKLIGHT_AAT2870
config BACKLIGHT_LM3630A
tristate "Backlight Driver for LM3630A"
depends on BACKLIGHT_CLASS_DEVICE && I2C
+ depends on PWM
select REGMAP_I2C
help
This supports TI LM3630A Backlight Driver
@@ -387,6 +388,7 @@ config BACKLIGHT_LM3639
config BACKLIGHT_LP855X
tristate "Backlight driver for TI LP855X"
depends on BACKLIGHT_CLASS_DEVICE && I2C
+ depends on PWM
help
This supports TI LP8550, LP8551, LP8552, LP8553, LP8555, LP8556 and
LP8557 backlight driver.
--
1.8.5.3
next reply other threads:[~2014-02-04 12:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 12:57 Linus Walleij [this message]
2014-02-05 5:01 ` [PATCH] backlight: add PWM dependencies Jingoo Han
2014-02-05 8:57 ` Linus Walleij
2014-02-06 6:49 ` Jingoo Han
2014-02-06 7:23 ` Jingoo Han
2014-02-06 8:32 ` Linus Walleij
2014-02-06 16:08 ` Arnd Bergmann
2014-02-06 16:35 ` Arnd Bergmann
2014-02-07 3:05 ` Jingoo Han
2014-02-07 9:40 ` Arnd Bergmann
2014-02-10 10:40 ` Thierry Reding
2014-02-10 11:09 ` Linus Walleij
2014-02-26 13:25 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391518634-6472-1-git-send-email-linus.walleij@linaro.org \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).