From: richard.genoud@gmail.com (Richard Genoud)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/8] tty/serial: at91: remove unused open/close hooks
Date: Fri, 7 Feb 2014 15:59:09 +0100 [thread overview]
Message-ID: <1391785155-18525-3-git-send-email-richard.genoud@gmail.com> (raw)
In-Reply-To: <1391785155-18525-1-git-send-email-richard.genoud@gmail.com>
commit 95e629b761ce36996d1befe2824d5346b5a220b9 removed the use of board
specific hooks in serial_at91.h, so now, the open/close hook are just
dead code.
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
drivers/tty/serial/atmel_serial.c | 21 ---------------------
1 file changed, 21 deletions(-)
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index ed9621a21d67..a51b3a762948 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -112,9 +112,6 @@ static void atmel_stop_rx(struct uart_port *port);
#define UART_PUT_TCR(port,v) __raw_writel(v, (port)->membase + ATMEL_PDC_TCR)
#define UART_GET_TCR(port) __raw_readl((port)->membase + ATMEL_PDC_TCR)
-static int (*atmel_open_hook)(struct uart_port *);
-static void (*atmel_close_hook)(struct uart_port *);
-
struct atmel_dma_buffer {
unsigned char *buf;
dma_addr_t dma_addr;
@@ -1569,17 +1566,6 @@ static int atmel_startup(struct uart_port *port)
if (retval < 0)
atmel_set_ops(port);
}
- /*
- * If there is a specific "open" function (to register
- * control line interrupts)
- */
- if (atmel_open_hook) {
- retval = atmel_open_hook(port);
- if (retval) {
- free_irq(port->irq, port);
- return retval;
- }
- }
/* Save current CSR for comparison in atmel_tasklet_func() */
atmel_port->irq_status_prev = UART_GET_CSR(port);
@@ -1678,13 +1664,6 @@ static void atmel_shutdown(struct uart_port *port)
* Free the interrupt
*/
free_irq(port->irq, port);
-
- /*
- * If there is a specific "close" function (to unregister
- * control line interrupts)
- */
- if (atmel_close_hook)
- atmel_close_hook(port);
}
/*
--
1.8.5
next prev parent reply other threads:[~2014-02-07 14:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 14:59 [PATCH 0/8] tty/serial: at91: Add missing modem signals to atmel_serial Richard Genoud
2014-02-07 14:59 ` [PATCH 1/8] tty/serial: at91: use dev_err instead of printk Richard Genoud
2014-02-07 14:59 ` Richard Genoud [this message]
2014-02-07 14:59 ` [PATCH 3/8] tty/serial: at91: prepare for more gpio lines to come Richard Genoud
2014-02-07 14:59 ` [PATCH 4/8] tty/serial: at91: add cts control via gpio Richard Genoud
2014-02-07 14:59 ` [PATCH 5/8] tty/serial: at91: add dtr " Richard Genoud
2014-02-07 15:21 ` Alexander Shiyan
2014-02-10 10:24 ` Richard Genoud
2014-02-10 10:37 ` Nicolas Ferre
2014-02-07 14:59 ` [PATCH 6/8] tty/serial: at91: add dsr " Richard Genoud
2014-02-07 14:59 ` [PATCH 7/8] tty/serial: at91: add ring " Richard Genoud
2014-02-07 14:59 ` [PATCH 8/8] tty/serial: at91: add dcd " Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391785155-18525-3-git-send-email-richard.genoud@gmail.com \
--to=richard.genoud@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).