[PATCH] ARM: tegra: enable I2C MUX PCA954x

[PATCH] ARM: tegra: enable I2C MUX PCA954x

[Bryan Wu]

Cardhu has a PCA9546 for I2C bus extension, which connects to 3
cameras. It's required for Tegra V4L2 soc camera driver and camera
sensor drivers.

Signed-off-by: Bryan Wu <pengw@nvidia.com>
---
 arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
 arch/arm/configs/tegra_defconfig      | 1 +
 2 files changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
index 9104224..bfce643 100644
--- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
+++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
@@ -187,6 +187,14 @@
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
 		};
+
+		/* NXP PCA9546 I2C Mux */
+		pca9546 at 70 {
+			compatible = "nxp,pca9546";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x70>;
+		};
 	};
 
 	i2c at 7000c700 {
diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig
index 995d434..efcf15f 100644
--- a/arch/arm/configs/tegra_defconfig
+++ b/arch/arm/configs/tegra_defconfig
@@ -125,6 +125,7 @@ CONFIG_SERIAL_TEGRA=y
 CONFIG_SERIAL_OF_PLATFORM=y
 # CONFIG_HW_RANDOM is not set
 # CONFIG_I2C_COMPAT is not set
+CONFIG_I2C_MUX_PCA954x=y
 CONFIG_I2C_MUX_PINCTRL=y
 CONFIG_I2C_TEGRA=y
 CONFIG_SPI=y
-- 
1.8.3.2

[PATCH] ARM: tegra: enable I2C MUX PCA954x

[Stephen Warren]

On 02/07/2014 01:53 PM, Bryan Wu wrote:
> Cardhu has a PCA9546 for I2C bus extension, which connects to 3
> cameras. It's required for Tegra V4L2 soc camera driver and camera
> sensor drivers.

>  arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
>  arch/arm/configs/tegra_defconfig      | 1 +

DT and defconfig changes go into separate branches. Could I get this
split into two patches please?

> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi

> +		/* NXP PCA9546 I2C Mux */

That comment isn't useful, since the compatible value below spells out
what the device is.

> +		pca9546 at 70 {

DT nodes should be named after the class/type of device, not the
identify. As such, use "i2cmux at 70".

[PATCH] ARM: tegra: enable I2C MUX PCA954x

[Bryan Wu]

On Fri, Feb 7, 2014 at 3:34 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 02/07/2014 01:53 PM, Bryan Wu wrote:
>> Cardhu has a PCA9546 for I2C bus extension, which connects to 3
>> cameras. It's required for Tegra V4L2 soc camera driver and camera
>> sensor drivers.
>
>>  arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
>>  arch/arm/configs/tegra_defconfig      | 1 +
>
> DT and defconfig changes go into separate branches. Could I get this
> split into two patches please?
>
>> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
>
>> +             /* NXP PCA9546 I2C Mux */
>
> That comment isn't useful, since the compatible value below spells out
> what the device is.
>
>> +             pca9546 at 70 {
>
> DT nodes should be named after the class/type of device, not the
> identify. As such, use "i2cmux at 70".
>

OK, cool. I will take all the comments and post my V2 patches.