[PATCH 1/2] ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

[PATCH 1/2] ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

[Bryan Wu]

PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras.
Enabling this driver for Tegra V4L2 soc camera driver and camera
sensor drivers.

Signed-off-by: Bryan Wu <pengw@nvidia.com>
---
 arch/arm/configs/tegra_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig
index 995d434..efcf15f 100644
--- a/arch/arm/configs/tegra_defconfig
+++ b/arch/arm/configs/tegra_defconfig
@@ -125,6 +125,7 @@ CONFIG_SERIAL_TEGRA=y
 CONFIG_SERIAL_OF_PLATFORM=y
 # CONFIG_HW_RANDOM is not set
 # CONFIG_I2C_COMPAT is not set
+CONFIG_I2C_MUX_PCA954x=y
 CONFIG_I2C_MUX_PINCTRL=y
 CONFIG_I2C_TEGRA=y
 CONFIG_SPI=y
-- 
1.8.3.2

[PATCH 2/2] ARM: tegra: enable PCA9546 on Cardhu

[Bryan Wu]

Cardhu has a PCA9546 for I2C bus extension, which connects to 3
cameras. It's required for Tegra V4L2 soc camera driver and camera
sensor drivers.

Signed-off-by: Bryan Wu <pengw@nvidia.com>
---
 arch/arm/boot/dts/tegra30-cardhu.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
index 9104224..004002c 100644
--- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
+++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
@@ -187,6 +187,13 @@
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
 		};
+
+		i2cmux at 70 {
+			compatible = "nxp,pca9546";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x70>;
+		};
 	};
 
 	i2c at 7000c700 {
-- 
1.8.3.2

[PATCH 1/2] ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

[Stephen Warren]

On 02/07/2014 04:54 PM, Bryan Wu wrote:
> PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras.
> Enabling this driver for Tegra V4L2 soc camera driver and camera
> sensor drivers.

I've squashed patch 1/2 into Tegra's for-3.15/defconfig branch, and
applied patch 2/2 to Tegra's for-3.15/dt branch.

Note that your patches were sent with an email "From" address that
didn't match your signed-off-by tag, yet "git send-email" didn't insert
a "From" header in the email body. Can you please check your git user ID
and/or email settings. Consequently, I had to adjust the git author
field in git to match your s-o-b line.

[PATCH 1/2] ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

[Bryan Wu]

On Wed, Feb 12, 2014 at 11:08 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 02/07/2014 04:54 PM, Bryan Wu wrote:
>> PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras.
>> Enabling this driver for Tegra V4L2 soc camera driver and camera
>> sensor drivers.
>
> I've squashed patch 1/2 into Tegra's for-3.15/defconfig branch, and
> applied patch 2/2 to Tegra's for-3.15/dt branch.
>
> Note that your patches were sent with an email "From" address that
> didn't match your signed-off-by tag, yet "git send-email" didn't insert
> a "From" header in the email body. Can you please check your git user ID
> and/or email settings. Consequently, I had to adjust the git author
> field in git to match your s-o-b line.

My bad. I need to update my git send-email script to use --from "Bryan
Wu <pengw@nvidia.com>" instead of --from "Bryan Wu
<cooloney@gmail.com>"

Need I resubmit this patchset?

Thanks,
-Bryan

[PATCH 1/2] ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

[Stephen Warren]

On 02/12/2014 01:09 PM, Bryan Wu wrote:
> On Wed, Feb 12, 2014 at 11:08 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 02/07/2014 04:54 PM, Bryan Wu wrote:
>>> PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras.
>>> Enabling this driver for Tegra V4L2 soc camera driver and camera
>>> sensor drivers.
>>
>> I've squashed patch 1/2 into Tegra's for-3.15/defconfig branch, and
>> applied patch 2/2 to Tegra's for-3.15/dt branch.
>>
>> Note that your patches were sent with an email "From" address that
>> didn't match your signed-off-by tag, yet "git send-email" didn't insert
>> a "From" header in the email body. Can you please check your git user ID
>> and/or email settings. Consequently, I had to adjust the git author
>> field in git to match your s-o-b line.
> 
> My bad. I need to update my git send-email script to use --from "Bryan
> Wu <pengw@nvidia.com>" instead of --from "Bryan Wu
> <cooloney@gmail.com>"
> 
> Need I resubmit this patchset?

No need to resent; I fixed them up.

Why not just put the correct values in ~/.gitconfig?

Perhaps this is because you switch between NVIDIA and non-NVIDIA email
addresses and/or mail servers, so you can't make ~/.gitconfig static and
universally correct? If you have a recent enough git, what I do is:

$ cat ~/.gitconfig
[include]
        path = .gitconfig-user
        path = .gitconfig-email-server
...

$ cat ~/.gitconfig-user-nvidia
[user]
	name = Stephen Warren
	email = swarren at nvidia.com

$ cat ~/.gitconfig-user-wwwdotorg
[user]
	name = Stephen Warren
	email = swarren at wwwdotorg.org

~/.gitconfig-user is a symlink to one of ~/.gitconfig-user-*, and I have
a script that deletes the link and points it at a new location:

$ cat `which git-switch-user`
#!/bin/bash

cd $HOME
mainfile=.gitconfig-user
newlink=${mainfile}-$1
if [ ! -f ${newlink} ]; then
    echo ERROR: ${newlink} not found
    exit 1
fi

rm -f ${mainfile}
ln -s ${newlink} ${mainfile}

... and the same thing for email servers.

Then, I can run e.g.:

git-switch-email-server nvidia; \
git send-email --to internal at nvidia.com *.patch; \
git-switch-email-server severn-port-forwarded

[PATCH 1/2] ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

[Bryan Wu]

On Wed, Feb 12, 2014 at 12:17 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 02/12/2014 01:09 PM, Bryan Wu wrote:
>> On Wed, Feb 12, 2014 at 11:08 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>> On 02/07/2014 04:54 PM, Bryan Wu wrote:
>>>> PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras.
>>>> Enabling this driver for Tegra V4L2 soc camera driver and camera
>>>> sensor drivers.
>>>
>>> I've squashed patch 1/2 into Tegra's for-3.15/defconfig branch, and
>>> applied patch 2/2 to Tegra's for-3.15/dt branch.
>>>
>>> Note that your patches were sent with an email "From" address that
>>> didn't match your signed-off-by tag, yet "git send-email" didn't insert
>>> a "From" header in the email body. Can you please check your git user ID
>>> and/or email settings. Consequently, I had to adjust the git author
>>> field in git to match your s-o-b line.
>>
>> My bad. I need to update my git send-email script to use --from "Bryan
>> Wu <pengw@nvidia.com>" instead of --from "Bryan Wu
>> <cooloney@gmail.com>"
>>
>> Need I resubmit this patchset?
>
> No need to resent; I fixed them up.
>
> Why not just put the correct values in ~/.gitconfig?
>
> Perhaps this is because you switch between NVIDIA and non-NVIDIA email
> addresses and/or mail servers, so you can't make ~/.gitconfig static and
> universally correct? If you have a recent enough git, what I do is:
>
> $ cat ~/.gitconfig
> [include]
>         path = .gitconfig-user
>         path = .gitconfig-email-server
> ...
>
> $ cat ~/.gitconfig-user-nvidia
> [user]
>         name = Stephen Warren
>         email = swarren at nvidia.com
>
> $ cat ~/.gitconfig-user-wwwdotorg
> [user]
>         name = Stephen Warren
>         email = swarren at wwwdotorg.org
>
> ~/.gitconfig-user is a symlink to one of ~/.gitconfig-user-*, and I have
> a script that deletes the link and points it at a new location:
>
> $ cat `which git-switch-user`
> #!/bin/bash
>
> cd $HOME
> mainfile=.gitconfig-user
> newlink=${mainfile}-$1
> if [ ! -f ${newlink} ]; then
>     echo ERROR: ${newlink} not found
>     exit 1
> fi
>
> rm -f ${mainfile}
> ln -s ${newlink} ${mainfile}
>
> ... and the same thing for email servers.
>
> Then, I can run e.g.:
>
> git-switch-email-server nvidia; \
> git send-email --to internal at nvidia.com *.patch; \
> git-switch-email-server severn-port-forwarded

Awesome, I will firstly update my .gitconfig. Actually I basically
just have one outbound server which is gmail server. Although I put
From: @nvidia.com, I still use gmail server to send out patch emails.
Still don't wanna touch our internal email server.

Thanks a lot and it's really helpful.
-Bryan

[PATCH 1/2] ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

[Stephen Warren]

On 02/12/2014 02:55 PM, Bryan Wu wrote:
> On Wed, Feb 12, 2014 at 12:17 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 02/12/2014 01:09 PM, Bryan Wu wrote:
>>> On Wed, Feb 12, 2014 at 11:08 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>>> On 02/07/2014 04:54 PM, Bryan Wu wrote:
>>>>> PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras.
>>>>> Enabling this driver for Tegra V4L2 soc camera driver and camera
>>>>> sensor drivers.
...
>>>> Note that your patches were sent with an email "From" address that
>>>> didn't match your signed-off-by tag, yet "git send-email" didn't insert
>>>> a "From" header in the email body. Can you please check your git user ID
>>>> and/or email settings. Consequently, I had to adjust the git author
>>>> field in git to match your s-o-b line.
...
>> Why not just put the correct values in ~/.gitconfig?
>>
>> Perhaps this is because you switch between NVIDIA and non-NVIDIA email
>> addresses and/or mail servers, so you can't make ~/.gitconfig static and
>> universally correct? If you have a recent enough git, what I do is:
...
> Awesome, I will firstly update my .gitconfig. Actually I basically
> just have one outbound server which is gmail server. Although I put
> From: @nvidia.com, I still use gmail server to send out patch emails.
> Still don't wanna touch our internal email server.

You shouldn't send email with a from address @nvidia.com from a server
other than NVIDIA's servers. If you do, plenty of people will drop the
email as SPAM, since NVIDIA publishes SPF[1] records (and perhaps other
email configuration) for nvidia.com. Since there are good reasons not to
use NVIDIA's email servers, that means: tell git the actual email
address you're sending from (for the email settings; you should set the
author/commit ID to your @nvidia.com address still).

[1] http://www.openspf.org/

$ dig -t spf nvidia.com
...
nvidia.com.		180	IN	SPF	\
	"v=spf1 mx/24 mx:nvidia.com/24 -all"

[PATCH 1/2] ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

[Bryan Wu]

On Wed, Feb 12, 2014 at 2:35 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 02/12/2014 02:55 PM, Bryan Wu wrote:
>> On Wed, Feb 12, 2014 at 12:17 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>> On 02/12/2014 01:09 PM, Bryan Wu wrote:
>>>> On Wed, Feb 12, 2014 at 11:08 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>>>> On 02/07/2014 04:54 PM, Bryan Wu wrote:
>>>>>> PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras.
>>>>>> Enabling this driver for Tegra V4L2 soc camera driver and camera
>>>>>> sensor drivers.
> ...
>>>>> Note that your patches were sent with an email "From" address that
>>>>> didn't match your signed-off-by tag, yet "git send-email" didn't insert
>>>>> a "From" header in the email body. Can you please check your git user ID
>>>>> and/or email settings. Consequently, I had to adjust the git author
>>>>> field in git to match your s-o-b line.
> ...
>>> Why not just put the correct values in ~/.gitconfig?
>>>
>>> Perhaps this is because you switch between NVIDIA and non-NVIDIA email
>>> addresses and/or mail servers, so you can't make ~/.gitconfig static and
>>> universally correct? If you have a recent enough git, what I do is:
> ...
>> Awesome, I will firstly update my .gitconfig. Actually I basically
>> just have one outbound server which is gmail server. Although I put
>> From: @nvidia.com, I still use gmail server to send out patch emails.
>> Still don't wanna touch our internal email server.
>
> You shouldn't send email with a from address @nvidia.com from a server
> other than NVIDIA's servers. If you do, plenty of people will drop the
> email as SPAM, since NVIDIA publishes SPF[1] records (and perhaps other
> email configuration) for nvidia.com. Since there are good reasons not to
> use NVIDIA's email servers, that means: tell git the actual email
> address you're sending from (for the email settings; you should set the
> author/commit ID to your @nvidia.com address still).
>
> [1] http://www.openspf.org/
>
> $ dig -t spf nvidia.com
> ...
> nvidia.com.             180     IN      SPF     \
>         "v=spf1 mx/24 mx:nvidia.com/24 -all"
>

Sure, I think I just missed to set the author as @nvidia.com but SOB
is @nvidia.com in this patchset. And I still should use --from "Bryan
Wu <cooloney@gmail.com>" for sending out email from gmail server.
Right?

Thanks,
-Bryan

[PATCH 1/2] ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

[Stephen Warren]

On 02/12/2014 04:23 PM, Bryan Wu wrote:
...
> Sure, I think I just missed to set the author as @nvidia.com but SOB
> is @nvidia.com in this patchset. And I still should use --from "Bryan
> Wu <cooloney@gmail.com>" for sending out email from gmail server.
> Right?

I think you want the following in ~/.gitconfig:

[user]
	name = Bryan Wu
	email = pengw at nvidia.com
[sendemail]
        from = Bryan Wu <cooloney@gmail.com>

I assume "--from xxx" is the same as setting the last variable I listed
above.

[PATCH 1/2] ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

[Bryan Wu]

On Wed, Feb 12, 2014 at 6:12 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 02/12/2014 04:23 PM, Bryan Wu wrote:
> ...
>> Sure, I think I just missed to set the author as @nvidia.com but SOB
>> is @nvidia.com in this patchset. And I still should use --from "Bryan
>> Wu <cooloney@gmail.com>" for sending out email from gmail server.
>> Right?
>
> I think you want the following in ~/.gitconfig:
>
> [user]
>         name = Bryan Wu
>         email = pengw at nvidia.com

I have these settings in my company machine.

> [sendemail]
>         from = Bryan Wu <cooloney@gmail.com>
>
> I assume "--from xxx" is the same as setting the last variable I listed
> above.

Yeah, I didn't put this in my .gitconfig but put them in my script
with "git send-mail".

Thanks,
-Bryan