From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] OF: update stdout-path parsing
Date: Sat, 8 Feb 2014 12:53:52 +0100 [thread overview]
Message-ID: <1391860433-5343-1-git-send-email-plagnioj@jcrosoft.com> (raw)
Today we only check if the linux,stdout-path property is present and retreive
the node. But the DT specification allow to pass the serial options too as
this
linux,stdout-path = &UART0;
or with options
inux,stdout-path = "/plb at 0/serial at 84000000:115200";
So update the parsing to support and also the backward compatible stdout-path
property.
Cc: linux-serial at vger.kernel.org
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
drivers/of/base.c | 57 +++++++++++++++++++++++++++++++++++++++++++++---------
include/linux/of.h | 4 ++--
2 files changed, 50 insertions(+), 11 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index ff85450..ab9ff2f 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -34,6 +34,7 @@ EXPORT_SYMBOL(of_allnodes);
struct device_node *of_chosen;
struct device_node *of_aliases;
static struct device_node *of_stdout;
+static char *of_stdout_option;
DEFINE_MUTEX(of_aliases_mutex);
@@ -1783,6 +1784,45 @@ static void of_alias_add(struct alias_prop *ap, struct device_node *np,
}
/**
+ * of_stdout_path_scan - check if a device node matches the
+ * linux,stdout-path property and parse it
+ */
+static void of_stdout_path_scan(void)
+{
+ const char *name;
+ const char *tmp;
+ const char *tmp_option;
+
+ name = of_get_property(of_chosen, "linux,stdout-path", NULL);
+ if (!name)
+ name = of_get_property(of_chosen, "stdout-path", NULL);
+
+ if (!name)
+ return;
+
+ tmp_option = strchr(name, ':');
+
+ if (!tmp_option) {
+ of_stdout = of_find_node_by_path(name);
+ return;
+ }
+
+ tmp = kstrndup(name, strlen(name) - strlen(tmp_option), GFP_KERNEL);
+ if (!tmp)
+ return;
+
+ of_stdout = of_find_node_by_path(tmp);
+ if (!of_stdout)
+ goto out;
+
+ tmp_option++;
+ of_stdout_option = kstrdup(tmp_option, GFP_KERNEL);
+
+out:
+ kfree(tmp);
+}
+
+/**
* of_alias_scan - Scan all properties of 'aliases' node
*
* The function scans all the properties of 'aliases' node and populate
@@ -1800,13 +1840,8 @@ void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align))
if (of_chosen == NULL)
of_chosen = of_find_node_by_path("/chosen at 0");
- if (of_chosen) {
- const char *name;
-
- name = of_get_property(of_chosen, "linux,stdout-path", NULL);
- if (name)
- of_stdout = of_find_node_by_path(name);
- }
+ if (of_chosen)
+ of_stdout_path_scan();
of_aliases = of_find_node_by_path("/aliases");
if (!of_aliases)
@@ -1923,13 +1958,17 @@ EXPORT_SYMBOL_GPL(of_prop_next_string);
* linux,stdout-path property
*
* Check if this device node matches the linux,stdout-path property
- * in the chosen node. return true if yes, false otherwise.
+ * in the chosen node. return true if yes, false otherwise with the option if
+ * requested.
*/
-int of_device_is_stdout_path(struct device_node *dn)
+int of_device_is_stdout_path(struct device_node *dn, char** option)
{
if (!of_stdout)
return false;
+ if (option)
+ *option = of_stdout_option;
+
return of_stdout == dn;
}
EXPORT_SYMBOL_GPL(of_device_is_stdout_path);
diff --git a/include/linux/of.h b/include/linux/of.h
index 70c64ba..a8afe44 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -352,7 +352,7 @@ const __be32 *of_prop_next_u32(struct property *prop, const __be32 *cur,
*/
const char *of_prop_next_string(struct property *prop, const char *cur);
-int of_device_is_stdout_path(struct device_node *dn);
+int of_device_is_stdout_path(struct device_node *dn, char** option);
#else /* CONFIG_OF */
@@ -542,7 +542,7 @@ static inline int of_machine_is_compatible(const char *compat)
return 0;
}
-static inline int of_device_is_stdout_path(struct device_node *dn)
+static inline int of_device_is_stdout_path(struct device_node *dn, char** option)
{
return 0;
}
--
1.9.rc1
next reply other threads:[~2014-02-08 11:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 11:53 Jean-Christophe PLAGNIOL-VILLARD [this message]
2014-02-08 11:53 ` [PATCH 2/2] serial: atmel: evaluate linux,stdout-path property Jean-Christophe PLAGNIOL-VILLARD
2014-02-11 14:54 ` [PATCH 1/2] OF: update stdout-path parsing Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391860433-5343-1-git-send-email-plagnioj@jcrosoft.com \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox