From: standby24x7@gmail.com (Masanari Iida)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk:at91: Fix memory leak in of_at91_clk_master_setup()
Date: Tue, 11 Feb 2014 22:15:07 +0900 [thread overview]
Message-ID: <1392124507-14463-1-git-send-email-standby24x7@gmail.com> (raw)
cppcheck detected following error
[clk-master.c:245]: (error) Memory leak: characteristics
The original code forgot to free characteristics when
irq_of_parse_and_map() failed.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
drivers/clk/at91/clk-master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/at91/clk-master.c b/drivers/clk/at91/clk-master.c
index bd313f7..c1af80b 100644
--- a/drivers/clk/at91/clk-master.c
+++ b/drivers/clk/at91/clk-master.c
@@ -242,7 +242,7 @@ of_at91_clk_master_setup(struct device_node *np, struct at91_pmc *pmc,
irq = irq_of_parse_and_map(np, 0);
if (!irq)
- return;
+ goto out_free_characteristics;
clk = at91_clk_register_master(pmc, irq, name, num_parents,
parent_names, layout,
--
1.9.rc1
next reply other threads:[~2014-02-11 13:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 13:15 Masanari Iida [this message]
2014-02-11 13:18 ` [PATCH] clk:at91: Fix memory leak in of_at91_clk_master_setup() Boris BREZILLON
2014-02-15 17:08 ` Boris BREZILLON
2014-02-27 2:02 ` Mike Turquette
2014-02-27 8:21 ` Boris BREZILLON
2014-02-15 16:46 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392124507-14463-1-git-send-email-standby24x7@gmail.com \
--to=standby24x7@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).