* [PATCH] clk:at91: Fix memory leak in of_at91_clk_master_setup()
@ 2014-02-11 13:15 Masanari Iida
2014-02-11 13:18 ` Boris BREZILLON
2014-02-15 16:46 ` Alexandre Belloni
0 siblings, 2 replies; 6+ messages in thread
From: Masanari Iida @ 2014-02-11 13:15 UTC (permalink / raw)
To: linux-arm-kernel
cppcheck detected following error
[clk-master.c:245]: (error) Memory leak: characteristics
The original code forgot to free characteristics when
irq_of_parse_and_map() failed.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
drivers/clk/at91/clk-master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/at91/clk-master.c b/drivers/clk/at91/clk-master.c
index bd313f7..c1af80b 100644
--- a/drivers/clk/at91/clk-master.c
+++ b/drivers/clk/at91/clk-master.c
@@ -242,7 +242,7 @@ of_at91_clk_master_setup(struct device_node *np, struct at91_pmc *pmc,
irq = irq_of_parse_and_map(np, 0);
if (!irq)
- return;
+ goto out_free_characteristics;
clk = at91_clk_register_master(pmc, irq, name, num_parents,
parent_names, layout,
--
1.9.rc1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] clk:at91: Fix memory leak in of_at91_clk_master_setup()
2014-02-11 13:15 [PATCH] clk:at91: Fix memory leak in of_at91_clk_master_setup() Masanari Iida
@ 2014-02-11 13:18 ` Boris BREZILLON
2014-02-15 17:08 ` Boris BREZILLON
2014-02-15 16:46 ` Alexandre Belloni
1 sibling, 1 reply; 6+ messages in thread
From: Boris BREZILLON @ 2014-02-11 13:18 UTC (permalink / raw)
To: linux-arm-kernel
On 11/02/2014 14:15, Masanari Iida wrote:
> cppcheck detected following error
> [clk-master.c:245]: (error) Memory leak: characteristics
>
> The original code forgot to free characteristics when
> irq_of_parse_and_map() failed.
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Acked-by Boris BREZILLON <b.brezillon@overkiz.com>
Thanks for fixing this.
Best Regards,
Boris
> ---
> drivers/clk/at91/clk-master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/at91/clk-master.c b/drivers/clk/at91/clk-master.c
> index bd313f7..c1af80b 100644
> --- a/drivers/clk/at91/clk-master.c
> +++ b/drivers/clk/at91/clk-master.c
> @@ -242,7 +242,7 @@ of_at91_clk_master_setup(struct device_node *np, struct at91_pmc *pmc,
>
> irq = irq_of_parse_and_map(np, 0);
> if (!irq)
> - return;
> + goto out_free_characteristics;
>
> clk = at91_clk_register_master(pmc, irq, name, num_parents,
> parent_names, layout,
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] clk:at91: Fix memory leak in of_at91_clk_master_setup()
2014-02-11 13:18 ` Boris BREZILLON
@ 2014-02-15 17:08 ` Boris BREZILLON
2014-02-27 2:02 ` Mike Turquette
0 siblings, 1 reply; 6+ messages in thread
From: Boris BREZILLON @ 2014-02-15 17:08 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mike,
Could you take this patch for the next 3.14 release ?
Best Regards,
Boris
On 11/02/2014 14:18, Boris BREZILLON wrote:
> On 11/02/2014 14:15, Masanari Iida wrote:
>> cppcheck detected following error
>> [clk-master.c:245]: (error) Memory leak: characteristics
>>
>> The original code forgot to free characteristics when
>> irq_of_parse_and_map() failed.
>>
>> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> Acked-by Boris BREZILLON <b.brezillon@overkiz.com>
>
> Thanks for fixing this.
>
> Best Regards,
>
> Boris
>> ---
>> drivers/clk/at91/clk-master.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/at91/clk-master.c
>> b/drivers/clk/at91/clk-master.c
>> index bd313f7..c1af80b 100644
>> --- a/drivers/clk/at91/clk-master.c
>> +++ b/drivers/clk/at91/clk-master.c
>> @@ -242,7 +242,7 @@ of_at91_clk_master_setup(struct device_node *np,
>> struct at91_pmc *pmc,
>> irq = irq_of_parse_and_map(np, 0);
>> if (!irq)
>> - return;
>> + goto out_free_characteristics;
>> clk = at91_clk_register_master(pmc, irq, name, num_parents,
>> parent_names, layout,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] clk:at91: Fix memory leak in of_at91_clk_master_setup()
2014-02-15 17:08 ` Boris BREZILLON
@ 2014-02-27 2:02 ` Mike Turquette
2014-02-27 8:21 ` Boris BREZILLON
0 siblings, 1 reply; 6+ messages in thread
From: Mike Turquette @ 2014-02-27 2:02 UTC (permalink / raw)
To: linux-arm-kernel
Quoting Boris BREZILLON (2014-02-15 09:08:12)
> Hi Mike,
>
> Could you take this patch for the next 3.14 release ?
Taken in for the next batch of fixes.
Regards,
Mike
>
> Best Regards,
>
> Boris
>
> On 11/02/2014 14:18, Boris BREZILLON wrote:
> > On 11/02/2014 14:15, Masanari Iida wrote:
> >> cppcheck detected following error
> >> [clk-master.c:245]: (error) Memory leak: characteristics
> >>
> >> The original code forgot to free characteristics when
> >> irq_of_parse_and_map() failed.
> >>
> >> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> > Acked-by Boris BREZILLON <b.brezillon@overkiz.com>
> >
> > Thanks for fixing this.
> >
> > Best Regards,
> >
> > Boris
> >> ---
> >> drivers/clk/at91/clk-master.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/clk/at91/clk-master.c
> >> b/drivers/clk/at91/clk-master.c
> >> index bd313f7..c1af80b 100644
> >> --- a/drivers/clk/at91/clk-master.c
> >> +++ b/drivers/clk/at91/clk-master.c
> >> @@ -242,7 +242,7 @@ of_at91_clk_master_setup(struct device_node *np,
> >> struct at91_pmc *pmc,
> >> irq = irq_of_parse_and_map(np, 0);
> >> if (!irq)
> >> - return;
> >> + goto out_free_characteristics;
> >> clk = at91_clk_register_master(pmc, irq, name, num_parents,
> >> parent_names, layout,
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] clk:at91: Fix memory leak in of_at91_clk_master_setup()
2014-02-27 2:02 ` Mike Turquette
@ 2014-02-27 8:21 ` Boris BREZILLON
0 siblings, 0 replies; 6+ messages in thread
From: Boris BREZILLON @ 2014-02-27 8:21 UTC (permalink / raw)
To: linux-arm-kernel
On 27/02/2014 03:02, Mike Turquette wrote:
> Quoting Boris BREZILLON (2014-02-15 09:08:12)
>> Hi Mike,
>>
>> Could you take this patch for the next 3.14 release ?
> Taken in for the next batch of fixes.
Thanks.
>
> Regards,
> Mike
>
>> Best Regards,
>>
>> Boris
>>
>> On 11/02/2014 14:18, Boris BREZILLON wrote:
>>> On 11/02/2014 14:15, Masanari Iida wrote:
>>>> cppcheck detected following error
>>>> [clk-master.c:245]: (error) Memory leak: characteristics
>>>>
>>>> The original code forgot to free characteristics when
>>>> irq_of_parse_and_map() failed.
>>>>
>>>> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
>>> Acked-by Boris BREZILLON <b.brezillon@overkiz.com>
>>>
>>> Thanks for fixing this.
>>>
>>> Best Regards,
>>>
>>> Boris
>>>> ---
>>>> drivers/clk/at91/clk-master.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/clk/at91/clk-master.c
>>>> b/drivers/clk/at91/clk-master.c
>>>> index bd313f7..c1af80b 100644
>>>> --- a/drivers/clk/at91/clk-master.c
>>>> +++ b/drivers/clk/at91/clk-master.c
>>>> @@ -242,7 +242,7 @@ of_at91_clk_master_setup(struct device_node *np,
>>>> struct at91_pmc *pmc,
>>>> irq = irq_of_parse_and_map(np, 0);
>>>> if (!irq)
>>>> - return;
>>>> + goto out_free_characteristics;
>>>> clk = at91_clk_register_master(pmc, irq, name, num_parents,
>>>> parent_names, layout,
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] clk:at91: Fix memory leak in of_at91_clk_master_setup()
2014-02-11 13:15 [PATCH] clk:at91: Fix memory leak in of_at91_clk_master_setup() Masanari Iida
2014-02-11 13:18 ` Boris BREZILLON
@ 2014-02-15 16:46 ` Alexandre Belloni
1 sibling, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2014-02-15 16:46 UTC (permalink / raw)
To: linux-arm-kernel
On 11/02/2014 at 22:15:07 +0900, Masanari Iida wrote :
> cppcheck detected following error
> [clk-master.c:245]: (error) Memory leak: characteristics
>
> The original code forgot to free characteristics when
> irq_of_parse_and_map() failed.
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/clk/at91/clk-master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/at91/clk-master.c b/drivers/clk/at91/clk-master.c
> index bd313f7..c1af80b 100644
> --- a/drivers/clk/at91/clk-master.c
> +++ b/drivers/clk/at91/clk-master.c
> @@ -242,7 +242,7 @@ of_at91_clk_master_setup(struct device_node *np, struct at91_pmc *pmc,
>
> irq = irq_of_parse_and_map(np, 0);
> if (!irq)
> - return;
> + goto out_free_characteristics;
>
> clk = at91_clk_register_master(pmc, irq, name, num_parents,
> parent_names, layout,
> --
> 1.9.rc1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-27 8:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-11 13:15 [PATCH] clk:at91: Fix memory leak in of_at91_clk_master_setup() Masanari Iida
2014-02-11 13:18 ` Boris BREZILLON
2014-02-15 17:08 ` Boris BREZILLON
2014-02-27 2:02 ` Mike Turquette
2014-02-27 8:21 ` Boris BREZILLON
2014-02-15 16:46 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).