From: standby24x7@gmail.com (Masanari Iida)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk:ti: Fix memory leak in of_ti_composite_divider_clk_setup()
Date: Tue, 11 Feb 2014 22:25:41 +0900 [thread overview]
Message-ID: <1392125141-14769-1-git-send-email-standby24x7@gmail.com> (raw)
cppcheck detected following error
[drivers/clk/ti/divider.c:480]: (error) Memory leak: div
The original code forgot to free div and just returned.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
drivers/clk/ti/divider.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/ti/divider.c b/drivers/clk/ti/divider.c
index a15e445..a105d94 100644
--- a/drivers/clk/ti/divider.c
+++ b/drivers/clk/ti/divider.c
@@ -477,7 +477,6 @@ static void __init of_ti_composite_divider_clk_setup(struct device_node *node)
goto cleanup;
if (!ti_clk_add_component(node, &div->hw, CLK_COMPONENT_TYPE_DIVIDER))
- return;
cleanup:
kfree(div->table);
--
1.9.rc1
reply other threads:[~2014-02-11 13:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392125141-14769-1-git-send-email-standby24x7@gmail.com \
--to=standby24x7@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).