linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: acourbot@nvidia.com (Alexandre Courbot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: tegra: cpuidle: use firmware for power down
Date: Wed, 12 Feb 2014 11:43:44 +0900	[thread overview]
Message-ID: <1392173024-11567-1-git-send-email-acourbot@nvidia.com> (raw)
In-Reply-To: <52FAD4C2.80803@nvidia.com>

Attempt to invoke the prepare_idle() and do_idle() firmware calls
to power down a CPU so an underlying firmware gets informed of
the idle operation and performs it by itself if designed in such a way.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
This is the only v3 patch in the series.

Changes since v2:
- Use an if statement instead of a switch to handle the single return
  code we need to care about.

 arch/arm/mach-tegra/cpuidle-tegra114.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-tegra/cpuidle-tegra114.c b/arch/arm/mach-tegra/cpuidle-tegra114.c
index e0b87300243d..b5fb7c110c64 100644
--- a/arch/arm/mach-tegra/cpuidle-tegra114.c
+++ b/arch/arm/mach-tegra/cpuidle-tegra114.c
@@ -19,6 +19,7 @@
 #include <linux/cpuidle.h>
 #include <linux/cpu_pm.h>
 #include <linux/clockchips.h>
+#include <asm/firmware.h>
 
 #include <asm/cpuidle.h>
 #include <asm/suspend.h>
@@ -45,7 +46,11 @@ static int tegra114_idle_power_down(struct cpuidle_device *dev,
 
 	clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &dev->cpu);
 
-	cpu_suspend(0, tegra30_sleep_cpu_secondary_finish);
+	call_firmware_op(prepare_idle);
+
+	/* Do suspend by ourselves if the firmware does not implement it */
+	if (call_firmware_op(do_idle) == -ENOSYS)
+		cpu_suspend(0, tegra30_sleep_cpu_secondary_finish);
 
 	clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &dev->cpu);
 
-- 
1.8.5.4

  reply	other threads:[~2014-02-12  2:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07  4:35 [PATCH v2 0/6] ARM: firmware: improvements to Trusted Foundations support Alexandre Courbot
2014-02-07  4:35 ` [PATCH v2 1/6] ARM: trusted_foundations: fix vendor prefix typos Alexandre Courbot
2014-02-07  4:35 ` [PATCH v2 2/6] ARM: trusted_foundations: fallback when TF support is missing Alexandre Courbot
2014-02-07  4:35 ` [PATCH v2 3/6] ARM: firmware: enable Trusted Foundations by default Alexandre Courbot
2014-02-07  4:35 ` [PATCH v2 4/6] ARM: firmware: add prepare_idle() operation Alexandre Courbot
2014-02-13 11:01   ` Tomasz Figa
2014-02-13 16:37     ` Stephen Warren
2014-02-14  5:16     ` Alexandre Courbot
2014-02-14 10:42       ` Tomasz Figa
2014-02-07  4:35 ` [PATCH v2 5/6] ARM: trusted_foundations: implement prepare_idle() Alexandre Courbot
2014-02-07  4:35 ` [PATCH v2 6/6] ARM: tegra: cpuidle: use firmware for power down Alexandre Courbot
2014-02-12  1:36   ` Olof Johansson
2014-02-12  1:56     ` Alexandre Courbot
2014-02-12  2:43       ` Alexandre Courbot [this message]
2014-02-12 20:04         ` [PATCH v3] " Olof Johansson
2014-02-12  1:38 ` [PATCH v2 0/6] ARM: firmware: improvements to Trusted Foundations support Olof Johansson
2014-02-12 20:07   ` Stephen Warren
2014-02-18 20:56 ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392173024-11567-1-git-send-email-acourbot@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).