From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/14] net: axienet: Removed checkpatch errors/warnings
Date: Wed, 12 Feb 2014 16:31:34 -0800 [thread overview]
Message-ID: <1392251494.2214.11.camel@joe-AO722> (raw)
In-Reply-To: <75b669c0a947effe74b291093abfa8c71f83736a.1392220536.git.michal.simek@xilinx.com>
On Wed, 2014-02-12 at 16:55 +0100, Michal Simek wrote:
> From: Srikanth Thokala <srikanth.thokala@xilinx.com>
trivia:
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> + netdev_err(lp->ndev,
> + "axienet_device_reset DMA reset timeout!\n");
could you please align multi-line arguments to the
appropriate open parenthesis?
netdev_err(lp->ndev,
"axienet_device_reset DMA reset timeout!\n");
or maybe:
netdev_err(lp->ndev, "%s: "DMA reset timeout!\n",
__func__);
> @@ -484,8 +484,8 @@ static void axienet_device_reset(struct net_device *ndev)
> }
>
> if (axienet_dma_bd_init(ndev)) {
> - dev_err(&ndev->dev, "axienet_device_reset descriptor "
> - "allocation failed\n");
> + netdev_err(ndev,
> + "axienet_device_reset descriptor allocation failed\n");
etc, et al.
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
[]
> @@ -161,19 +161,19 @@ int axienet_mdio_setup(struct axienet_local *lp, struct device_node *np)
>
> np1 = of_find_node_by_name(NULL, "cpu");
> if (!np1) {
> - printk(KERN_WARNING "%s(): Could not find CPU device node.",
> - __func__);
> - printk(KERN_WARNING "Setting MDIO clock divisor to "
> - "default %d\n", DEFAULT_CLOCK_DIVISOR);
> + netdev_warn(lp->ndev, "Could not find CPU device node.");
missing trailing "\n" to terminate message.
> + netdev_warn(lp->ndev,
> + "Could not find clock ethernet controller property.");
here too. (and alignment)
next prev parent reply other threads:[~2014-02-13 0:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 15:55 [PATCH 0/14] Xilinx axi ethernet patches Michal Simek
2014-02-12 15:55 ` [PATCH 01/14] net: axienet: Fix compilation error Michal Simek
2014-02-12 15:55 ` [PATCH 02/14] net: axienet: Fix compilation warnings Michal Simek
2014-02-12 15:55 ` [PATCH 03/14] net: axienet: Support for RGMII Michal Simek
2014-02-12 15:55 ` [PATCH 04/14] net: axienet: Handle 0 packet receive gracefully Michal Simek
2014-02-12 15:55 ` [PATCH 05/14] net: axienet: Service completion interrupts ASAP Michal Simek
2014-02-12 16:38 ` David Laight
2014-02-12 15:55 ` [PATCH 06/14] net: axienet: Handle jumbo frames for lesser frame sizes Michal Simek
2014-02-12 15:55 ` [PATCH 07/14] net: axienet: Support phy-less mode of operation Michal Simek
2014-02-12 15:55 ` [PATCH 08/14] net: axienet: Removed checkpatch errors/warnings Michal Simek
2014-02-13 0:31 ` Joe Perches [this message]
2014-02-13 7:19 ` Michal Simek
2014-02-13 15:51 ` Joe Perches
2014-02-14 9:21 ` Michal Simek
2014-02-12 15:55 ` [PATCH 09/14] net: axienet: Fix comments blocks Michal Simek
2014-02-12 15:55 ` [PATCH 10/14] net: axienet: Use pdev instead of op Michal Simek
2014-02-12 15:55 ` [PATCH 11/14] net: axienet: Use devm_* calls Michal Simek
2014-02-12 15:55 ` [PATCH 12/14] net: axienet: Use of_property_* calls Michal Simek
2014-02-12 15:55 ` [PATCH 13/14] net: axienet: Removed _of_ prefix in probe and remove functions Michal Simek
2014-02-12 15:55 ` [PATCH 14/14] net: axienet: Fix kernel-doc warnings Michal Simek
2014-02-13 0:18 ` [PATCH 0/14] Xilinx axi ethernet patches David Miller
2014-02-13 7:00 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392251494.2214.11.camel@joe-AO722 \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).