From: Parvathi Pudi <parvathi@couthit.com>
To: pabeni <pabeni@redhat.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>, tony <tony@atomide.com>,
edumazet <edumazet@google.com>, glaroque <glaroque@baylibre.com>,
pmohan <pmohan@couthit.com>, diogo ivo <diogo.ivo@siemens.com>,
robh <robh@kernel.org>,
javier carrasco cruz <javier.carrasco.cruz@gmail.com>,
praneeth <praneeth@ti.com>, m-karicheri2 <m-karicheri2@ti.com>,
basharath <basharath@couthit.com>, kuba <kuba@kernel.org>,
richardcochran <richardcochran@gmail.com>,
devicetree <devicetree@vger.kernel.org>,
conor+dt <conor+dt@kernel.org>, schnelle <schnelle@linux.ibm.com>,
mohan <mohan@couthit.com>, s hauer <s.hauer@pengutronix.de>,
Prajith Jayarajan <prajith@ti.com>, rogerq <rogerq@kernel.org>,
jacob e keller <jacob.e.keller@intel.com>,
ssantosh <ssantosh@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
rogerq <rogerq@ti.com>, srk <srk@ti.com>,
pratheesh <pratheesh@ti.com>, m-malladi <m-malladi@ti.com>,
netdev <netdev@vger.kernel.org>, rdunlap <rdunlap@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
danishanwar <danishanwar@ti.com>, afd <afd@ti.com>,
andrew+netdev <andrew+netdev@lunn.ch>,
parvathi <parvathi@couthit.com>, horms <horms@kernel.org>,
krishna <krishna@couthit.com>, krzk+dt <krzk+dt@kernel.org>,
davem <davem@davemloft.net>
Subject: Re: [PATCH net-next v7 03/11] net: ti: prueth: Adds PRUETH HW and SW configuration
Date: Wed, 7 May 2025 18:26:01 +0530 (IST) [thread overview]
Message-ID: <139244603.1233564.1746622561934.JavaMail.zimbra@couthit.local> (raw)
In-Reply-To: <19f4f38b-9962-41d6-97b7-e254db3c6dee@redhat.com>
Hi,
> On 5/3/25 2:10 PM, Parvathi Pudi wrote:
>> +static int icssm_prueth_emac_config(struct prueth_emac *emac)
>> +{
>> + struct prueth *prueth = emac->prueth;
>> +
>> + /* PRU needs local shared RAM address for C28 */
>> + u32 sharedramaddr = ICSS_LOCAL_SHARED_RAM;
>> +
>> + /* PRU needs real global OCMC address for C30*/
>> + u32 ocmcaddr = (u32)prueth->mem[PRUETH_MEM_OCMC].pa;
>> + void __iomem *dram_base;
>> + void __iomem *mac_addr;
>> + void __iomem *dram;
>
> Minor nit: please respect the reverse christmas tree order above.
>
> /P
We will address this in the next version.
Thanks and Regards,
Parvathi.
next prev parent reply other threads:[~2025-05-07 12:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-03 12:10 [PATCH net-next v7 00/11] PRU-ICSSM Ethernet Driver Parvathi Pudi
2025-05-03 12:10 ` [PATCH net-next v7 01/11] dt-bindings: net: ti: Adds DUAL-EMAC mode support on PRU-ICSS2 for AM57xx, AM43xx and AM33xx SOCs Parvathi Pudi
2025-05-12 15:23 ` Rob Herring (Arm)
2025-05-03 12:10 ` [PATCH net-next v7 02/11] net: ti: prueth: Adds ICSSM Ethernet driver Parvathi Pudi
2025-05-03 12:10 ` [PATCH net-next v7 03/11] net: ti: prueth: Adds PRUETH HW and SW configuration Parvathi Pudi
2025-05-06 10:07 ` Paolo Abeni
2025-05-07 12:56 ` Parvathi Pudi [this message]
2025-05-03 13:11 ` [PATCH net-next v7 04/11] net: ti: prueth: Adds link detection, RX and TX support Parvathi Pudi
2025-05-06 9:53 ` Paolo Abeni
2025-05-09 10:21 ` Parvathi Pudi
2025-05-03 13:11 ` [PATCH net-next v7 05/11] net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driver Parvathi Pudi
2025-05-03 13:11 ` [PATCH net-next v7 06/11] net: ti: prueth: Adds HW timestamping support for PTP using PRU-ICSS IEP module Parvathi Pudi
2025-05-03 13:11 ` [PATCH net-next v7 07/11] net: ti: prueth: Adds support for network filters for traffic control supported by PRU-ICSS Parvathi Pudi
2025-05-03 14:12 ` [PATCH net-next v7 08/11] net: ti: prueth: Adds support for RX interrupt coalescing/pacing Parvathi Pudi
2025-05-03 14:12 ` [PATCH net-next v7 09/11] net: ti: prueth: Adds power management support for PRU-ICSS Parvathi Pudi
2025-05-03 14:12 ` [PATCH net-next v7 10/11] net: ti: prueth: Adds support for PRUETH on AM33x and AM43x SOCs Parvathi Pudi
2025-05-03 14:12 ` [PATCH net-next v7 11/11] net: ti: prueth: Adds PTP OC Support for AM335x and AM437x Parvathi Pudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=139244603.1233564.1746622561934.JavaMail.zimbra@couthit.local \
--to=parvathi@couthit.com \
--cc=afd@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=basharath@couthit.com \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=glaroque@baylibre.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=krishna@couthit.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=m-malladi@ti.com \
--cc=mohan@couthit.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmohan@couthit.com \
--cc=prajith@ti.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=rogerq@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=schnelle@linux.ibm.com \
--cc=srk@ti.com \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox