* [PATCH] arm: omap3: cm-t35: remove MACH_CM_T3730
@ 2014-02-16 17:26 Paul Bolle
2014-02-17 12:33 ` Igor Grinberg
0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2014-02-16 17:26 UTC (permalink / raw)
To: linux-arm-kernel
The Kconfig symbol MACH_CM_T3730 was added in v3.1. It has never been
used. Setting it has no effect. There are no calls for
machine_is_cm_t3730(). This symbol can safely be removed.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Tested only with "git grep".
arch/arm/mach-omap2/Kconfig | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index 66da3f5..7d4934e 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -292,7 +292,6 @@ config MACH_CM_T35
bool "CompuLab CM-T35/CM-T3730 modules"
depends on ARCH_OMAP3
default y
- select MACH_CM_T3730
select OMAP_PACKAGE_CUS
config MACH_CM_T3517
@@ -301,9 +300,6 @@ config MACH_CM_T3517
default y
select OMAP_PACKAGE_CBB
-config MACH_CM_T3730
- bool
-
config MACH_SBC3530
bool "OMAP3 SBC STALKER board"
depends on ARCH_OMAP3
--
1.8.5.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] arm: omap3: cm-t35: remove MACH_CM_T3730
2014-02-16 17:26 [PATCH] arm: omap3: cm-t35: remove MACH_CM_T3730 Paul Bolle
@ 2014-02-17 12:33 ` Igor Grinberg
2014-02-17 12:48 ` Paul Bolle
0 siblings, 1 reply; 3+ messages in thread
From: Igor Grinberg @ 2014-02-17 12:33 UTC (permalink / raw)
To: linux-arm-kernel
Hi Paul,
On 02/16/14 19:26, Paul Bolle wrote:
> The Kconfig symbol MACH_CM_T3730 was added in v3.1. It has never been
> used. Setting it has no effect. There are no calls for
> machine_is_cm_t3730(). This symbol can safely be removed.
Indeed...
Is it such a burden to keep it just until we switch OMAP3 to DT?
Because, it makes a bit harder to hack on the kernel.
Well, not too much as it can be reverted, but still one needs
to remember to do this...
I'd like to keep it just until we remove the board files, please.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Tested only with "git grep".
>
> arch/arm/mach-omap2/Kconfig | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 66da3f5..7d4934e 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -292,7 +292,6 @@ config MACH_CM_T35
> bool "CompuLab CM-T35/CM-T3730 modules"
> depends on ARCH_OMAP3
> default y
> - select MACH_CM_T3730
> select OMAP_PACKAGE_CUS
>
> config MACH_CM_T3517
> @@ -301,9 +300,6 @@ config MACH_CM_T3517
> default y
> select OMAP_PACKAGE_CBB
>
> -config MACH_CM_T3730
> - bool
> -
> config MACH_SBC3530
> bool "OMAP3 SBC STALKER board"
> depends on ARCH_OMAP3
>
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] arm: omap3: cm-t35: remove MACH_CM_T3730
2014-02-17 12:33 ` Igor Grinberg
@ 2014-02-17 12:48 ` Paul Bolle
0 siblings, 0 replies; 3+ messages in thread
From: Paul Bolle @ 2014-02-17 12:48 UTC (permalink / raw)
To: linux-arm-kernel
Hi Igor,
On Mon, 2014-02-17 at 14:33 +0200, Igor Grinberg wrote:
> On 02/16/14 19:26, Paul Bolle wrote:
> > The Kconfig symbol MACH_CM_T3730 was added in v3.1. It has never been
> > used. Setting it has no effect. There are no calls for
> > machine_is_cm_t3730(). This symbol can safely be removed.
>
> Indeed...
Please note that I now doubt my reasoning was correct here. I'm going to
revisit my recent batch of patches regarding, in short, arm Kconfig
symbols used in mach-types.h. (lkml.org is sort of down, so I can't
provide a link.)
> Is it such a burden to keep it just until we switch OMAP3 to DT?
> Because, it makes a bit harder to hack on the kernel.
> Well, not too much as it can be reverted, but still one needs
> to remember to do this...
No, not really. The worst that could happen, from your perspective, is
that if it turns out this was the right thing to do, I might send a
reminder in a few months.
> I'd like to keep it just until we remove the board files, please.
Thanks,
Paul Bolle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-17 12:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-16 17:26 [PATCH] arm: omap3: cm-t35: remove MACH_CM_T3730 Paul Bolle
2014-02-17 12:33 ` Igor Grinberg
2014-02-17 12:48 ` Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).