From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Tue, 18 Feb 2014 06:06:13 -0800 Subject: [PATCH v4 5/5] ACPI: Replace printk with pr_* in tables.c In-Reply-To: <1392731700-10992-6-git-send-email-hanjun.guo@linaro.org> References: <1392731700-10992-1-git-send-email-hanjun.guo@linaro.org> <1392731700-10992-6-git-send-email-hanjun.guo@linaro.org> Message-ID: <1392732373.22752.22.camel@joe-AO722> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2014-02-18 at 21:55 +0800, Hanjun Guo wrote: > This patch just do some clean up to replace printk with pr_*, > no functional change. trivial note: > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c [] > @@ -55,8 +55,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) > { > struct acpi_madt_local_apic *p = > (struct acpi_madt_local_apic *)header; > - printk(KERN_INFO PREFIX > - "LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n", > + pr_info(PREFIX "LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n", > p->processor_id, p->id, > (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); It'd be nice to realign the additional lines to the open parenthesis, here and everywhere else in this patch pr_info(PREFIX "LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n", p->processor_id, p->id, (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");