linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6sl-evk: Keep VGEN1 regulator always enabled
@ 2014-02-18 19:40 Fabio Estevam
  2014-02-19  1:19 ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2014-02-18 19:40 UTC (permalink / raw)
  To: linux-arm-kernel

On imx6sl-evk board the VGEN1 regulator powers up the NVCC_1.2V domain of the
imx6sl SoC, so we need to keep it always powered.

This problem has been observed by the fact that a GPIO connected to an LED could
not work when the PMIC driver was enabled.

Keeping VGEN1 regulator always enabled fixes the problem.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/boot/dts/imx6sl-evk.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/imx6sl-evk.dts b/arch/arm/boot/dts/imx6sl-evk.dts
index 889422c..2ae933b 100644
--- a/arch/arm/boot/dts/imx6sl-evk.dts
+++ b/arch/arm/boot/dts/imx6sl-evk.dts
@@ -195,6 +195,8 @@
 			vgen1_reg: vgen1 {
 				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <1550000>;
+				regulator-boot-on;
+				regulator-always-on;
 			};
 
 			vgen2_reg: vgen2 {
-- 
1.8.1.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: dts: imx6sl-evk: Keep VGEN1 regulator always enabled
  2014-02-18 19:40 [PATCH] ARM: dts: imx6sl-evk: Keep VGEN1 regulator always enabled Fabio Estevam
@ 2014-02-19  1:19 ` Shawn Guo
  2014-02-19  6:03   ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2014-02-19  1:19 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Feb 18, 2014 at 04:40:04PM -0300, Fabio Estevam wrote:
> On imx6sl-evk board the VGEN1 regulator powers up the NVCC_1.2V domain of the
> imx6sl SoC, so we need to keep it always powered.
> 
> This problem has been observed by the fact that a GPIO connected to an LED could
> not work when the PMIC driver was enabled.
> 
> Keeping VGEN1 regulator always enabled fixes the problem.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: dts: imx6sl-evk: Keep VGEN1 regulator always enabled
  2014-02-19  1:19 ` Shawn Guo
@ 2014-02-19  6:03   ` Shawn Guo
  0 siblings, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2014-02-19  6:03 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Feb 19, 2014 at 09:19:59AM +0800, Shawn Guo wrote:
> On Tue, Feb 18, 2014 at 04:40:04PM -0300, Fabio Estevam wrote:
> > On imx6sl-evk board the VGEN1 regulator powers up the NVCC_1.2V domain of the
> > imx6sl SoC, so we need to keep it always powered.
> > 
> > This problem has been observed by the fact that a GPIO connected to an LED could
> > not work when the PMIC driver was enabled.
> > 
> > Keeping VGEN1 regulator always enabled fixes the problem.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Applied, thanks.

Since Mark is questioning this is a correct fix, I'm dropping it for
now.

Shawn

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-02-19  6:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-18 19:40 [PATCH] ARM: dts: imx6sl-evk: Keep VGEN1 regulator always enabled Fabio Estevam
2014-02-19  1:19 ` Shawn Guo
2014-02-19  6:03   ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).