From: iivanov@mm-sol.com (Ivan T. Ivanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: qcom: Add missing clock at index GCC_XO_CLK for MSM8974
Date: Thu, 20 Feb 2014 09:44:03 +0200 [thread overview]
Message-ID: <1392882243.17130.75.camel@iivanov-dev> (raw)
In-Reply-To: <20140219201703.GG14769@codeaurora.org>
On Wed, 2014-02-19 at 12:17 -0800, Stephen Boyd wrote:
> On 02/19, Ivan T. Ivanov wrote:
> > From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> >
> > Accessing GCC on MSM8974 trough <&gcc GCC_XO_CLK> lead to NULL
>
> s/trough/through/
>
> > pointer dereference. Fix this.
> >
>
> I think you want to get the XO clock from the not yet upstreamed
> RPM clock driver. This #define is for a gate that is internal to
> the SoC sitting between the pin for XO and all downstream users
> of the XO clock within the SoC. Futhermore, linux is not allowed
> to control this gate because it's essential to the entire system.
>
> This patch will work for now but we'll need to change the DTS in
> the future to get the clock from the RPM node and then revert
> this patch.
>
> It may be better to just move the XO and sleep_clk_src clocks to
> DT and make them fixed-rate clocks that get added by
> of_clk_init(). Then when the RPM node is added we can remove the
> XO node and update the usb node at the same time.
I see. I'll leave you to decide what is the right solution here,
Regards,
Ivan
prev parent reply other threads:[~2014-02-20 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 14:18 [PATCH] clk: qcom: Add missing clock at index GCC_XO_CLK for MSM8974 Ivan T. Ivanov
2014-02-19 20:17 ` Stephen Boyd
2014-02-20 7:44 ` Ivan T. Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392882243.17130.75.camel@iivanov-dev \
--to=iivanov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).