From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn
Date: Wed, 5 Mar 2014 01:03:10 +0100 [thread overview]
Message-ID: <1393977790-29110-4-git-send-email-sebastian.hesselbarth@gmail.com> (raw)
In-Reply-To: <1393977790-29110-1-git-send-email-sebastian.hesselbarth@gmail.com>
Pinctrl will WARN on missing DT resources, which is a little bit too
noisy. Use dev_warn with FW_BUG instead.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
---
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: devicetree at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
---
drivers/pinctrl/mvebu/pinctrl-dove.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mvebu/pinctrl-dove.c b/drivers/pinctrl/mvebu/pinctrl-dove.c
index 9e7ff651c018..3b022178a566 100644
--- a/drivers/pinctrl/mvebu/pinctrl-dove.c
+++ b/drivers/pinctrl/mvebu/pinctrl-dove.c
@@ -832,7 +832,8 @@ static int dove_pinctrl_probe(struct platform_device *pdev)
}
/* Warn on any missing DT resource */
- WARN(fb_res.start, FW_BUG "Missing pinctrl regs in DTB. Please update your firmware.\n");
+ if (fb_res.start)
+ dev_warn(&pdev->dev, FW_BUG "Missing pinctrl regs in DTB. Please update your firmware.\n");
return mvebu_pinctrl_probe(pdev);
}
--
1.8.5.3
next prev parent reply other threads:[~2014-03-05 0:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 0:03 [PATCH 0/3] pinctrl: mvebu: prepare for single PMU node Sebastian Hesselbarth
2014-03-05 0:03 ` [PATCH 1/3] ARM: dove: drop pinctrl PMU reg property Sebastian Hesselbarth
2014-03-06 20:15 ` Jason Cooper
2014-03-05 0:03 ` [PATCH 2/3] devicetree: bindings: " Sebastian Hesselbarth
2014-03-06 20:17 ` Jason Cooper
2014-03-05 0:03 ` Sebastian Hesselbarth [this message]
2014-03-06 20:18 ` [PATCH 3/3] pinctrl: mvebu: silence WARN to dev_warn Jason Cooper
2014-03-07 3:48 ` Linus Walleij
2014-03-07 3:50 ` Jason Cooper
2014-03-07 3:56 ` Linus Walleij
2014-03-07 13:46 ` Jason Cooper
2014-03-12 14:02 ` Linus Walleij
2014-03-12 15:46 ` Jason Cooper
2014-03-05 9:12 ` [PATCH 0/3] pinctrl: mvebu: prepare for single PMU node Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393977790-29110-4-git-send-email-sebastian.hesselbarth@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).