From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: i.MX: mx21ads: Replace direct handling of peripheral bits with GPIOs
Date: Wed, 05 Mar 2014 10:53:27 +0400 [thread overview]
Message-ID: <1394002407.236079875@f309.i.mail.ru> (raw)
In-Reply-To: <20140305055634.GG8784@S2101-09.ap.freescale.net>
?????, 5 ????? 2014, 13:56 +08:00 ?? Shawn Guo <shawn.guo@linaro.org>:
> On Mon, Mar 03, 2014 at 10:37:44PM +0400, Alexander Shiyan wrote:
> > This patch replaces direct handling of peripheral bits with GPIOs by
> > using basic-mmio-gpio driver. As a result this change eliminate some
> > low-level code and removes custom io_map() from the board.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> > arch/arm/mach-imx/mach-mx21ads.c | 136 +++++++++++++++++++--------------------
> > 1 file changed, 66 insertions(+), 70 deletions(-)
>
> I'm generally not fond of taking patches that touch the legacy board
> file unless they're fixing or cleaning up something. Since it looks
> like a cleanup, I will probably take it. But did you test the change on
> hardware?
No. Unfortunately I do not have this board. Similar change I did for the
other subarch, and it has been tested
(https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/arch/arm/mach-clps711x/board-p720t.c?id=6d640edeb598dd76c64aa99357d9b59996dcb3bc).
Yes, it is mostly cleanup. The next change to this board will introduce GPIO
regulator (based on this change) for the framebuffer, it will help to remove
".init" and ".exit" hooks for the imxfb driver.
---
next prev parent reply other threads:[~2014-03-05 6:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 18:37 [PATCH] ARM: i.MX: mx21ads: Replace direct handling of peripheral bits with GPIOs Alexander Shiyan
2014-03-05 5:56 ` Shawn Guo
2014-03-05 6:53 ` Alexander Shiyan [this message]
2014-03-05 7:01 ` Shawn Guo
2014-03-05 11:48 ` Sascha Hauer
2014-03-05 12:03 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394002407.236079875@f309.i.mail.ru \
--to=shc_work@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox