linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] Doc/DT: Add DT binding documentation for DVI Connector
Date: Fri, 07 Mar 2014 15:17:39 +0100	[thread overview]
Message-ID: <1394201859.16309.14.camel@paszta.hi.pengutronix.de> (raw)
In-Reply-To: <53183730.5060205@ti.com>

Hi,

Am Donnerstag, den 06.03.2014, 10:52 +0200 schrieb Tomi Valkeinen:
> On 06/03/14 10:39, Geert Uytterhoeven wrote:
> > On Wed, Mar 5, 2014 at 9:41 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> >> On 28/02/14 18:23, Russell King - ARM Linux wrote:
> >>
> >>> That's rather a lot of compatible strings.  Another possibility is:
> >>>
> >>>       compatible = "dvi-connector";
> >>>       analog;
> >>>       digital;
> >>>       single-link;
> >>>       dual-link;
> >>
> >> I made the following changes compared to the posted version. I decided
> >> to leave the "single-link" out, as it's implied if "digital" is set.
> >>
> >>  Tomi
> >>
> >> @@ -6,11 +6,16 @@ Required properties:
> >>
> >>  Optional properties:
> >>  - label: a symbolic name for the connector
> >> -- i2c-bus: phandle to the i2c bus that is connected to DVI DDC
> >> +- ddc-i2c-bus: phandle to the i2c bus that is connected to DVI DDC
> >> +- analog: the connector has DVI analog pins
> >> +- digital: the connector has DVI digital pins
> >> +- dual-link: the connector has pins for DVI dual-link
> >>
> >>  Required nodes:
> >>  - Video port for DVI input
> >>
> >> +Note: One (or both) of 'analog' or 'digital' must be set.
> > 
> > So dual-link needs both "digital" and "dual-link"?
> 
> Yes. It is extra, but it felt clearer to me to have 'digital' as a
> matching property for 'analog'.
> 
> Alternatively we could have three options:
> 
> analog;
> digital-single-link;
> digital-dual-link;
> 
> My reasoning to the format I chose was basically that when a connector
> supports 'digital', it contains TMDS clock and TMDS data for link 1.
> Adding dual link to that adds only TMDS data for link 2, so the second
> data link is kind of an additional feature, marked with a flag.
> 
> Not a very big argument, and I'm fine with other format suggestions.

I'd prefer the analog / digital / dual-link variant for aesthetic
reasons. But looking at other connector types, I wonder if this should
be generalized even more:

For HDMI/DVI (digital) single-link means one clock pair and 3 TMDS data
pairs, dual-link means one clock pair and 6 data pairs.

On LVDS connectors, there usually are one clock pair and three (18-bit)
or four (24-bit) LVDS data pairs, in dual channel configuration two
clock pairs and 6 or 8 data pairs are used.

For DisplayPort there is no separate clock pair, but 1 to 4 data pairs,
and MIPI DSI again has one clock pair and a one or more data pairs.

There are already optional endpoint configuration properties
'data-lanes' and 'clock-lanes' for MIPI CSI-2 defined in
Documentation/devicetree/bindings/media/video-interfaces.txt.
Could/should this be aligned with the same?

regards
Philipp

  reply	other threads:[~2014-03-07 14:17 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 12:20 [PATCH 0/9] Doc/DT: DT bindings for various display components Tomi Valkeinen
2014-02-28 12:20 ` [PATCH 1/9] Doc/DT: Add OMAP DSS DT Bindings Tomi Valkeinen
2014-02-28 12:20 ` [PATCH 2/9] Doc/DT: Add DT binding documentation for Analog TV Connector Tomi Valkeinen
2014-02-28 12:20 ` [PATCH 3/9] Doc/DT: Add DT binding documentation for DVI Connector Tomi Valkeinen
2014-02-28 13:43   ` Philipp Zabel
2014-03-03  6:25     ` Tomi Valkeinen
2014-02-28 15:59   ` Russell King - ARM Linux
2014-02-28 16:12     ` Tomi Valkeinen
2014-02-28 16:23       ` Russell King - ARM Linux
2014-02-28 16:28         ` Warner Losh
2014-03-03  6:42         ` Tomi Valkeinen
2014-03-04 12:54         ` Daniel Vetter
2014-03-05  8:41         ` Tomi Valkeinen
2014-03-06  8:39           ` Geert Uytterhoeven
2014-03-06  8:52             ` Tomi Valkeinen
2014-03-07 14:17               ` Philipp Zabel [this message]
2014-03-10 10:32                 ` Tomi Valkeinen
2014-02-28 16:25       ` Sebastian Reichel
2014-02-28 16:25     ` Philipp Zabel
2014-03-10 21:45       ` Rob Herring
2014-03-11  6:39         ` Tomi Valkeinen
2014-03-11  8:00           ` Geert Uytterhoeven
2014-03-11  8:04             ` Tomi Valkeinen
2014-03-11 11:19               ` Philipp Zabel
2014-03-11  6:43       ` Tomi Valkeinen
2014-02-28 12:20 ` [PATCH 4/9] Doc/DT: Add DT binding documentation for HDMI Connector Tomi Valkeinen
2014-02-28 16:06   ` Russell King - ARM Linux
2014-02-28 16:15     ` Tomi Valkeinen
2014-02-28 16:34       ` Russell King - ARM Linux
2014-03-01 18:58         ` Geert Uytterhoeven
2014-03-03  7:23           ` Tomi Valkeinen
2014-03-05  8:42           ` Tomi Valkeinen
2014-03-04 12:59     ` Daniel Vetter
2014-02-28 12:20 ` [PATCH 5/9] Doc/DT: Add DT binding documentation for MIPI DPI Panel Tomi Valkeinen
2014-02-28 13:40   ` Philipp Zabel
2014-03-03  6:05     ` Tomi Valkeinen
2014-03-17 14:19   ` Laurent Pinchart
2014-03-18  6:41     ` Tomi Valkeinen
2014-03-18  7:06       ` Tomi Valkeinen
2014-02-28 12:20 ` [PATCH 6/9] Doc/DT: Add DT binding documentation for MIPI DSI CM Panel Tomi Valkeinen
2014-03-17 14:22   ` Laurent Pinchart
2014-03-18  6:33     ` Tomi Valkeinen
2014-03-18 12:43       ` Laurent Pinchart
2014-02-28 12:20 ` [PATCH 7/9] Doc/DT: Add DT binding documentation for Sony acx565akm panel Tomi Valkeinen
2014-02-28 13:38   ` Philipp Zabel
2014-02-28 13:47     ` Tomi Valkeinen
2014-02-28 12:20 ` [PATCH 8/9] Doc/DT: Add DT binding documentation for TFP410 encoder Tomi Valkeinen
2014-02-28 13:37   ` Philipp Zabel
2014-02-28 12:20 ` [PATCH 9/9] Doc/DT: Add DT binding documentation for tpd12s015 encoder Tomi Valkeinen
2014-02-28 16:13   ` Russell King - ARM Linux
2014-02-28 16:30     ` Tomi Valkeinen
2014-02-28 12:37 ` [PATCH 0/9] Doc/DT: DT bindings for various display components Tomasz Figa
2014-02-28 12:57 ` Sebastian Hesselbarth
2014-02-28 13:14   ` Tomi Valkeinen
2014-02-28 13:51     ` Sebastian Hesselbarth
2014-02-28 15:39       ` Tomi Valkeinen
2014-02-28 16:48       ` Russell King - ARM Linux
2014-02-28 13:47   ` Philipp Zabel
2014-02-28 13:56     ` Sebastian Hesselbarth
2014-02-28 16:27 ` Russell King - ARM Linux
2014-02-28 16:48   ` Tomi Valkeinen
2014-02-28 16:56     ` Russell King - ARM Linux
2014-03-03  8:04       ` Tomi Valkeinen
2014-03-07 12:56         ` Tomi Valkeinen
2014-03-10 16:05         ` Rob Herring
2014-03-10 16:40           ` Tomi Valkeinen
2014-03-10 20:32             ` Rob Herring
2014-03-12  8:15 ` Tomi Valkeinen
2014-03-17 13:55   ` Tomi Valkeinen
2014-03-21 15:37     ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394201859.16309.14.camel@paszta.hi.pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).