From: dave.long@linaro.org (David Long)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 02/15] ARM: Fix missing includes in kprobes sources
Date: Fri, 7 Mar 2014 15:10:27 -0500 [thread overview]
Message-ID: <1394223040-17129-3-git-send-email-dave.long@linaro.org> (raw)
In-Reply-To: <1394223040-17129-1-git-send-email-dave.long@linaro.org>
From: "David A. Long" <dave.long@linaro.org>
Make sure includes in ARM kprobes sources are done explicitly. Do not
rely on includes from other includes.
Signed-off-by: David A. Long <dave.long@linaro.org>
Acked-by: Jon Medhurst <tixy@linaro.org>
---
arch/arm/include/asm/kprobes.h | 2 +-
arch/arm/kernel/kprobes-common.c | 3 +++
arch/arm/kernel/kprobes-test-arm.c | 1 +
arch/arm/kernel/kprobes-test.c | 4 +++-
arch/arm/kernel/kprobes.c | 2 ++
5 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/arch/arm/include/asm/kprobes.h b/arch/arm/include/asm/kprobes.h
index f82ec22..fd2e5ca 100644
--- a/arch/arm/include/asm/kprobes.h
+++ b/arch/arm/include/asm/kprobes.h
@@ -18,7 +18,7 @@
#include <linux/types.h>
#include <linux/ptrace.h>
-#include <linux/percpu.h>
+#include <linux/notifier.h>
#define __ARCH_WANT_KPROBES_INSN_SLOT
#define MAX_INSN_SIZE 2
diff --git a/arch/arm/kernel/kprobes-common.c b/arch/arm/kernel/kprobes-common.c
index 18a7628..455c800 100644
--- a/arch/arm/kernel/kprobes-common.c
+++ b/arch/arm/kernel/kprobes-common.c
@@ -14,6 +14,9 @@
#include <linux/kernel.h>
#include <linux/kprobes.h>
#include <asm/system_info.h>
+#include <linux/types.h>
+#include <linux/stddef.h>
+#include <linux/bug.h>
#include "kprobes.h"
diff --git a/arch/arm/kernel/kprobes-test-arm.c b/arch/arm/kernel/kprobes-test-arm.c
index 8393129..87839de 100644
--- a/arch/arm/kernel/kprobes-test-arm.c
+++ b/arch/arm/kernel/kprobes-test-arm.c
@@ -10,6 +10,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
+#include <asm/system_info.h>
#include "kprobes-test.h"
diff --git a/arch/arm/kernel/kprobes-test.c b/arch/arm/kernel/kprobes-test.c
index 0cd63d0..4a774d4 100644
--- a/arch/arm/kernel/kprobes-test.c
+++ b/arch/arm/kernel/kprobes-test.c
@@ -201,7 +201,9 @@
#include <linux/module.h>
#include <linux/slab.h>
#include <linux/kprobes.h>
-
+#include <linux/errno.h>
+#include <linux/stddef.h>
+#include <linux/bug.h>
#include <asm/opcodes.h>
#include "kprobes.h"
diff --git a/arch/arm/kernel/kprobes.c b/arch/arm/kernel/kprobes.c
index a7b621e..54e7b46 100644
--- a/arch/arm/kernel/kprobes.c
+++ b/arch/arm/kernel/kprobes.c
@@ -27,6 +27,8 @@
#include <linux/stringify.h>
#include <asm/traps.h>
#include <asm/cacheflush.h>
+#include <linux/percpu.h>
+#include <linux/bug.h>
#include "kprobes.h"
#include "patch.h"
--
1.8.1.2
next prev parent reply other threads:[~2014-03-07 20:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 20:10 [PATCH v7 00/15] uprobes: Add uprobes support for ARM David Long
2014-03-07 20:10 ` [PATCH v7 01/15] uprobes: Kconfig dependency fix David Long
2014-03-08 11:17 ` Russell King - ARM Linux
2014-03-08 15:29 ` Oleg Nesterov
2014-03-07 20:10 ` David Long [this message]
2014-03-07 20:10 ` [PATCH v7 03/15] uprobes: allow ignoring of probe hits David Long
2014-03-07 20:10 ` [PATCH v7 04/15] ARM: move shared uprobe/kprobe definitions into new include file David Long
2014-03-07 20:10 ` [PATCH v7 05/15] ARM: Move generic arm instruction parsing code to new files for sharing between features David Long
2014-03-07 20:10 ` [PATCH v7 06/15] ARM: move generic thumb instruction parsing code to new files for use by other feature David Long
2014-03-07 20:10 ` [PATCH v7 07/15] ARM: use a function table for determining instruction interpreter action David Long
2014-03-07 20:10 ` [PATCH v7 08/15] ARM: Remove use of struct kprobe from generic probes code David Long
2014-03-07 20:10 ` [PATCH v7 09/15] ARM: Make the kprobes condition_check symbol names more generic David Long
2014-03-07 20:10 ` [PATCH v7 10/15] ARM: Change more ARM kprobes symbol names to something " David Long
2014-03-07 20:10 ` [PATCH v7 11/15] ARM: Rename the shared kprobes/uprobe return value enum David Long
2014-03-07 20:10 ` [PATCH v7 12/15] ARM: Change the remaining shared kprobes/uprobes symbols to something generic David Long
2014-03-07 20:10 ` [PATCH v7 13/15] ARM: Add an emulate flag to the kprobes/uprobes instruction decode functions David Long
2014-03-07 20:10 ` [PATCH v7 14/15] ARM: Make arch_specific_insn a define for new arch_probes_insn structure David Long
2014-03-07 20:10 ` [PATCH v7 15/15] ARM: add uprobes support David Long
2014-03-08 11:18 ` [PATCH v7 00/15] uprobes: Add uprobes support for ARM Russell King - ARM Linux
2014-03-11 18:36 ` [GIT PULL] " David Long
2014-03-17 23:52 ` Russell King - ARM Linux
2014-03-18 22:15 ` David Long
2014-03-19 20:16 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394223040-17129-3-git-send-email-dave.long@linaro.org \
--to=dave.long@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).