linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dave.long@linaro.org (David Long)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 03/15] uprobes: allow ignoring of probe hits
Date: Fri,  7 Mar 2014 15:10:28 -0500	[thread overview]
Message-ID: <1394223040-17129-4-git-send-email-dave.long@linaro.org> (raw)
In-Reply-To: <1394223040-17129-1-git-send-email-dave.long@linaro.org>

From: "David A. Long" <dave.long@linaro.org>

Allow arches to decided to ignore a probe hit.  ARM will use this to
only call handlers if the conditions to execute a conditionally executed
instruction are satisfied.

Signed-off-by: David A. Long <dave.long@linaro.org>
Acked-by: Oleg Nesterov <oleg@redhat.com>
---
 include/linux/uprobes.h | 1 +
 kernel/events/uprobes.c | 9 +++++++++
 2 files changed, 10 insertions(+)

diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
index e32251e..edff2b9 100644
--- a/include/linux/uprobes.h
+++ b/include/linux/uprobes.h
@@ -126,6 +126,7 @@ extern bool arch_uprobe_xol_was_trapped(struct task_struct *tsk);
 extern int  arch_uprobe_exception_notify(struct notifier_block *self, unsigned long val, void *data);
 extern void arch_uprobe_abort_xol(struct arch_uprobe *aup, struct pt_regs *regs);
 extern unsigned long arch_uretprobe_hijack_return_addr(unsigned long trampoline_vaddr, struct pt_regs *regs);
+extern bool __weak arch_uprobe_ignore(struct arch_uprobe *aup, struct pt_regs *regs);
 #else /* !CONFIG_UPROBES */
 struct uprobes_state {
 };
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 307d87c..04709b6 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -1804,6 +1804,11 @@ static bool handle_trampoline(struct pt_regs *regs)
 	return true;
 }
 
+bool __weak arch_uprobe_ignore(struct arch_uprobe *aup, struct pt_regs *regs)
+{
+	return false;
+}
+
 /*
  * Run handler and ask thread to singlestep.
  * Ensure all non-fatal signals cannot interrupt thread while it singlesteps.
@@ -1858,7 +1863,11 @@ static void handle_swbp(struct pt_regs *regs)
 	if (!get_utask())
 		goto out;
 
+	if (arch_uprobe_ignore(&uprobe->arch, regs))
+		goto out;
+
 	handler_chain(uprobe, regs);
+
 	if (can_skip_sstep(uprobe, regs))
 		goto out;
 
-- 
1.8.1.2

  parent reply	other threads:[~2014-03-07 20:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07 20:10 [PATCH v7 00/15] uprobes: Add uprobes support for ARM David Long
2014-03-07 20:10 ` [PATCH v7 01/15] uprobes: Kconfig dependency fix David Long
2014-03-08 11:17   ` Russell King - ARM Linux
2014-03-08 15:29   ` Oleg Nesterov
2014-03-07 20:10 ` [PATCH v7 02/15] ARM: Fix missing includes in kprobes sources David Long
2014-03-07 20:10 ` David Long [this message]
2014-03-07 20:10 ` [PATCH v7 04/15] ARM: move shared uprobe/kprobe definitions into new include file David Long
2014-03-07 20:10 ` [PATCH v7 05/15] ARM: Move generic arm instruction parsing code to new files for sharing between features David Long
2014-03-07 20:10 ` [PATCH v7 06/15] ARM: move generic thumb instruction parsing code to new files for use by other feature David Long
2014-03-07 20:10 ` [PATCH v7 07/15] ARM: use a function table for determining instruction interpreter action David Long
2014-03-07 20:10 ` [PATCH v7 08/15] ARM: Remove use of struct kprobe from generic probes code David Long
2014-03-07 20:10 ` [PATCH v7 09/15] ARM: Make the kprobes condition_check symbol names more generic David Long
2014-03-07 20:10 ` [PATCH v7 10/15] ARM: Change more ARM kprobes symbol names to something " David Long
2014-03-07 20:10 ` [PATCH v7 11/15] ARM: Rename the shared kprobes/uprobe return value enum David Long
2014-03-07 20:10 ` [PATCH v7 12/15] ARM: Change the remaining shared kprobes/uprobes symbols to something generic David Long
2014-03-07 20:10 ` [PATCH v7 13/15] ARM: Add an emulate flag to the kprobes/uprobes instruction decode functions David Long
2014-03-07 20:10 ` [PATCH v7 14/15] ARM: Make arch_specific_insn a define for new arch_probes_insn structure David Long
2014-03-07 20:10 ` [PATCH v7 15/15] ARM: add uprobes support David Long
2014-03-08 11:18 ` [PATCH v7 00/15] uprobes: Add uprobes support for ARM Russell King - ARM Linux
2014-03-11 18:36 ` [GIT PULL] " David Long
2014-03-17 23:52   ` Russell King - ARM Linux
2014-03-18 22:15     ` David Long
2014-03-19 20:16       ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394223040-17129-4-git-send-email-dave.long@linaro.org \
    --to=dave.long@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).