From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: always enable GPIO_OMAP on ARCH_OMAP
Date: Tue, 29 Apr 2014 12:26:17 +0200 [thread overview]
Message-ID: <13943940.Yb2C7lPSBy@wuerfel> (raw)
In-Reply-To: <535EEB58.60809@collabora.co.uk>
On Tuesday 29 April 2014 01:59:20 Javier Martinez Canillas wrote:
> This driver is also used by OMAP1. Even when disabling GPIO_OMAP on that
> platform doesn't cause a build error since no function defined in the driver is
> used directly by platform code, I think that we always want this driver on OMAP1
> too.
>
> > However, it seems entirely reasonable to include the driver in build tests
> > on other platforms, so we should also allow building it for COMPILE_TEST
> > builds and select the required GENERIC_IRQ_CHIP that may not already be
> > enabled on other platforms.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> > index c58b828..c8c42be 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -244,9 +244,10 @@ config GPIO_OCTEON
> > family of SOCs.
> >
> > config GPIO_OMAP
> > - bool "TI OMAP GPIO support"
> > + bool "TI OMAP GPIO support" if COMPILE_TEST && !ARCH_OMAP2PLUS
>
> So this should be:
>
> + bool "TI OMAP GPIO support" if COMPILE_TEST && !ARCH_OMAP2PLUS &&
> !ARCH_OMAP1
>
Well, if COMPILE_TEST is disabled on OMAP1, the option is already
hidden and enabled in my version. It seems reasonable to me to
allow compile-testing OMAP1 without the GPIO driver, while a kernel
running on OMAP1 should always have COMPILE_TEST disabled.
Arnd
next prev parent reply other threads:[~2014-04-29 10:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 9:07 [PATCH] gpio: always enable GPIO_OMAP on ARCH_OMAP Arnd Bergmann
2014-04-28 23:59 ` Javier Martinez Canillas
2014-04-29 10:26 ` Arnd Bergmann [this message]
2014-04-29 10:53 ` Javier Martinez Canillas
2014-04-29 12:07 ` Arnd Bergmann
2014-05-09 7:48 ` Linus Walleij
2014-05-09 8:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13943940.Yb2C7lPSBy@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox