* [PATCH] clk: hisilicon: fix warning from smatch
@ 2014-03-10 3:33 Zhangfei Gao
2014-03-21 3:12 ` Mike Turquette
0 siblings, 1 reply; 2+ messages in thread
From: Zhangfei Gao @ 2014-03-10 3:33 UTC (permalink / raw)
To: linux-arm-kernel
drivers/clk/hisilicon/clk-hi3620.c:338
mmc_clk_delay() warn: always true condition '(para >= 0) => (0-u32max >= 0)'
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
drivers/clk/hisilicon/clk-hi3620.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/clk/hisilicon/clk-hi3620.c b/drivers/clk/hisilicon/clk-hi3620.c
index 38faa469d288..e75f742ca422 100644
--- a/drivers/clk/hisilicon/clk-hi3620.c
+++ b/drivers/clk/hisilicon/clk-hi3620.c
@@ -335,15 +335,14 @@ static u32 mmc_clk_delay(u32 val, u32 para, u32 off, u32 len)
{
u32 i;
- if (para >= 0) {
- for (i = 0; i < len; i++) {
- if (para % 2)
- val |= 1 << (off + i);
- else
- val &= ~(1 << (off + i));
- para = para >> 1;
- }
+ for (i = 0; i < len; i++) {
+ if (para % 2)
+ val |= 1 << (off + i);
+ else
+ val &= ~(1 << (off + i));
+ para = para >> 1;
}
+
return val;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] clk: hisilicon: fix warning from smatch
2014-03-10 3:33 [PATCH] clk: hisilicon: fix warning from smatch Zhangfei Gao
@ 2014-03-21 3:12 ` Mike Turquette
0 siblings, 0 replies; 2+ messages in thread
From: Mike Turquette @ 2014-03-21 3:12 UTC (permalink / raw)
To: linux-arm-kernel
Quoting Zhangfei Gao (2014-03-09 20:33:20)
> drivers/clk/hisilicon/clk-hi3620.c:338
> mmc_clk_delay() warn: always true condition '(para >= 0) => (0-u32max >= 0)'
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Taken into clk-next.
Regards,
Mike
> ---
> drivers/clk/hisilicon/clk-hi3620.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/clk/hisilicon/clk-hi3620.c b/drivers/clk/hisilicon/clk-hi3620.c
> index 38faa469d288..e75f742ca422 100644
> --- a/drivers/clk/hisilicon/clk-hi3620.c
> +++ b/drivers/clk/hisilicon/clk-hi3620.c
> @@ -335,15 +335,14 @@ static u32 mmc_clk_delay(u32 val, u32 para, u32 off, u32 len)
> {
> u32 i;
>
> - if (para >= 0) {
> - for (i = 0; i < len; i++) {
> - if (para % 2)
> - val |= 1 << (off + i);
> - else
> - val &= ~(1 << (off + i));
> - para = para >> 1;
> - }
> + for (i = 0; i < len; i++) {
> + if (para % 2)
> + val |= 1 << (off + i);
> + else
> + val &= ~(1 << (off + i));
> + para = para >> 1;
> }
> +
> return val;
> }
>
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-21 3:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-10 3:33 [PATCH] clk: hisilicon: fix warning from smatch Zhangfei Gao
2014-03-21 3:12 ` Mike Turquette
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).