From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] mfd: sec-core: Add of_compatible strings for MFD cells
Date: Mon, 10 Mar 2014 13:53:19 +0100 [thread overview]
Message-ID: <1394455999.16208.3.camel@AMDC1943> (raw)
In-Reply-To: <20140310124623.GA18561@lee--X1>
On Mon, 2014-03-10 at 12:46 +0000, Lee Jones wrote:
> > Add of_compatible strings for S5M8767 RTC, S5M8767 clock and S2MPS14
> > clock MFD cells.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> > drivers/mfd/sec-core.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> > index d163c66edebb..e8ac2e3c1f58 100644
> > --- a/drivers/mfd/sec-core.c
> > +++ b/drivers/mfd/sec-core.c
> > @@ -57,8 +57,10 @@ static const struct mfd_cell s5m8767_devs[] = {
> > .name = "s5m8767-pmic",
> > }, {
> > .name = "s5m-rtc",
> > + .of_compatible = "samsung,s5m8767-rtc",
> > }, {
> > .name = "s5m8767-clk",
> > + .of_compatible = "samsung,s5m8767-clk",
> > }
> > };
> >
> > @@ -77,6 +79,7 @@ static const struct mfd_cell s2mps14_devs[] = {
> > .name = "s2mps14-rtc",
> > }, {
> > .name = "s2mps14-clk",
> > + .of_compatible = "samsung,s2mps14-clk",
> > }
> > };
>
> Any reason for not applying compatible strings for the other devices?
Partially yes because I do not want to add them for devices which I
cannot test (s5m8761, s5m8763) but you're right that there are no
obstacles for s2mps11, s5m8767 and s2mps14.
I'll fix this in next version.
next prev parent reply other threads:[~2014-03-10 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 12:34 [PATCH 0/3] clk: s2mps11: Add support for S2MPS14 clocks Krzysztof Kozlowski
2014-03-10 12:34 ` [PATCH 1/3] " Krzysztof Kozlowski
2014-03-12 11:30 ` Yadwinder Singh Brar
2014-03-12 11:35 ` Krzysztof Kozlowski
2014-03-10 12:34 ` [PATCH 2/3] mfd: sec-core: Add of_compatible strings for MFD cells Krzysztof Kozlowski
2014-03-10 12:46 ` Lee Jones
2014-03-10 12:53 ` Krzysztof Kozlowski [this message]
2014-03-10 12:34 ` [PATCH 3/3] Documentation: mfd: s2mps11: Describe S5M8767 and S2MPS14 clocks Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394455999.16208.3.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).