* [PATCH] irqchip: sun4i: Fix acomment about mask register initialization
@ 2014-03-11 15:54 Hans de Goede
2014-03-12 10:10 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2014-03-11 15:54 UTC (permalink / raw)
To: linux-arm-kernel
The comment was claiming that we were masking all irqs, while the code actually
*un*masks all of them.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/irqchip/irq-sun4i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-sun4i.c b/drivers/irqchip/irq-sun4i.c
index 3761bf1..749a355 100644
--- a/drivers/irqchip/irq-sun4i.c
+++ b/drivers/irqchip/irq-sun4i.c
@@ -109,7 +109,7 @@ static int __init sun4i_of_init(struct device_node *node,
writel(0, sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(1));
writel(0, sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(2));
- /* Mask all the interrupts */
+ /* Unmask all the interrupts, ENABLE_REG(x) is used for masking */
writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(0));
writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(1));
writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(2));
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] irqchip: sun4i: Fix acomment about mask register initialization
2014-03-11 15:54 [PATCH] irqchip: sun4i: Fix acomment about mask register initialization Hans de Goede
@ 2014-03-12 10:10 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2014-03-12 10:10 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 11, 2014 at 04:54:33PM +0100, Hans de Goede wrote:
> The comment was claiming that we were masking all irqs, while the code actually
> *un*masks all of them.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140312/d2a72d11/attachment-0001.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-12 10:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-11 15:54 [PATCH] irqchip: sun4i: Fix acomment about mask register initialization Hans de Goede
2014-03-12 10:10 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).