linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: denis@eukrea.com (Denis Carikli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10][ 04/10] imx-drm: Match ipu_di_signal_cfg's clk_pol with its description.
Date: Wed, 12 Mar 2014 17:31:01 +0100	[thread overview]
Message-ID: <1394641867-15629-4-git-send-email-denis@eukrea.com> (raw)
In-Reply-To: <1394641867-15629-1-git-send-email-denis@eukrea.com>

According to the datasheet, setting the di0_polarity_disp_clk
field in the GENERAL di register sets the output clock polarity
to active high.

Signed-off-by: Denis Carikli <denis@eukrea.com>
---
ChangeLog v9->v10:
- New patch that is now needed by the
  "staging: imx-drm: Use de-active and pixelclk-active" patch.
---
 drivers/staging/imx-drm/ipu-v3/ipu-di.c |    2 +-
 drivers/staging/imx-drm/ipuv3-crtc.c    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-di.c b/drivers/staging/imx-drm/ipu-v3/ipu-di.c
index 82a9eba..849b3e1 100644
--- a/drivers/staging/imx-drm/ipu-v3/ipu-di.c
+++ b/drivers/staging/imx-drm/ipu-v3/ipu-di.c
@@ -595,7 +595,7 @@ int ipu_di_init_sync_panel(struct ipu_di *di, struct ipu_di_signal_cfg *sig)
 		}
 	}
 
-	if (!sig->clk_pol)
+	if (sig->clk_pol)
 		di_gen |= DI_GEN_POLARITY_DISP_CLK;
 
 	ipu_di_write(di, di_gen, DI_GENERAL);
diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c
index a8d0178..db6bd64 100644
--- a/drivers/staging/imx-drm/ipuv3-crtc.c
+++ b/drivers/staging/imx-drm/ipuv3-crtc.c
@@ -158,7 +158,7 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
 		sig_cfg.Vsync_pol = 1;
 
 	sig_cfg.enable_pol = 1;
-	sig_cfg.clk_pol = 1;
+	sig_cfg.clk_pol = 0;
 	sig_cfg.width = mode->hdisplay;
 	sig_cfg.height = mode->vdisplay;
 	sig_cfg.pixel_fmt = out_pixel_fmt;
-- 
1.7.9.5

  parent reply	other threads:[~2014-03-12 16:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-12 16:30 [PATCH v10][ 01/10] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format Denis Carikli
2014-03-12 16:30 ` [PATCH v10][ 02/10] imx-drm: Add RGB666 support for parallel display Denis Carikli
2014-03-12 16:31 ` [PATCH v10][ 03/10] imx-drm: Correct BGR666 and the board's dts that use them Denis Carikli
2014-03-12 16:31 ` Denis Carikli [this message]
2014-03-12 16:31 ` [PATCH v10][ 05/10] imx-drm: use defines for clock polarity settings Denis Carikli
2014-03-12 16:31 ` [PATCH v10][ 06/10] ARM: dts: imx5*, imx6*: correct display-timings nodes Denis Carikli
2014-03-12 16:31 ` [PATCH v10][ 07/10] imx-drm: Prepare imx-drm for extra display-timings retrival Denis Carikli
2014-03-12 16:31 ` [PATCH v10][ 08/10] imx-drm: imx-drm-core: provide a common display timings retrival function Denis Carikli
2014-03-12 16:31 ` [PATCH v10][ 09/10] imx-drm: parallel-display: retrive extra display-timings Denis Carikli
2014-03-12 16:31 ` [PATCH v10][ 10/10] ARM: dts: mbimx51sd: Add display support Denis Carikli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394641867-15629-4-git-send-email-denis@eukrea.com \
    --to=denis@eukrea.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).