linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 25/36] mtd: st_spi_fsm: Add the ability to read from a Serial Flash device
Date: Thu, 20 Mar 2014 09:20:57 +0000	[thread overview]
Message-ID: <1395307268-12721-26-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1395307268-12721-1-git-send-email-lee.jones@linaro.org>

When a read is issued by userspace the MTD framework calls back into
the driver to conduct the actual command issue and data extraction.
Here we provide the routines which do exactly that.

Acked-by Angus Clark <angus.clark@st.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mtd/devices/st_spi_fsm.c | 98 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 98 insertions(+)

diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
index b4afee0..b1a65c1 100644
--- a/drivers/mtd/devices/st_spi_fsm.c
+++ b/drivers/mtd/devices/st_spi_fsm.c
@@ -238,6 +238,9 @@
 #define FLASH_CMD_READ4_1_1_4  0x6c
 #define FLASH_CMD_READ4_1_4_4  0xec
 
+#define FLASH_PAGESIZE         256			/* In Bytes    */
+#define FLASH_PAGESIZE_32      (FLASH_PAGESIZE / 4)	/* In uint32_t */
+
 /*
  * Flags to tweak operation of default read/write/erase routines
  */
@@ -942,6 +945,99 @@ static int stfsm_n25q_config(struct stfsm *fsm)
 	return 0;
 }
 
+static int stfsm_read(struct stfsm *fsm, uint8_t *buf, uint32_t size,
+		      uint32_t offset)
+{
+	struct stfsm_seq *seq = &stfsm_seq_read;
+	uint32_t data_pads;
+	uint32_t read_mask;
+	uint32_t size_ub;
+	uint32_t size_lb;
+	uint32_t size_mop;
+	uint32_t tmp[4];
+	uint32_t page_buf[FLASH_PAGESIZE_32];
+	uint8_t *p;
+
+	dev_dbg(fsm->dev, "reading %d bytes from 0x%08x\n", size, offset);
+
+	/* Enter 32-bit address mode, if required */
+	if (fsm->configuration & CFG_READ_TOGGLE_32BIT_ADDR)
+		stfsm_enter_32bit_addr(fsm, 1);
+
+	/* Must read in multiples of 32 cycles (or 32*pads/8 Bytes) */
+	data_pads = ((seq->seq_cfg >> 16) & 0x3) + 1;
+	read_mask = (data_pads << 2) - 1;
+
+	/* Handle non-aligned buf */
+	p = ((uint32_t)buf & 0x3) ? (uint8_t *)page_buf : buf;
+
+	/* Handle non-aligned size */
+	size_ub = (size + read_mask) & ~read_mask;
+	size_lb = size & ~read_mask;
+	size_mop = size & read_mask;
+
+	seq->data_size = TRANSFER_SIZE(size_ub);
+	seq->addr1 = (offset >> 16) & 0xffff;
+	seq->addr2 = offset & 0xffff;
+
+	stfsm_load_seq(fsm, seq);
+
+	if (size_lb)
+		stfsm_read_fifo(fsm, (uint32_t *)p, size_lb);
+
+	if (size_mop) {
+		stfsm_read_fifo(fsm, tmp, read_mask + 1);
+		memcpy(p + size_lb, &tmp, size_mop);
+	}
+
+	/* Handle non-aligned buf */
+	if ((uint32_t)buf & 0x3)
+		memcpy(buf, page_buf, size);
+
+	/* Wait for sequence to finish */
+	stfsm_wait_seq(fsm);
+
+	stfsm_clear_fifo(fsm);
+
+	/* Exit 32-bit address mode, if required */
+	if (fsm->configuration & CFG_READ_TOGGLE_32BIT_ADDR)
+		stfsm_enter_32bit_addr(fsm, 0);
+
+	return 0;
+}
+
+/*
+ * Read an address range from the flash chip. The address range
+ * may be any size provided it is within the physical boundaries.
+ */
+static int stfsm_mtd_read(struct mtd_info *mtd, loff_t from, size_t len,
+			  size_t *retlen, u_char *buf)
+{
+	struct stfsm *fsm = dev_get_drvdata(mtd->dev.parent);
+	uint32_t bytes;
+
+	dev_dbg(fsm->dev, "%s from 0x%08x, len %zd\n",
+		__func__, (u32)from, len);
+
+	mutex_lock(&fsm->lock);
+
+	while (len > 0) {
+		bytes = min_t(size_t, len, FLASH_PAGESIZE);
+
+		stfsm_read(fsm, buf, bytes, from);
+
+		buf += bytes;
+		from += bytes;
+		len -= bytes;
+
+		*retlen += bytes;
+	}
+
+	mutex_unlock(&fsm->lock);
+
+	return 0;
+}
+
 static void stfsm_read_jedec(struct stfsm *fsm, uint8_t *const jedec)
 {
 	const struct stfsm_seq *seq = &stfsm_seq_read_jedec;
@@ -1197,6 +1293,8 @@ static int stfsm_probe(struct platform_device *pdev)
 	fsm->mtd.size		= info->sector_size * info->n_sectors;
 	fsm->mtd.erasesize	= info->sector_size;
 
+	fsm->mtd._read  = stfsm_mtd_read;
+
 	dev_err(&pdev->dev,
 		"Found serial flash device: %s\n"
 		" size = %llx (%lldMiB) erasesize = 0x%08x (%uKiB)\n",
-- 
1.8.3.2

  parent reply	other threads:[~2014-03-20  9:20 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20  9:20 [PATCH v6 00/36] mtd: st_spi_fsm: Add new driver Lee Jones
2014-03-20  9:20 ` [PATCH v6 01/36] mtd: st_spi_fsm: Allocate resources and register with MTD framework Lee Jones
2014-04-07  8:12   ` Paul Bolle
2014-04-07  9:11     ` Lee Jones
2014-04-07  9:41       ` Paul Bolle
2014-04-07 11:08         ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 02/36] mtd: st_spi_fsm: Supply all register address and bit logic defines Lee Jones
2014-03-20  9:20 ` [PATCH v6 03/36] mtd: st_spi_fsm: Initialise and configure the FSM for normal working conditions Lee Jones
2014-03-20  9:20 ` [PATCH v6 04/36] mtd: st_spi_fsm: Supply framework for device requests Lee Jones
2014-03-20  9:20 ` [PATCH v6 05/36] mtd: st_spi_fsm: Supply a method to read from the FSM's FIFO Lee Jones
2014-03-20  9:20 ` [PATCH v6 06/36] mtd: st_spi_fsm: Add support for JEDEC ID extraction Lee Jones
2014-03-20  9:20 ` [PATCH v6 07/36] mtd: devices: Provide header for shared OPCODEs and SFDP commands Lee Jones
2014-03-20  9:20 ` [PATCH v6 08/36] mtd: st_spi_fsm: Provide device look-up table Lee Jones
2014-03-20  9:20 ` [PATCH v6 09/36] mtd: st_spi_fsm: Dynamically setup flash device based on JEDEC ID Lee Jones
2014-03-20  9:20 ` [PATCH v6 10/36] mtd: st_spi_fsm: Search for preferred FSM message sequence configurations Lee Jones
2014-03-20  9:20 ` [PATCH v6 11/36] mtd: st_spi_fsm: Use device size to determine address width Lee Jones
2014-03-20  9:20 ` [PATCH v6 12/36] mtd: st_spi_fsm: Prepare the read/write FSM message sequence(s) Lee Jones
2014-03-20  9:20 ` [PATCH v6 13/36] mtd: st_spi_fsm: Add device-tree binding documentation Lee Jones
2014-03-20  9:20 ` [PATCH v6 14/36] mtd: st_spi_fsm: Fetch boot-device from mode pins Lee Jones
2014-03-20  9:20 ` [PATCH v6 15/36] mtd: st_spi_fsm: Provide the erase one sector sequence Lee Jones
2014-03-20  9:20 ` [PATCH v6 16/36] mtd: st_spi_fsm: Provide the sequence for enabling 32bit addressing mode Lee Jones
2014-03-20  9:20 ` [PATCH v6 17/36] mtd: st_spi_fsm: Prepare read/write sequences according to configuration Lee Jones
2014-03-20  9:20 ` [PATCH v6 18/36] mtd: st_spi_fsm: Add a check to if the chip can handle an SoC reset Lee Jones
2014-03-20  9:20 ` [PATCH v6 19/36] mtd: st_spi_fsm: Provide a method to put the chip into 32bit addressing mode Lee Jones
2014-03-20  9:20 ` [PATCH v6 20/36] mtd: st_spi_fsm: Update the flash Volatile Configuration Register Lee Jones
2014-03-20  9:20 ` [PATCH v6 21/36] mtd: st_spi_fsm: Provide the default read/write configurations Lee Jones
2014-03-20  9:20 ` [PATCH v6 22/36] mtd: st_spi_fsm: Supply the N25Qxxx specific read configurations Lee Jones
2014-03-20  9:20 ` [PATCH v6 23/36] mtd: st_spi_fsm: Supply the N25Qxxx chip specific configuration call-back Lee Jones
2014-03-20  9:20 ` [PATCH v6 24/36] mtd: st_spi_fsm: Prepare default sequences for read/write/erase Lee Jones
2014-03-20  9:20 ` Lee Jones [this message]
2014-03-20  9:20 ` [PATCH v6 26/36] mtd: st_spi_fsm: Write to Flash via the FSM FIFO Lee Jones
2014-03-20  9:20 ` [PATCH v6 27/36] mtd: st_spi_fsm: Supply a busy wait for post-write status Lee Jones
2014-03-20  9:21 ` [PATCH v6 28/36] mtd: st_spi_fsm: Erase partly or as a whole a Serial Flash device Lee Jones
2014-03-20  9:21 ` [PATCH v6 29/36] mtd: st_spi_fsm: Add the ability to read the FSM's status Lee Jones
2014-03-20  9:21 ` [PATCH v6 30/36] mtd: st_spi_fsm: Add the ability to write to FSM's status register Lee Jones
2014-03-20  9:21 ` [PATCH v6 31/36] mtd: st_spi_fsm: Supply the MX25xxx chip specific configuration call-back Lee Jones
2014-03-20  9:21 ` [PATCH v6 32/36] mtd: st_spi_fsm: Supply the S25FLxxx " Lee Jones
2014-03-20  9:21 ` [PATCH v6 33/36] mtd: st_spi_fsm: Supply the W25Qxxx " Lee Jones
2014-03-20  9:21 ` [PATCH v6 34/36] mtd: st_spi_fsm: Move runtime configurable msg sequences into device's struct Lee Jones
2014-03-20  9:21 ` [PATCH v6 35/36] mtd: st_spi_fsm: Convert ST SPI FSM (NOR) Flash driver to new DT partitions Lee Jones
2014-03-20  9:21 ` [PATCH v6 36/36] ARM: STi: Add support for the FSM Serial Flash Controller Lee Jones
2014-03-20 11:27   ` Brian Norris
2014-03-20 15:51     ` Lee Jones
2014-03-20  9:48 ` [PATCH v6 00/36] mtd: st_spi_fsm: Add new driver Brian Norris
2014-03-20 11:19 ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395307268-12721-26-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).