From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Thu, 20 Mar 2014 04:48:10 -0700 Subject: [PATCH 1/5] mtd: st_spi_fsm: Remove useless consts from function arguments In-Reply-To: <20140320114123.GE21349@lee--X1> References: <1395313907-25318-1-git-send-email-lee.jones@linaro.org> <1395313907-25318-2-git-send-email-lee.jones@linaro.org> <1395314713.7776.17.camel@joe-AO722> <20140320114123.GE21349@lee--X1> Message-ID: <1395316090.7776.24.camel@joe-AO722> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2014-03-20 at 11:41 +0000, Lee Jones wrote: > On Thu, 20 Mar 2014, Joe Perches wrote: > > > On Thu, 2014-03-20 at 11:11 +0000, Lee Jones wrote: > > > Reported-by: Brian Norris > > > Signed-off-by: Lee Jones > > > > Why are these useless? > > > > Even if the object code produced is the same, > > these serve as information to the human reader > > about how the arguments are used. > > https://lkml.org/lkml/2014/3/20/69 > >>From that email: suggestion: const uint8_t *const buf => const uint8_t *buf const uint32_t size => uint32_t size const uint32_t offset => uint32_t offset What was done: -static int stfsm_write_fifo(struct stfsm *fsm, - const uint32_t *buf, const uint32_t size) +static int stfsm_write_fifo(struct stfsm *fsm, uint32_t *buf, uint32_t size) Note the removal of the const from uint32_t *buf Why?