linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dinguyen@altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] ARM: socfpga: dts: add can0+1
Date: Tue, 1 Apr 2014 14:34:50 -0500	[thread overview]
Message-ID: <1396380890.27447.3.camel@linux-builds1> (raw)
In-Reply-To: <1396280404-2041-4-git-send-email-s.trumtrar@pengutronix.de>

On Mon, 2014-03-31 at 17:40 +0200, Steffen Trumtrar wrote:
> Add both can controllers to the dtsi.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  arch/arm/boot/dts/socfpga.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index d0594c3..51148b8 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -470,6 +470,22 @@
>  			status = "disabled";
>  		};
>  
> +		can0: can at 0xffc00000 {

I've seen a comment from Rob Herring to remove the 0x here.
> +			compatible = "bosch,d_can";
> +			reg = <0xffc00000 0x1000>;
> +			interrupts = <0 131 4>, <0 132 4>, <0 133 4>, <0 134 4>;
> +			clocks = <&can0_clk>;
> +			status = "disabled";
> +		};
> +
> +		can1: can at 0xffc01000 {

Same...

> +			compatible = "bosch,d_can";
> +			reg = <0xffc01000 0x1000>;
> +			interrupts = <0 135 4>, <0 136 4>, <0 137 4>, <0 138 4>;
> +			clocks = <&can1_clk>;
> +			status = "disabled";
> +		};
> +
>  		i2c0: i2c at 0xffc04000 {

Same comment here..but would apply to patch 3/6.

Thanks,

Dinh
>  			#address-cells = <1>;
>  			#size-cells = <0>;

  reply	other threads:[~2014-04-01 19:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31 15:39 [PATCH 1/6] ARM: socfpga: dts: fix pdma interrupt Steffen Trumtrar
2014-03-31 15:39 ` [PATCH 2/6] ARM: socfpga: dts: add remaining interrupts for pdma Steffen Trumtrar
2014-03-31 15:40 ` [PATCH 3/6] ARM: socfpga: dts: add i2c busses Steffen Trumtrar
2014-04-01 19:32   ` Dinh Nguyen
2014-04-02  6:57     ` Steffen Trumtrar
2014-03-31 15:40 ` [PATCH 4/6] ARM: socfpga: dts: add can0+1 Steffen Trumtrar
2014-04-01 19:34   ` Dinh Nguyen [this message]
2014-04-02  6:54     ` Steffen Trumtrar
2014-03-31 15:40 ` [PATCH 5/6] ARM: socfpga: dts: add support for EBV SOCrates Steffen Trumtrar
2014-03-31 15:40 ` [PATCH 6/6] ARM: socfpga: dts: add rtc on i2c0 to socrates Steffen Trumtrar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396380890.27447.3.camel@linux-builds1 \
    --to=dinguyen@altera.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).