linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: hisi: enable L2 driver
@ 2014-04-02 13:34 Haojian Zhuang
  2014-04-02 13:34 ` [PATCH 2/2] ARM: dts: fix L2 address in Hi3620 Haojian Zhuang
  2014-04-02 17:00 ` [PATCH 1/2] ARM: hisi: enable L2 driver Russell King - ARM Linux
  0 siblings, 2 replies; 5+ messages in thread
From: Haojian Zhuang @ 2014-04-02 13:34 UTC (permalink / raw)
  To: linux-arm-kernel

l2x0_of_init() is necessary to enable PL310 L2 cache controller.

Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
---
 arch/arm/mach-hisi/hisilicon.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/mach-hisi/hisilicon.c b/arch/arm/mach-hisi/hisilicon.c
index 741faf3..3a6f244 100644
--- a/arch/arm/mach-hisi/hisilicon.c
+++ b/arch/arm/mach-hisi/hisilicon.c
@@ -17,6 +17,7 @@
 #include <linux/of_address.h>
 #include <linux/of_platform.h>
 
+#include <asm/hardware/cache-l2x0.h>
 #include <asm/proc-fns.h>
 
 #include <asm/mach/arch.h>
@@ -51,6 +52,12 @@ static void __init hi3620_map_io(void)
 	iotable_init(hi3620_io_desc, ARRAY_SIZE(hi3620_io_desc));
 }
 
+static void __init hi3xxx_init(void)
+{
+	l2x0_of_init(0, ~0UL);
+	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
+}
+
 static void hi3xxx_restart(enum reboot_mode mode, const char *cmd)
 {
 	struct device_node *np;
@@ -86,5 +93,6 @@ DT_MACHINE_START(HI3620, "Hisilicon Hi3620 (Flattened Device Tree)")
 	.map_io		= hi3620_map_io,
 	.dt_compat	= hi3xxx_compat,
 	.smp		= smp_ops(hi3xxx_smp_ops),
+	.init_machine	= hi3xxx_init,
 	.restart	= hi3xxx_restart,
 MACHINE_END
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ARM: dts: fix L2 address in Hi3620
  2014-04-02 13:34 [PATCH 1/2] ARM: hisi: enable L2 driver Haojian Zhuang
@ 2014-04-02 13:34 ` Haojian Zhuang
  2014-04-02 17:00 ` [PATCH 1/2] ARM: hisi: enable L2 driver Russell King - ARM Linux
  1 sibling, 0 replies; 5+ messages in thread
From: Haojian Zhuang @ 2014-04-02 13:34 UTC (permalink / raw)
  To: linux-arm-kernel

Fix the address of L2 controler register in hi3620 SoC.

Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
---
 arch/arm/boot/dts/hi3620.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/hi3620.dtsi b/arch/arm/boot/dts/hi3620.dtsi
index ab1116d..83a5b86 100644
--- a/arch/arm/boot/dts/hi3620.dtsi
+++ b/arch/arm/boot/dts/hi3620.dtsi
@@ -73,7 +73,7 @@
 
 		L2: l2-cache {
 			compatible = "arm,pl310-cache";
-			reg = <0xfc10000 0x100000>;
+			reg = <0x100000 0x100000>;
 			interrupts = <0 15 4>;
 			cache-unified;
 			cache-level = <2>;
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 1/2] ARM: hisi: enable L2 driver
  2014-04-02 13:34 [PATCH 1/2] ARM: hisi: enable L2 driver Haojian Zhuang
  2014-04-02 13:34 ` [PATCH 2/2] ARM: dts: fix L2 address in Hi3620 Haojian Zhuang
@ 2014-04-02 17:00 ` Russell King - ARM Linux
  2014-04-03  1:00   ` Haojian Zhuang
  2014-04-03  1:01   ` [PATCH v2 " Haojian Zhuang
  1 sibling, 2 replies; 5+ messages in thread
From: Russell King - ARM Linux @ 2014-04-02 17:00 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Apr 02, 2014 at 09:34:22PM +0800, Haojian Zhuang wrote:
> +static void __init hi3xxx_init(void)
> +{
> +	l2x0_of_init(0, ~0UL);

	l2x0_of_init(0, ~0);

please, no need for a UL suffix on it.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] ARM: hisi: enable L2 driver
  2014-04-02 17:00 ` [PATCH 1/2] ARM: hisi: enable L2 driver Russell King - ARM Linux
@ 2014-04-03  1:00   ` Haojian Zhuang
  2014-04-03  1:01   ` [PATCH v2 " Haojian Zhuang
  1 sibling, 0 replies; 5+ messages in thread
From: Haojian Zhuang @ 2014-04-03  1:00 UTC (permalink / raw)
  To: linux-arm-kernel

On 3 April 2014 01:00, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Wed, Apr 02, 2014 at 09:34:22PM +0800, Haojian Zhuang wrote:
>> +static void __init hi3xxx_init(void)
>> +{
>> +     l2x0_of_init(0, ~0UL);
>
>         l2x0_of_init(0, ~0);
>
> please, no need for a UL suffix on it.
>
Got it.

Thanks
Haojian

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/2] ARM: hisi: enable L2 driver
  2014-04-02 17:00 ` [PATCH 1/2] ARM: hisi: enable L2 driver Russell King - ARM Linux
  2014-04-03  1:00   ` Haojian Zhuang
@ 2014-04-03  1:01   ` Haojian Zhuang
  1 sibling, 0 replies; 5+ messages in thread
From: Haojian Zhuang @ 2014-04-03  1:01 UTC (permalink / raw)
  To: linux-arm-kernel

l2x0_of_init() is necessary to enable PL310 L2 cache controller.

Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
---
 arch/arm/mach-hisi/hisilicon.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/mach-hisi/hisilicon.c b/arch/arm/mach-hisi/hisilicon.c
index 741faf3..5877e7d 100644
--- a/arch/arm/mach-hisi/hisilicon.c
+++ b/arch/arm/mach-hisi/hisilicon.c
@@ -17,6 +17,7 @@
 #include <linux/of_address.h>
 #include <linux/of_platform.h>
 
+#include <asm/hardware/cache-l2x0.h>
 #include <asm/proc-fns.h>
 
 #include <asm/mach/arch.h>
@@ -51,6 +52,12 @@ static void __init hi3620_map_io(void)
 	iotable_init(hi3620_io_desc, ARRAY_SIZE(hi3620_io_desc));
 }
 
+static void __init hi3xxx_init(void)
+{
+	l2x0_of_init(0, ~0);
+	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
+}
+
 static void hi3xxx_restart(enum reboot_mode mode, const char *cmd)
 {
 	struct device_node *np;
@@ -86,5 +93,6 @@ DT_MACHINE_START(HI3620, "Hisilicon Hi3620 (Flattened Device Tree)")
 	.map_io		= hi3620_map_io,
 	.dt_compat	= hi3xxx_compat,
 	.smp		= smp_ops(hi3xxx_smp_ops),
+	.init_machine	= hi3xxx_init,
 	.restart	= hi3xxx_restart,
 MACHINE_END
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-04-03  1:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 13:34 [PATCH 1/2] ARM: hisi: enable L2 driver Haojian Zhuang
2014-04-02 13:34 ` [PATCH 2/2] ARM: dts: fix L2 address in Hi3620 Haojian Zhuang
2014-04-02 17:00 ` [PATCH 1/2] ARM: hisi: enable L2 driver Russell King - ARM Linux
2014-04-03  1:00   ` Haojian Zhuang
2014-04-03  1:01   ` [PATCH v2 " Haojian Zhuang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).