From: elder@linaro.org (Alex Elder)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH RESEND] ARM: spear: send SGI to trigger secondary CPU start
Date: Tue, 8 Apr 2014 17:31:28 -0500 [thread overview]
Message-ID: <1396996288-32020-1-git-send-email-elder@linaro.org> (raw)
The ARM spear machine uses the "holding pen" mechanism for starting
secondary CPUs. Most implementations indicate it's a secondary
core's time to start by writing its CPU id into a location and
then signaling the core with a software-generated interrupt.
The spear code does not send the signal. Comments elsewhere
in the code seem to indicate it should:
The BootMonitor waits until it receives a soft interrupt, and
then the secondary CPU branches to this address.
I suspect this is an oversight, and this patch proposes a remedy.
*** I need the attention of a maintainer to verify this
*** because I am unable to test this proposed change.
Signed-off-by: Alex Elder <elder@linaro.org>
---
arch/arm/mach-spear/platsmp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-spear/platsmp.c b/arch/arm/mach-spear/platsmp.c
index 5c4a198..c9064fe 100644
--- a/arch/arm/mach-spear/platsmp.c
+++ b/arch/arm/mach-spear/platsmp.c
@@ -62,6 +62,8 @@ static int spear13xx_boot_secondary(unsigned int cpu, struct task_struct *idle)
flush_cache_all();
outer_flush_all();
+ arch_send_wakeup_ipi_mask(cpumask_of(cpu));
+
timeout = jiffies + (1 * HZ);
while (time_before(jiffies, timeout)) {
smp_rmb();
--
1.7.9.5
reply other threads:[~2014-04-08 22:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396996288-32020-1-git-send-email-elder@linaro.org \
--to=elder@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).