* [RFC PATCH RESEND] ARM: spear: send SGI to trigger secondary CPU start
@ 2014-04-08 22:31 Alex Elder
0 siblings, 0 replies; only message in thread
From: Alex Elder @ 2014-04-08 22:31 UTC (permalink / raw)
To: linux-arm-kernel
The ARM spear machine uses the "holding pen" mechanism for starting
secondary CPUs. Most implementations indicate it's a secondary
core's time to start by writing its CPU id into a location and
then signaling the core with a software-generated interrupt.
The spear code does not send the signal. Comments elsewhere
in the code seem to indicate it should:
The BootMonitor waits until it receives a soft interrupt, and
then the secondary CPU branches to this address.
I suspect this is an oversight, and this patch proposes a remedy.
*** I need the attention of a maintainer to verify this
*** because I am unable to test this proposed change.
Signed-off-by: Alex Elder <elder@linaro.org>
---
arch/arm/mach-spear/platsmp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-spear/platsmp.c b/arch/arm/mach-spear/platsmp.c
index 5c4a198..c9064fe 100644
--- a/arch/arm/mach-spear/platsmp.c
+++ b/arch/arm/mach-spear/platsmp.c
@@ -62,6 +62,8 @@ static int spear13xx_boot_secondary(unsigned int cpu, struct task_struct *idle)
flush_cache_all();
outer_flush_all();
+ arch_send_wakeup_ipi_mask(cpumask_of(cpu));
+
timeout = jiffies + (1 * HZ);
while (time_before(jiffies, timeout)) {
smp_rmb();
--
1.7.9.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-04-08 22:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-08 22:31 [RFC PATCH RESEND] ARM: spear: send SGI to trigger secondary CPU start Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).