* [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap
@ 2014-04-10 14:19 Ulf Hansson
2014-05-06 9:32 ` Ulf Hansson
2014-05-14 15:57 ` Wolfram Sang
0 siblings, 2 replies; 4+ messages in thread
From: Ulf Hansson @ 2014-04-10 14:19 UTC (permalink / raw)
To: linux-arm-kernel
devm_ioremap() returns NULL on error, not an error.
Cc: Alessandro Rubini <rubini@unipv.it>
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/i2c/busses/i2c-nomadik.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index 28cbe1b..32c85e9 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -999,7 +999,7 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)
dev->virtbase = devm_ioremap(&adev->dev, adev->res.start,
resource_size(&adev->res));
- if (IS_ERR(dev->virtbase)) {
+ if (!dev->virtbase) {
ret = -ENOMEM;
goto err_no_mem;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap
2014-04-10 14:19 [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap Ulf Hansson
@ 2014-05-06 9:32 ` Ulf Hansson
2014-05-06 18:48 ` Linus Walleij
2014-05-14 15:57 ` Wolfram Sang
1 sibling, 1 reply; 4+ messages in thread
From: Ulf Hansson @ 2014-05-06 9:32 UTC (permalink / raw)
To: linux-arm-kernel
On 10 April 2014 16:19, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> devm_ioremap() returns NULL on error, not an error.
>
> Cc: Alessandro Rubini <rubini@unipv.it>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Linus, Wolfram - ping.
Kind regards
Ulf Hansson
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap
2014-05-06 9:32 ` Ulf Hansson
@ 2014-05-06 18:48 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2014-05-06 18:48 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 6, 2014 at 11:32 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 10 April 2014 16:19, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> devm_ioremap() returns NULL on error, not an error.
>>
>> Cc: Alessandro Rubini <rubini@unipv.it>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Linus, Wolfram - ping.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap
2014-04-10 14:19 [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap Ulf Hansson
2014-05-06 9:32 ` Ulf Hansson
@ 2014-05-14 15:57 ` Wolfram Sang
1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2014-05-14 15:57 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Apr 10, 2014 at 04:19:29PM +0200, Ulf Hansson wrote:
> devm_ioremap() returns NULL on error, not an error.
>
> Cc: Alessandro Rubini <rubini@unipv.it>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Applied to for-current, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140514/7cdedf9b/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-14 15:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-10 14:19 [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap Ulf Hansson
2014-05-06 9:32 ` Ulf Hansson
2014-05-06 18:48 ` Linus Walleij
2014-05-14 15:57 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).