* [PATCH 1/2] ARM: dt-binding: fix GIC example @ 2014-03-28 16:25 Lucas Stach 2014-03-28 16:25 ` [PATCH 2/2] ARM: dts: imx: drop invalid size and address cells properties Lucas Stach 2014-04-10 15:21 ` [PATCH 1/2] ARM: dt-binding: fix GIC example Rob Herring 0 siblings, 2 replies; 9+ messages in thread From: Lucas Stach @ 2014-03-28 16:25 UTC (permalink / raw) To: linux-arm-kernel From: Tim Harvey <tharvey@gateworks.com> When using interrupt-maps, the size of a map entry is #address-cells + address-cells should be 0 as this is not used. As #address-cells = <0> is the same as not specifying the property, simply remove it. Signed-off-by: Tim Harvey <tharvey@gateworks.com> Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- v2 lst: - completely remove the property --- Documentation/devicetree/bindings/arm/gic.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/arm/gic.txt b/Documentation/devicetree/bindings/arm/gic.txt index bae0d87a38b2..42ab3b28a266 100644 --- a/Documentation/devicetree/bindings/arm/gic.txt +++ b/Documentation/devicetree/bindings/arm/gic.txt @@ -55,7 +55,6 @@ Example: intc: interrupt-controller at fff11000 { compatible = "arm,cortex-a9-gic"; #interrupt-cells = <3>; - #address-cells = <1>; interrupt-controller; reg = <0xfff11000 0x1000>, <0xfff10100 0x100>; -- 1.9.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] ARM: dts: imx: drop invalid size and address cells properties 2014-03-28 16:25 [PATCH 1/2] ARM: dt-binding: fix GIC example Lucas Stach @ 2014-03-28 16:25 ` Lucas Stach 2014-04-03 6:47 ` Shawn Guo 2014-04-10 15:21 ` [PATCH 1/2] ARM: dt-binding: fix GIC example Rob Herring 1 sibling, 1 reply; 9+ messages in thread From: Lucas Stach @ 2014-03-28 16:25 UTC (permalink / raw) To: linux-arm-kernel Those two properties should have been set to zero, which is the same as not specifying them. Having address-cells set to 1 causes OF interrupt mapping routines to add 1 to the interrupt-cells property and as result fail because all calculations are off by one. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- arch/arm/boot/dts/imx6qdl.dtsi | 2 -- arch/arm/boot/dts/imx6sl.dtsi | 2 -- 2 files changed, 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index fb28b2ecb1db..31bd844798a7 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -38,8 +38,6 @@ intc: interrupt-controller at 00a01000 { compatible = "arm,cortex-a9-gic"; #interrupt-cells = <3>; - #address-cells = <1>; - #size-cells = <1>; interrupt-controller; reg = <0x00a01000 0x1000>, <0x00a00100 0x100>; diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi index 28558f1aaf2d..276425089ea0 100644 --- a/arch/arm/boot/dts/imx6sl.dtsi +++ b/arch/arm/boot/dts/imx6sl.dtsi @@ -44,8 +44,6 @@ intc: interrupt-controller at 00a01000 { compatible = "arm,cortex-a9-gic"; #interrupt-cells = <3>; - #address-cells = <1>; - #size-cells = <1>; interrupt-controller; reg = <0x00a01000 0x1000>, <0x00a00100 0x100>; -- 1.9.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] ARM: dts: imx: drop invalid size and address cells properties 2014-03-28 16:25 ` [PATCH 2/2] ARM: dts: imx: drop invalid size and address cells properties Lucas Stach @ 2014-04-03 6:47 ` Shawn Guo 0 siblings, 0 replies; 9+ messages in thread From: Shawn Guo @ 2014-04-03 6:47 UTC (permalink / raw) To: linux-arm-kernel On Fri, Mar 28, 2014 at 05:25:51PM +0100, Lucas Stach wrote: > Those two properties should have been set to zero, which > is the same as not specifying them. > > Having address-cells set to 1 causes OF interrupt > mapping routines to add 1 to the interrupt-cells > property and as result fail because all calculations > are off by one. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Applied, thanks. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] ARM: dt-binding: fix GIC example 2014-03-28 16:25 [PATCH 1/2] ARM: dt-binding: fix GIC example Lucas Stach 2014-03-28 16:25 ` [PATCH 2/2] ARM: dts: imx: drop invalid size and address cells properties Lucas Stach @ 2014-04-10 15:21 ` Rob Herring 2014-04-11 1:16 ` Shawn Guo 2014-04-11 10:10 ` Lucas Stach 1 sibling, 2 replies; 9+ messages in thread From: Rob Herring @ 2014-04-10 15:21 UTC (permalink / raw) To: linux-arm-kernel On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > From: Tim Harvey <tharvey@gateworks.com> > > When using interrupt-maps, the size of a map entry is #address-cells + Plus what? You mean ", and "? > address-cells should be 0 as this is not used. > > As #address-cells = <0> is the same as not specifying the > property, simply remove it. > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Did this get applied? I can't seem to find patch 2. Rob ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] ARM: dt-binding: fix GIC example 2014-04-10 15:21 ` [PATCH 1/2] ARM: dt-binding: fix GIC example Rob Herring @ 2014-04-11 1:16 ` Shawn Guo 2014-04-11 10:10 ` Lucas Stach 1 sibling, 0 replies; 9+ messages in thread From: Shawn Guo @ 2014-04-11 1:16 UTC (permalink / raw) To: linux-arm-kernel On Thu, Apr 10, 2014 at 10:21:35AM -0500, Rob Herring wrote: > On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > > From: Tim Harvey <tharvey@gateworks.com> > > > > When using interrupt-maps, the size of a map entry is #address-cells + > > Plus what? You mean ", and "? > > > address-cells should be 0 as this is not used. > > > > As #address-cells = <0> is the same as not specifying the > > property, simply remove it. > > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > Did this get applied? I can't seem to find patch 2. No. We expect this patch to be applied on DT tree, while the patch #2 [1] is going through IMX tree. Shawn [1] http://www.spinics.net/lists/arm-kernel/msg318810.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] ARM: dt-binding: fix GIC example 2014-04-10 15:21 ` [PATCH 1/2] ARM: dt-binding: fix GIC example Rob Herring 2014-04-11 1:16 ` Shawn Guo @ 2014-04-11 10:10 ` Lucas Stach 2014-04-11 13:20 ` Rob Herring 1 sibling, 1 reply; 9+ messages in thread From: Lucas Stach @ 2014-04-11 10:10 UTC (permalink / raw) To: linux-arm-kernel Hi Rob, Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring: > On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > > From: Tim Harvey <tharvey@gateworks.com> > > > > When using interrupt-maps, the size of a map entry is #address-cells + > > Plus what? You mean ", and "? > Urgh, I obviously messed this up while editing the commit message in the last minute. It should have been something along the lines of: When using interrupt-maps, the size of a map entry is #address-cells + #interrupt-cells. address-cells should be 0 as this offset is not used in the GIC. As #address-cells = <0> is the same as not specifying the property, simply remove it. Can you edit this while applying, or should I send a new patch? > > address-cells should be 0 as this is not used. > > > > As #address-cells = <0> is the same as not specifying the > > property, simply remove it. > > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > Did this get applied? I can't seem to find patch 2. > As Shawn pointed out patch 2 got applied through the imx tree as it fixes a real bug there. Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] ARM: dt-binding: fix GIC example 2014-04-11 10:10 ` Lucas Stach @ 2014-04-11 13:20 ` Rob Herring 2014-04-11 13:23 ` Lucas Stach 0 siblings, 1 reply; 9+ messages in thread From: Rob Herring @ 2014-04-11 13:20 UTC (permalink / raw) To: linux-arm-kernel On Fri, Apr 11, 2014 at 5:10 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > Hi Rob, > > Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring: >> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach@pengutronix.de> wrote: >> > From: Tim Harvey <tharvey@gateworks.com> >> > >> > When using interrupt-maps, the size of a map entry is #address-cells + >> >> Plus what? You mean ", and "? >> > Urgh, I obviously messed this up while editing the commit message in the > last minute. It should have been something along the lines of: > > When using interrupt-maps, the size of a map entry is #address-cells + > #interrupt-cells. address-cells should be 0 as this offset is not used > in the GIC. > > As #address-cells = <0> is the same as not specifying the > property, simply remove it. > > Can you edit this while applying, or should I send a new patch? I'll fix it up and apply. > >> > address-cells should be 0 as this is not used. >> > >> > As #address-cells = <0> is the same as not specifying the >> > property, simply remove it. >> > >> > Signed-off-by: Tim Harvey <tharvey@gateworks.com> >> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> >> >> Did this get applied? I can't seem to find patch 2. >> > As Shawn pointed out patch 2 got applied through the imx tree as it > fixes a real bug there. It was highlighted that other instances beyond iMX were wrong. Please fix those as well. Rob ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] ARM: dt-binding: fix GIC example 2014-04-11 13:20 ` Rob Herring @ 2014-04-11 13:23 ` Lucas Stach 2014-04-11 13:40 ` Rob Herring 0 siblings, 1 reply; 9+ messages in thread From: Lucas Stach @ 2014-04-11 13:23 UTC (permalink / raw) To: linux-arm-kernel Am Freitag, den 11.04.2014, 08:20 -0500 schrieb Rob Herring: > On Fri, Apr 11, 2014 at 5:10 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > > Hi Rob, > > > > Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring: > >> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > >> > From: Tim Harvey <tharvey@gateworks.com> > >> > > >> > When using interrupt-maps, the size of a map entry is #address-cells + > >> > >> Plus what? You mean ", and "? > >> > > Urgh, I obviously messed this up while editing the commit message in the > > last minute. It should have been something along the lines of: > > > > When using interrupt-maps, the size of a map entry is #address-cells + > > #interrupt-cells. address-cells should be 0 as this offset is not used > > in the GIC. > > > > As #address-cells = <0> is the same as not specifying the > > property, simply remove it. > > > > Can you edit this while applying, or should I send a new patch? > > I'll fix it up and apply. > Thanks. > > > >> > address-cells should be 0 as this is not used. > >> > > >> > As #address-cells = <0> is the same as not specifying the > >> > property, simply remove it. > >> > > >> > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > >> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > >> > >> Did this get applied? I can't seem to find patch 2. > >> > > As Shawn pointed out patch 2 got applied through the imx tree as it > > fixes a real bug there. > > It was highlighted that other instances beyond iMX were wrong. Please > fix those as well. Oh, I wasn't aware of that. Will send patches. Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] ARM: dt-binding: fix GIC example 2014-04-11 13:23 ` Lucas Stach @ 2014-04-11 13:40 ` Rob Herring 0 siblings, 0 replies; 9+ messages in thread From: Rob Herring @ 2014-04-11 13:40 UTC (permalink / raw) To: linux-arm-kernel On Fri, Apr 11, 2014 at 8:23 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > Am Freitag, den 11.04.2014, 08:20 -0500 schrieb Rob Herring: >> On Fri, Apr 11, 2014 at 5:10 AM, Lucas Stach <l.stach@pengutronix.de> wrote: >> > Hi Rob, >> > >> > Am Donnerstag, den 10.04.2014, 10:21 -0500 schrieb Rob Herring: >> >> On Fri, Mar 28, 2014 at 11:25 AM, Lucas Stach <l.stach@pengutronix.de> wrote: >> >> > From: Tim Harvey <tharvey@gateworks.com> >> >> > >> >> > When using interrupt-maps, the size of a map entry is #address-cells + >> >> >> >> Plus what? You mean ", and "? >> >> >> > Urgh, I obviously messed this up while editing the commit message in the >> > last minute. It should have been something along the lines of: >> > >> > When using interrupt-maps, the size of a map entry is #address-cells + >> > #interrupt-cells. address-cells should be 0 as this offset is not used >> > in the GIC. >> > >> > As #address-cells = <0> is the same as not specifying the >> > property, simply remove it. >> > >> > Can you edit this while applying, or should I send a new patch? >> >> I'll fix it up and apply. >> > Thanks. > >> > >> >> > address-cells should be 0 as this is not used. >> >> > >> >> > As #address-cells = <0> is the same as not specifying the >> >> > property, simply remove it. >> >> > >> >> > Signed-off-by: Tim Harvey <tharvey@gateworks.com> >> >> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> >> >> >> >> Did this get applied? I can't seem to find patch 2. >> >> >> > As Shawn pointed out patch 2 got applied through the imx tree as it >> > fixes a real bug there. >> >> It was highlighted that other instances beyond iMX were wrong. Please >> fix those as well. > > Oh, I wasn't aware of that. Will send patches. It was raised here: http://www.spinics.net/lists/linux-pci/msg29768.html Here's a somewhat accurate list: $ git grep -A8 'arm,.*gic' origin/master -- arch/arm/boot/dts | grep 'address.*1' origin/master:arch/arm/boot/dts/ecx-2000.dts- #address-cells = <1>; origin/master:arch/arm/boot/dts/highbank.dts- #address-cells = <1>; origin/master:arch/arm/boot/dts/imx6qdl.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/imx6sl.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/keystone.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/r8a7740.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/sh73a0.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/socfpga.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/ste-dbx5x0.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/vf610.dtsi- #address-cells = <1>; origin/master:arch/arm/boot/dts/zynq-7000.dtsi- #address-cells = <1>; Rob ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-04-11 13:40 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-03-28 16:25 [PATCH 1/2] ARM: dt-binding: fix GIC example Lucas Stach 2014-03-28 16:25 ` [PATCH 2/2] ARM: dts: imx: drop invalid size and address cells properties Lucas Stach 2014-04-03 6:47 ` Shawn Guo 2014-04-10 15:21 ` [PATCH 1/2] ARM: dt-binding: fix GIC example Rob Herring 2014-04-11 1:16 ` Shawn Guo 2014-04-11 10:10 ` Lucas Stach 2014-04-11 13:20 ` Rob Herring 2014-04-11 13:23 ` Lucas Stach 2014-04-11 13:40 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).