linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: propagate DI clock changes up the clock tree to PLL5
Date: Fri, 11 Apr 2014 16:00:12 +0200	[thread overview]
Message-ID: <1397224812.4577.10.camel@weser.hi.pengutronix.de> (raw)
In-Reply-To: <CAJ+vNU0V_vXDOvergiQ2q00EFL46kGFJCvqCS=hdW5x=0rjN5Q@mail.gmail.com>

Hi Tim,

Am Donnerstag, den 10.04.2014, 21:48 -0700 schrieb Tim Harvey:
> On Thu, Apr 10, 2014 at 9:31 PM, Tim Harvey <tharvey@gateworks.com> wrote:
> > On Wed, Apr 9, 2014 at 8:39 AM, Russell King
> > <rmk+kernel@arm.linux.org.uk> wrote:
> >> Allows clk_set_rate() on the DI clocks to propagate up to PLL5.
> >>
> >> This allows imx-drm to produce the exact clock rate required with no
> >> modulation due to the fractional divider.  Modulation of the clock rate
> >> can and does prevent TVs from locking to the HDMI signal - they will
> >> report no signal rather than trying to lock to such a signal.
> >>
> >> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> >> ---
> >> I still have this patch which is required so that imx-drm is capable of
> >> producing HDMI clocks which are close enough to the HDMI defined
> >> frequencies such that TVs and similar can recognise the signal.  Without
> >> this, I don't get any kind of output on my TV desite imx-drm being set
> >> to the correct mode.  I have proven that this is because the HDMI clock
> >> is *very* wrong without this patch.
> >>
> >>  arch/arm/mach-imx/clk-imx6q.c | 12 ++++++------
> >>  1 file changed, 6 insertions(+), 6 deletions(-)
> >>
> >
> > Hi Russell,
> >
> > This fixed HDMI on the boards I'm testing it on (Gateworks Ventana).
> > Without it I encounter the same issue you describe above.
> >
> > Tested-by: Tim Harvey <tharvey@gateworks.com>
> >
> > Tim
> 
> I neglected to mention that even after this patch I do see an issue
> where the monitor does not sync if plugged in on board powerup.  The
> following is what I see with DEBUG enabled in imx-hdmi:
> 
I think this is fallout from how we handle the EDID fetch on startup. We
have patches lying around to fix this. Will post them in a minute.

Regards,
Lucas
-- 
Pengutronix e.K.                           | Lucas Stach                 |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2014-04-11 14:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 15:39 [PATCH] ARM: imx: propagate DI clock changes up the clock tree to PLL5 Russell King
2014-04-10  8:45 ` Philipp Zabel
2014-04-14 12:00   ` Russell King - ARM Linux
2014-04-11  4:31 ` Tim Harvey
2014-04-11  4:48   ` Tim Harvey
2014-04-11 14:00     ` Lucas Stach [this message]
2014-04-12  8:04       ` Tim Harvey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397224812.4577.10.camel@weser.hi.pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).