From: alexanders83@web.de (Alexander Stein)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio/at91: free GPIO after configuring as input
Date: Fri, 11 Apr 2014 16:24:09 +0200 [thread overview]
Message-ID: <1397226249-3922-1-git-send-email-alexanders83@web.de> (raw)
If the GPIO stays requested a device driver can't request it again.
e.g. Without this patch the ads7846 driver returns the following error:
ads7846 spi32766.3: failed to request/setup pendown GPIO15: -16
ads7846: probe of spi32766.3 failed with error -16
/sys/kernel/debug/gpio shows this:
GPIOs 0-31, platform/fffff200.gpio, fffff200.gpio:
[/ahb/apb/pinctrl at fffff200/gpio at fffff200] GPIOfffff200.gpio15: [gpio] set
Signed-off-by: Alexander Stein <alexanders83@web.de>
---
I'm aware that it makes sense this GPIO is/stays requested, but either the
pinctl or device driver have to be adjusted as both can't request this GPIO.
I think the latter shouldn't change.
drivers/pinctrl/pinctrl-at91.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index d990e33..63176f2 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -1493,6 +1493,8 @@ static int at91_gpio_irq_domain_xlate(struct irq_domain *d,
if (ret)
return ret;
+ gpio_free(pin);
+
return 0;
}
--
1.9.2
next reply other threads:[~2014-04-11 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 14:24 Alexander Stein [this message]
2014-04-11 15:30 ` [PATCH] gpio/at91: free GPIO after configuring as input Jean-Christophe PLAGNIOL-VILLARD
2014-04-11 15:45 ` Alexander Stein
2014-04-11 17:28 ` Javier Martinez Canillas
2014-04-12 22:48 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397226249-3922-1-git-send-email-alexanders83@web.de \
--to=alexanders83@web.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).