From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: shmobile: Ignore callbacks for subsys generic_pm_domain_data
Date: Fri, 11 Apr 2014 17:26:41 +0200 [thread overview]
Message-ID: <1397230004-22306-2-git-send-email-ulf.hansson@linaro.org> (raw)
In-Reply-To: <1397230004-22306-1-git-send-email-ulf.hansson@linaro.org>
There are no active users of these callbacks, thus there are no benefit
of trying to invoke them.
Cc: Simon Horman <horms@verge.net.au>
Cc: Magnus Damm <magnus.damm@gmail.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
I am seeking ack from the SOC maintainers since this needs to go with the other
patches in this patchset on the PM core.
---
arch/arm/mach-shmobile/pm-rmobile.c | 38 +++--------------------------------
1 file changed, 3 insertions(+), 35 deletions(-)
diff --git a/arch/arm/mach-shmobile/pm-rmobile.c b/arch/arm/mach-shmobile/pm-rmobile.c
index 1fc05d9..f710235 100644
--- a/arch/arm/mach-shmobile/pm-rmobile.c
+++ b/arch/arm/mach-shmobile/pm-rmobile.c
@@ -99,39 +99,7 @@ static int rmobile_pd_power_up(struct generic_pm_domain *genpd)
static bool rmobile_pd_active_wakeup(struct device *dev)
{
- bool (*active_wakeup)(struct device *dev);
-
- active_wakeup = dev_gpd_data(dev)->ops.active_wakeup;
- return active_wakeup ? active_wakeup(dev) : true;
-}
-
-static int rmobile_pd_stop_dev(struct device *dev)
-{
- int (*stop)(struct device *dev);
-
- stop = dev_gpd_data(dev)->ops.stop;
- if (stop) {
- int ret = stop(dev);
- if (ret)
- return ret;
- }
- return pm_clk_suspend(dev);
-}
-
-static int rmobile_pd_start_dev(struct device *dev)
-{
- int (*start)(struct device *dev);
- int ret;
-
- ret = pm_clk_resume(dev);
- if (ret)
- return ret;
-
- start = dev_gpd_data(dev)->ops.start;
- if (start)
- ret = start(dev);
-
- return ret;
+ return true;
}
static void rmobile_init_pm_domain(struct rmobile_pm_domain *rmobile_pd)
@@ -140,8 +108,8 @@ static void rmobile_init_pm_domain(struct rmobile_pm_domain *rmobile_pd)
struct dev_power_governor *gov = rmobile_pd->gov;
pm_genpd_init(genpd, gov ? : &simple_qos_governor, false);
- genpd->dev_ops.stop = rmobile_pd_stop_dev;
- genpd->dev_ops.start = rmobile_pd_start_dev;
+ genpd->dev_ops.stop = pm_clk_suspend;
+ genpd->dev_ops.start = pm_clk_resume;
genpd->dev_ops.active_wakeup = rmobile_pd_active_wakeup;
genpd->dev_irq_safe = true;
genpd->power_off = rmobile_pd_power_down;
--
1.7.9.5
next prev parent reply other threads:[~2014-04-11 15:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 15:26 [PATCH 0/4] PM / Domains: Remove some code and APIs to simplify genpd Ulf Hansson
2014-04-11 15:26 ` Ulf Hansson [this message]
2014-04-14 1:20 ` [PATCH 1/4] ARM: shmobile: Ignore callbacks for subsys generic_pm_domain_data Simon Horman
2014-04-14 9:22 ` Ulf Hansson
2014-04-24 11:25 ` Ulf Hansson
2014-04-25 1:06 ` Simon Horman
2014-04-29 22:45 ` Rafael J. Wysocki
2014-04-30 8:53 ` Ulf Hansson
2014-04-30 10:23 ` Simon Horman
2014-04-30 20:21 ` Rafael J. Wysocki
2014-05-02 9:13 ` Ulf Hansson
2014-05-02 11:57 ` Rafael J. Wysocki
2014-04-11 15:26 ` [PATCH 2/4] PM / Domains: " Ulf Hansson
2014-04-11 15:26 ` [PATCH 3/4] PM / Domains: Remove the pm_genpd_add|remove_callbacks APIs Ulf Hansson
2014-04-11 15:26 ` [PATCH 4/4] PM / Domains: Remove system PM callbacks from gpd_dev_ops Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397230004-22306-2-git-send-email-ulf.hansson@linaro.org \
--to=ulf.hansson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).