[PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support

[PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/boot/dts/imx27-pdk.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/imx27-pdk.dts b/arch/arm/boot/dts/imx27-pdk.dts
index 971961f..c629a8c 100644
--- a/arch/arm/boot/dts/imx27-pdk.dts
+++ b/arch/arm/boot/dts/imx27-pdk.dts
@@ -84,6 +84,12 @@
 	status = "okay";
 };
 
+&nfc {
+	status = "okay";
+	nand-ecc-mode = "hw";
+	nand-on-flash-bbt;
+};
+
 &uart1 {
 	fsl,uart-has-rtscts;
 	pinctrl-names = "default";
-- 
1.8.3.2

[PATCH 2/2] ARM: dts: imx27-pdk: Add keypad support

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/boot/dts/imx27-pdk.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/imx27-pdk.dts b/arch/arm/boot/dts/imx27-pdk.dts
index c629a8c..2b7b24f 100644
--- a/arch/arm/boot/dts/imx27-pdk.dts
+++ b/arch/arm/boot/dts/imx27-pdk.dts
@@ -10,6 +10,7 @@
  */
 
 /dts-v1/;
+#include <dt-bindings/input/input.h>
 #include "imx27.dtsi"
 
 / {
@@ -84,6 +85,21 @@
 	status = "okay";
 };
 
+&kpp {
+	linux,keymap = <
+		MATRIX_KEY(0, 0, KEY_UP)
+		MATRIX_KEY(0, 1, KEY_DOWN)
+		MATRIX_KEY(1, 0, KEY_RIGHT)
+		MATRIX_KEY(1, 1, KEY_LEFT)
+		MATRIX_KEY(1, 2, KEY_ENTER)
+		MATRIX_KEY(2, 0, KEY_F6)
+		MATRIX_KEY(2, 1, KEY_F8)
+		MATRIX_KEY(2, 2, KEY_F9)
+		MATRIX_KEY(2, 3, KEY_F10)
+	>;
+	status = "okay";
+};
+
 &nfc {
 	status = "okay";
 	nand-ecc-mode = "hw";
-- 
1.8.3.2

Re: [PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support

[Alexander Shiyan]

Thu, 17 Apr 2014 09:42:40 -0300 ?? Fabio Estevam <festevam@gmail.com>:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/boot/dts/imx27-pdk.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx27-pdk.dts b/arch/arm/boot/dts/imx27-pdk.dts
> index 971961f..c629a8c 100644
> --- a/arch/arm/boot/dts/imx27-pdk.dts
> +++ b/arch/arm/boot/dts/imx27-pdk.dts
> @@ -84,6 +84,12 @@
>  	status = "okay";
>  };
>  
> +&nfc {
> +	status = "okay";
> +	nand-ecc-mode = "hw";
> +	nand-on-flash-bbt;
> +};

You also should add pin definitions.

---

Re: [PATCH 2/2] ARM: dts: imx27-pdk: Add keypad support

[Alexander Shiyan]

Thu, 17 Apr 2014 09:42:41 -0300 ?? Fabio Estevam <festevam@gmail.com>:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/boot/dts/imx27-pdk.dts | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx27-pdk.dts b/arch/arm/boot/dts/imx27-pdk.dts
> index c629a8c..2b7b24f 100644
> --- a/arch/arm/boot/dts/imx27-pdk.dts
> +++ b/arch/arm/boot/dts/imx27-pdk.dts
> @@ -10,6 +10,7 @@
>   */
>  
>  /dts-v1/;
> +#include <dt-bindings/input/input.h>

I think we can include this into imx27.dtsi, same as other files.

---

[PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support

[Fabio Estevam]

On Thu, Apr 17, 2014 at 10:01 AM, Alexander Shiyan <shc_work@mail.ru> wrote:

>> +&nfc {
>> +     status = "okay";
>> +     nand-ecc-mode = "hw";
>> +     nand-on-flash-bbt;
>> +};
>
> You also should add pin definitions.

NAND is detected even without the pin definitions.
arch/arm/mach-imx/mach-mx27_3ds.c also does not define the NAND pins.

Re: [PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support

[Alexander Shiyan]

Thu, 17 Apr 2014 10:12:34 -0300 ?? Fabio Estevam <festevam@gmail.com>:
> On Thu, Apr 17, 2014 at 10:01 AM, Alexander Shiyan <shc_work@mail.ru> wrote:
> 
> >> +&nfc {
> >> +     status = "okay";
> >> +     nand-ecc-mode = "hw";
> >> +     nand-on-flash-bbt;
> >> +};
> >
> > You also should add pin definitions.
> 
> NAND is detected even without the pin definitions.
> arch/arm/mach-imx/mach-mx27_3ds.c also does not define the NAND pins.

What if NFC pins are defined as GPIOs in the bootloader?
The definition of pins is a good idea, because we get a runtime
warning in case a possible conflict.

---