* [PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support @ 2014-04-17 12:42 Fabio Estevam 2014-04-17 12:42 ` [PATCH 2/2] ARM: dts: imx27-pdk: Add keypad support Fabio Estevam 2014-04-17 13:01 ` [PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support Alexander Shiyan 0 siblings, 2 replies; 6+ messages in thread From: Fabio Estevam @ 2014-04-17 12:42 UTC (permalink / raw) To: linux-arm-kernel From: Fabio Estevam <fabio.estevam@freescale.com> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- arch/arm/boot/dts/imx27-pdk.dts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/imx27-pdk.dts b/arch/arm/boot/dts/imx27-pdk.dts index 971961f..c629a8c 100644 --- a/arch/arm/boot/dts/imx27-pdk.dts +++ b/arch/arm/boot/dts/imx27-pdk.dts @@ -84,6 +84,12 @@ status = "okay"; }; +&nfc { + status = "okay"; + nand-ecc-mode = "hw"; + nand-on-flash-bbt; +}; + &uart1 { fsl,uart-has-rtscts; pinctrl-names = "default"; -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: dts: imx27-pdk: Add keypad support 2014-04-17 12:42 [PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support Fabio Estevam @ 2014-04-17 12:42 ` Fabio Estevam 2014-04-17 13:04 ` Alexander Shiyan 2014-04-17 13:01 ` [PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support Alexander Shiyan 1 sibling, 1 reply; 6+ messages in thread From: Fabio Estevam @ 2014-04-17 12:42 UTC (permalink / raw) To: linux-arm-kernel From: Fabio Estevam <fabio.estevam@freescale.com> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- arch/arm/boot/dts/imx27-pdk.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/imx27-pdk.dts b/arch/arm/boot/dts/imx27-pdk.dts index c629a8c..2b7b24f 100644 --- a/arch/arm/boot/dts/imx27-pdk.dts +++ b/arch/arm/boot/dts/imx27-pdk.dts @@ -10,6 +10,7 @@ */ /dts-v1/; +#include <dt-bindings/input/input.h> #include "imx27.dtsi" / { @@ -84,6 +85,21 @@ status = "okay"; }; +&kpp { + linux,keymap = < + MATRIX_KEY(0, 0, KEY_UP) + MATRIX_KEY(0, 1, KEY_DOWN) + MATRIX_KEY(1, 0, KEY_RIGHT) + MATRIX_KEY(1, 1, KEY_LEFT) + MATRIX_KEY(1, 2, KEY_ENTER) + MATRIX_KEY(2, 0, KEY_F6) + MATRIX_KEY(2, 1, KEY_F8) + MATRIX_KEY(2, 2, KEY_F9) + MATRIX_KEY(2, 3, KEY_F10) + >; + status = "okay"; +}; + &nfc { status = "okay"; nand-ecc-mode = "hw"; -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: imx27-pdk: Add keypad support 2014-04-17 12:42 ` [PATCH 2/2] ARM: dts: imx27-pdk: Add keypad support Fabio Estevam @ 2014-04-17 13:04 ` Alexander Shiyan 0 siblings, 0 replies; 6+ messages in thread From: Alexander Shiyan @ 2014-04-17 13:04 UTC (permalink / raw) To: linux-arm-kernel Thu, 17 Apr 2014 09:42:41 -0300 ?? Fabio Estevam <festevam@gmail.com>: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > arch/arm/boot/dts/imx27-pdk.dts | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/imx27-pdk.dts b/arch/arm/boot/dts/imx27-pdk.dts > index c629a8c..2b7b24f 100644 > --- a/arch/arm/boot/dts/imx27-pdk.dts > +++ b/arch/arm/boot/dts/imx27-pdk.dts > @@ -10,6 +10,7 @@ > */ > > /dts-v1/; > +#include <dt-bindings/input/input.h> I think we can include this into imx27.dtsi, same as other files. --- ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support 2014-04-17 12:42 [PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support Fabio Estevam 2014-04-17 12:42 ` [PATCH 2/2] ARM: dts: imx27-pdk: Add keypad support Fabio Estevam @ 2014-04-17 13:01 ` Alexander Shiyan 2014-04-17 13:12 ` Fabio Estevam 1 sibling, 1 reply; 6+ messages in thread From: Alexander Shiyan @ 2014-04-17 13:01 UTC (permalink / raw) To: linux-arm-kernel Thu, 17 Apr 2014 09:42:40 -0300 ?? Fabio Estevam <festevam@gmail.com>: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > arch/arm/boot/dts/imx27-pdk.dts | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/imx27-pdk.dts b/arch/arm/boot/dts/imx27-pdk.dts > index 971961f..c629a8c 100644 > --- a/arch/arm/boot/dts/imx27-pdk.dts > +++ b/arch/arm/boot/dts/imx27-pdk.dts > @@ -84,6 +84,12 @@ > status = "okay"; > }; > > +&nfc { > + status = "okay"; > + nand-ecc-mode = "hw"; > + nand-on-flash-bbt; > +}; You also should add pin definitions. --- ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support 2014-04-17 13:01 ` [PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support Alexander Shiyan @ 2014-04-17 13:12 ` Fabio Estevam 2014-04-17 13:19 ` Alexander Shiyan 0 siblings, 1 reply; 6+ messages in thread From: Fabio Estevam @ 2014-04-17 13:12 UTC (permalink / raw) To: linux-arm-kernel On Thu, Apr 17, 2014 at 10:01 AM, Alexander Shiyan <shc_work@mail.ru> wrote: >> +&nfc { >> + status = "okay"; >> + nand-ecc-mode = "hw"; >> + nand-on-flash-bbt; >> +}; > > You also should add pin definitions. NAND is detected even without the pin definitions. arch/arm/mach-imx/mach-mx27_3ds.c also does not define the NAND pins. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support 2014-04-17 13:12 ` Fabio Estevam @ 2014-04-17 13:19 ` Alexander Shiyan 0 siblings, 0 replies; 6+ messages in thread From: Alexander Shiyan @ 2014-04-17 13:19 UTC (permalink / raw) To: linux-arm-kernel Thu, 17 Apr 2014 10:12:34 -0300 ?? Fabio Estevam <festevam@gmail.com>: > On Thu, Apr 17, 2014 at 10:01 AM, Alexander Shiyan <shc_work@mail.ru> wrote: > > >> +&nfc { > >> + status = "okay"; > >> + nand-ecc-mode = "hw"; > >> + nand-on-flash-bbt; > >> +}; > > > > You also should add pin definitions. > > NAND is detected even without the pin definitions. > arch/arm/mach-imx/mach-mx27_3ds.c also does not define the NAND pins. What if NFC pins are defined as GPIOs in the bootloader? The definition of pins is a good idea, because we get a runtime warning in case a possible conflict. --- ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-04-17 13:19 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-04-17 12:42 [PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support Fabio Estevam 2014-04-17 12:42 ` [PATCH 2/2] ARM: dts: imx27-pdk: Add keypad support Fabio Estevam 2014-04-17 13:04 ` Alexander Shiyan 2014-04-17 13:01 ` [PATCH 1/2] ARM: dts: imx27-pdk: Add NAND support Alexander Shiyan 2014-04-17 13:12 ` Fabio Estevam 2014-04-17 13:19 ` Alexander Shiyan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).