linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH] ARM: EXYNOS: Fix failed second suspend on Exynos4
Date: Tue, 03 Mar 2015 12:28:17 +0100	[thread overview]
Message-ID: <13977718.vr52PylqCh@amdc1032> (raw)
In-Reply-To: <2802418.zt8CxNGGkT@amdc1032>


Hi Kukjin,

It has been a month since this regression fix was originally posted:
	https://lkml.org/lkml/2015/2/3/481

Could you please review/apply it?  Thank you.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

On Monday, February 23, 2015 05:25:48 PM Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Wednesday, February 18, 2015 11:45:25 AM Krzysztof Kozlowski wrote:
> > On Exynos4412 boards (Trats2, Odroid U3) after enabling L2 cache in
> > 56b60b8bce4a ("ARM: 8265/1: dts: exynos4: Add nodes for L2 cache
> > controller") the second suspend to RAM failed. First suspend worked fine
> > but the next one hang just after powering down of secondary CPUs (system
> > consumed energy as it would be running but was not responsive).
> > 
> > The issue was caused by enabling delayed reset assertion for CPU0 just
> > after issuing power down of cores. This was introduced for Exynos4 in
> > 13cfa6c4f7fa ("ARM: EXYNOS: Fix CPU idle clock down after CPU off").
> > 
> > The whole behavior is not well documented but after checking with vendor
> > code this should be done like this (on Exynos4):
> > 1. Enable delayed reset assertion when system is running (for all CPUs).
> > 2. Disable delayed reset assertion before suspending the system.
> >    This can be done after powering off secondary CPUs.
> > 3. Re-enable the delayed reset assertion when system is resumed.
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Fixes: 13cfa6c4f7fa ("ARM: EXYNOS: Fix CPU idle clock down after CPU off")
> > Cc: <stable@vger.kernel.org>
> 
> It turned out that this patch is also needed to fix cpuidle AFTR mode
> hang on Trats2.
> 
> Tested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> 
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics

  parent reply	other threads:[~2015-03-03 11:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 10:45 [RESEND PATCH] ARM: EXYNOS: Fix failed second suspend on Exynos4 Krzysztof Kozlowski
2015-02-23 16:25 ` Bartlomiej Zolnierkiewicz
2015-02-23 17:12   ` Krzysztof Kozlowski
2015-03-03 11:28   ` Bartlomiej Zolnierkiewicz [this message]
2015-02-24  2:38 ` Chanwoo Choi
2015-02-24  7:59   ` Krzysztof Kozlowski
2015-02-24  8:45     ` Chanwoo Choi
2015-02-24  8:46 ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13977718.vr52PylqCh@amdc1032 \
    --to=b.zolnierkie@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).