From: "Shradha Todi" <shradha.t@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
<lpieralisi@kernel.org>, <kw@linux.com>, <robh@kernel.org>,
<bhelgaas@google.com>, <krzysztof.kozlowski+dt@linaro.org>,
<alim.akhtar@samsung.com>, <jingoohan1@gmail.com>,
<Sergey.Semin@baikalelectronics.ru>, <lukas.bulwahn@gmail.com>,
<hongxing.zhu@nxp.com>, <tglx@linutronix.de>,
<m.szyprowski@samsung.com>, <jh80.chung@samsung.co>,
<pankaj.dubey@samsung.com>
Cc: <linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 06/16] arm64: dts: exynos: Rename the term elbi to appl
Date: Thu, 2 Mar 2023 18:37:43 +0530 [thread overview]
Message-ID: <139801d94d07$fc0b9e70$f422db50$@samsung.com> (raw)
In-Reply-To: <31e377b7-88bf-8737-0397-44ecca8cff54@linaro.org>
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 16 February 2023 16:34
> To: Shradha Todi <shradha.t@samsung.com>; lpieralisi@kernel.org;
> kw@linux.com; robh@kernel.org; bhelgaas@google.com;
> krzysztof.kozlowski+dt@linaro.org; alim.akhtar@samsung.com;
> jingoohan1@gmail.com; Sergey.Semin@baikalelectronics.ru;
> lukas.bulwahn@gmail.com; hongxing.zhu@nxp.com; tglx@linutronix.de;
> m.szyprowski@samsung.com; jh80.chung@samsung.co;
> pankaj.dubey@samsung.com
> Cc: linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 06/16] arm64: dts: exynos: Rename the term elbi to appl
>
> On 14/02/2023 13:13, Shradha Todi wrote:
> > DT uses the name elbi in reg-names for application logic registers
> > which is a wrong nomenclature. This patch fixes the same.
> >
> > This commit shouldn't be applied without changes
> > "dt-bindings: PCI: Rename the term elbi to appl" and
> > "PCI: samsung: Rename the term elbi to appl"
>
> Dependencies and patch ordering goes after '---', because there is no point
> to store it in git history.
>
Understood will take care in next set of patches.
> Anyway, that's an ABI break and Exynos5433 is quite stable, so without clear
> indication of fixed bug, we should not do this.
>
We have strong technical reason to do so.
As per DWC PCIe UM, ELBI delivers an inbound register RD/WR received by the controller to external application registers when the controller
is expected to generate the PCIe completion of this register RD/WR.
In this driver register space which is currently marked as ELBI, is not used for this purpose (Not sure why original author has named this set of registers as ELBI)
So to keep this technically correct, it should be marked as application specific wrapper register space.
We used name as "appl" taking reference from intel-gw-pcie.yaml's similar register space named as "app", whereas in nvidia,tegra194-pcie.yaml it's named "appl".
So our argument is if a future Samsung manufactured SoC having DWC PCIe controller comes with support of real ELBI interface, we need to use the name elbi.
We know such SoC exists but they are not yet upstreamed.
Ready to adopt the best possible suggested method to make this happen but I really think the name ELBI is misleading.
>
> Best regards,
> Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-03 6:27 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230214121348epcas5p48a3b2b225f616d748cc20622d01edb97@epcas5p4.samsung.com>
2023-02-14 12:13 ` [PATCH 00/16] Refactor Exynos PCIe driver to make it generic Shradha Todi
2023-02-14 12:13 ` [PATCH 01/16] dt-bindings: PCI: Rename Exynos PCIe binding to Samsung PCIe Shradha Todi
2023-02-16 10:54 ` Krzysztof Kozlowski
2023-02-18 1:54 ` Han Jingoo
2023-03-02 12:54 ` Shradha Todi
2023-03-03 10:12 ` Krzysztof Kozlowski
2023-02-14 12:13 ` [PATCH 02/16] PCI: exynos: Rename Exynos PCIe driver " Shradha Todi
2023-02-16 10:55 ` Krzysztof Kozlowski
2023-02-16 10:59 ` Krzysztof Kozlowski
2023-03-02 12:57 ` Shradha Todi
2023-03-03 10:35 ` Krzysztof Kozlowski
2023-02-14 12:13 ` [PATCH 03/16] PCI: samsung: Change macro names to exynos specific Shradha Todi
2023-02-16 10:58 ` Krzysztof Kozlowski
2023-02-14 12:13 ` [PATCH 04/16] PCI: samsung: Use clock bulk API to get clocks Shradha Todi
2023-02-16 11:02 ` Krzysztof Kozlowski
2023-03-02 12:59 ` Shradha Todi
2023-02-14 12:13 ` [PATCH 05/16] dt-bindings: PCI: Rename the term elbi to appl Shradha Todi
2023-02-14 16:12 ` Rob Herring
2023-03-02 12:47 ` Shradha Todi
2023-02-14 19:15 ` Rob Herring
2023-02-16 11:04 ` Krzysztof Kozlowski
2023-02-14 12:13 ` [PATCH 06/16] arm64: dts: exynos: " Shradha Todi
2023-02-16 11:03 ` Krzysztof Kozlowski
2023-03-02 13:07 ` Shradha Todi [this message]
2023-03-03 10:37 ` Krzysztof Kozlowski
2023-02-14 12:13 ` [PATCH 07/16] PCI: samsung: " Shradha Todi
2023-02-14 12:13 ` [PATCH 08/16] PCI: samsung: Rename exynos_pcie to samsung_pcie Shradha Todi
2023-02-16 11:07 ` Krzysztof Kozlowski
2023-03-02 12:32 ` Pankaj Dubey
2023-03-03 10:06 ` Krzysztof Kozlowski
2023-02-14 12:13 ` [PATCH 09/16] PCI: samsung: Make common appl readl/writel functions Shradha Todi
2023-02-16 11:07 ` Krzysztof Kozlowski
2023-03-02 12:33 ` Pankaj Dubey
2023-02-14 12:13 ` [PATCH 10/16] dt-bindings: PCI: Add phy-names as required property Shradha Todi
2023-02-14 16:12 ` Rob Herring
2023-03-02 12:48 ` Shradha Todi
2023-02-14 19:17 ` Rob Herring
2023-03-02 12:51 ` Shradha Todi
2023-02-14 12:13 ` [PATCH 11/16] arm64: dts: exynos: Add phy-names as DT property Shradha Todi
2023-02-14 12:13 ` [PATCH 12/16] PCI: samsung: Get PHY using non-DT version Shradha Todi
2023-02-14 12:13 ` [PATCH 13/16] PCI: samsung: Rename common functions to samsung Shradha Todi
2023-02-16 11:09 ` Krzysztof Kozlowski
2023-02-14 12:13 ` [PATCH 15/16] PCI: samsung: Add structure to hold resource operations Shradha Todi
2023-02-16 11:11 ` Krzysztof Kozlowski
2023-03-02 13:10 ` Shradha Todi
2023-02-14 12:13 ` [PATCH 16/16] PCI: samsung: Make handling of regulators generic Shradha Todi
2023-02-16 10:57 ` [PATCH 00/16] Refactor Exynos PCIe driver to make it generic Krzysztof Kozlowski
2023-03-03 12:38 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='139801d94d07$fc0b9e70$f422db50$@samsung.com' \
--to=shradha.t@samsung.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=alim.akhtar@samsung.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=jh80.chung@samsung.co \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=m.szyprowski@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).