* [PATCH RESEND] arm: dma-mapping: Fix mapping size value @ 2014-04-21 6:47 Ritesh Harjani 2014-04-21 6:47 ` [PATCH] " Ritesh Harjani 0 siblings, 1 reply; 9+ messages in thread From: Ritesh Harjani @ 2014-04-21 6:47 UTC (permalink / raw) To: linux-arm-kernel Previous patch message got corrupted by my mail-server (copy-paste) So resending it. [history]: http://www.spinics.net/lists/arm-kernel/msg323904.html Ritesh Harjani (1): arm: dma-mapping: Fix mapping size value arch/arm/mm/dma-mapping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.1.3 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm: dma-mapping: Fix mapping size value 2014-04-21 6:47 [PATCH RESEND] arm: dma-mapping: Fix mapping size value Ritesh Harjani @ 2014-04-21 6:47 ` Ritesh Harjani 2014-04-22 8:53 ` Will Deacon 2014-04-22 9:09 ` Marek Szyprowski 0 siblings, 2 replies; 9+ messages in thread From: Ritesh Harjani @ 2014-04-21 6:47 UTC (permalink / raw) To: linux-arm-kernel 68efd7d2fb("arm: dma-mapping: remove order parameter from arm_iommu_create_mapping()") is causing kernel panic because it wrongly sets the value of mapping->size: Unable to handle kernel NULL pointer dereference at virtual address 000000a0 pgd = e7a84000 [000000a0] *pgd=00000000 ... PC is at bitmap_clear+0x48/0xd0 LR is at __iommu_remove_mapping+0x130/0x164 Fix it by correcting mapping->size value. Signed-off-by: Ritesh Harjani <ritesh.harjani@gmail.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- arch/arm/mm/dma-mapping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index f62aa06..6b00be1 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -1963,8 +1963,8 @@ arm_iommu_create_mapping(struct bus_type *bus, dma_addr_t base, size_t size) mapping->nr_bitmaps = 1; mapping->extensions = extensions; mapping->base = base; - mapping->size = bitmap_size << PAGE_SHIFT; mapping->bits = BITS_PER_BYTE * bitmap_size; + mapping->size = mapping->bits << PAGE_SHIFT; spin_lock_init(&mapping->lock); -- 1.8.1.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] arm: dma-mapping: Fix mapping size value 2014-04-21 6:47 ` [PATCH] " Ritesh Harjani @ 2014-04-22 8:53 ` Will Deacon 2014-04-23 8:53 ` Marek Szyprowski 2014-04-22 9:09 ` Marek Szyprowski 1 sibling, 1 reply; 9+ messages in thread From: Will Deacon @ 2014-04-22 8:53 UTC (permalink / raw) To: linux-arm-kernel On Mon, Apr 21, 2014 at 07:47:27AM +0100, Ritesh Harjani wrote: > 68efd7d2fb("arm: dma-mapping: remove order parameter from > arm_iommu_create_mapping()") is causing kernel panic > because it wrongly sets the value of mapping->size: > > Unable to handle kernel NULL pointer dereference at virtual > address 000000a0 > pgd = e7a84000 > [000000a0] *pgd=00000000 > ... > PC is at bitmap_clear+0x48/0xd0 > LR is at __iommu_remove_mapping+0x130/0x164 > > Fix it by correcting mapping->size value. > > Signed-off-by: Ritesh Harjani <ritesh.harjani@gmail.com> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > arch/arm/mm/dma-mapping.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > index f62aa06..6b00be1 100644 > --- a/arch/arm/mm/dma-mapping.c > +++ b/arch/arm/mm/dma-mapping.c > @@ -1963,8 +1963,8 @@ arm_iommu_create_mapping(struct bus_type *bus, dma_addr_t base, size_t size) > mapping->nr_bitmaps = 1; > mapping->extensions = extensions; > mapping->base = base; > - mapping->size = bitmap_size << PAGE_SHIFT; > mapping->bits = BITS_PER_BYTE * bitmap_size; > + mapping->size = mapping->bits << PAGE_SHIFT; Ok, but given that mapping->size is derived from mapping->bits, do we really need both of these fields in struct dma_iommu_mapping? Will ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm: dma-mapping: Fix mapping size value 2014-04-22 8:53 ` Will Deacon @ 2014-04-23 8:53 ` Marek Szyprowski 2014-04-23 9:30 ` Laurent Pinchart 0 siblings, 1 reply; 9+ messages in thread From: Marek Szyprowski @ 2014-04-23 8:53 UTC (permalink / raw) To: linux-arm-kernel Hello, On 2014-04-22 10:53, Will Deacon wrote: > On Mon, Apr 21, 2014 at 07:47:27AM +0100, Ritesh Harjani wrote: > > 68efd7d2fb("arm: dma-mapping: remove order parameter from > > arm_iommu_create_mapping()") is causing kernel panic > > because it wrongly sets the value of mapping->size: > > > > Unable to handle kernel NULL pointer dereference at virtual > > address 000000a0 > > pgd = e7a84000 > > [000000a0] *pgd=00000000 > > ... > > PC is at bitmap_clear+0x48/0xd0 > > LR is at __iommu_remove_mapping+0x130/0x164 > > > > Fix it by correcting mapping->size value. > > > > Signed-off-by: Ritesh Harjani <ritesh.harjani@gmail.com> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > arch/arm/mm/dma-mapping.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > > index f62aa06..6b00be1 100644 > > --- a/arch/arm/mm/dma-mapping.c > > +++ b/arch/arm/mm/dma-mapping.c > > @@ -1963,8 +1963,8 @@ arm_iommu_create_mapping(struct bus_type *bus, dma_addr_t base, size_t size) > > mapping->nr_bitmaps = 1; > > mapping->extensions = extensions; > > mapping->base = base; > > - mapping->size = bitmap_size << PAGE_SHIFT; > > mapping->bits = BITS_PER_BYTE * bitmap_size; > > + mapping->size = mapping->bits << PAGE_SHIFT; > > Ok, but given that mapping->size is derived from mapping->bits, do we really > need both of these fields in struct dma_iommu_mapping? You are right. I didn't notice this while I was refactoring the code. Ritesh, could you update your patch and simply replace all references of mapping->size with (mapping->bits << PAGE_SHIFT), probably with some temporary variable to make the code easier to understand? I've didn't apply your patch yet. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm: dma-mapping: Fix mapping size value 2014-04-23 8:53 ` Marek Szyprowski @ 2014-04-23 9:30 ` Laurent Pinchart 2014-04-23 10:04 ` Ritesh Harjani 0 siblings, 1 reply; 9+ messages in thread From: Laurent Pinchart @ 2014-04-23 9:30 UTC (permalink / raw) To: linux-arm-kernel Hi Marek, On Wednesday 23 April 2014 10:53:24 Marek Szyprowski wrote: > On 2014-04-22 10:53, Will Deacon wrote: > > On Mon, Apr 21, 2014 at 07:47:27AM +0100, Ritesh Harjani wrote: > > > 68efd7d2fb("arm: dma-mapping: remove order parameter from > > > arm_iommu_create_mapping()") is causing kernel panic > > > because it wrongly sets the value of mapping->size: > > > > > > Unable to handle kernel NULL pointer dereference at virtual > > > address 000000a0 > > > pgd = e7a84000 > > > [000000a0] *pgd=00000000 > > > ... > > > PC is at bitmap_clear+0x48/0xd0 > > > LR is at __iommu_remove_mapping+0x130/0x164 > > > > > > Fix it by correcting mapping->size value. > > > > > > Signed-off-by: Ritesh Harjani <ritesh.harjani@gmail.com> > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > --- > > > > > > arch/arm/mm/dma-mapping.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > > > index f62aa06..6b00be1 100644 > > > --- a/arch/arm/mm/dma-mapping.c > > > +++ b/arch/arm/mm/dma-mapping.c > > > @@ -1963,8 +1963,8 @@ arm_iommu_create_mapping(struct bus_type *bus, > > > dma_addr_t base, size_t size)> > > > > mapping->nr_bitmaps = 1; > > > mapping->extensions = extensions; > > > mapping->base = base; > > > > > > - mapping->size = bitmap_size << PAGE_SHIFT; > > > > > > mapping->bits = BITS_PER_BYTE * bitmap_size; > > > > > > + mapping->size = mapping->bits << PAGE_SHIFT; > > > > Ok, but given that mapping->size is derived from mapping->bits, do we > > really need both of these fields in struct dma_iommu_mapping? > > You are right. I didn't notice this while I was refactoring the code. > Ritesh, could you update your patch and simply replace all references of > mapping->size with (mapping->bits << PAGE_SHIFT), probably with some > temporary variable to make the code easier to understand? I've didn't apply > your patch yet. As this patch fixes a v3.15 regression, shouldn't it be applied as-is and ASAP, with the cleanup that removes mapping->size coming in a later, less urgent patch ? -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm: dma-mapping: Fix mapping size value 2014-04-23 9:30 ` Laurent Pinchart @ 2014-04-23 10:04 ` Ritesh Harjani 2014-04-23 13:17 ` Marek Szyprowski 0 siblings, 1 reply; 9+ messages in thread From: Ritesh Harjani @ 2014-04-23 10:04 UTC (permalink / raw) To: linux-arm-kernel Hi Marek/Will On Wed, Apr 23, 2014 at 3:00 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > Hi Marek, > > On Wednesday 23 April 2014 10:53:24 Marek Szyprowski wrote: >> On 2014-04-22 10:53, Will Deacon wrote: >> > On Mon, Apr 21, 2014 at 07:47:27AM +0100, Ritesh Harjani wrote: >> > > 68efd7d2fb("arm: dma-mapping: remove order parameter from >> > > arm_iommu_create_mapping()") is causing kernel panic >> > > because it wrongly sets the value of mapping->size: >> > > >> > > Unable to handle kernel NULL pointer dereference at virtual >> > > address 000000a0 >> > > pgd = e7a84000 >> > > [000000a0] *pgd=00000000 >> > > ... >> > > PC is at bitmap_clear+0x48/0xd0 >> > > LR is at __iommu_remove_mapping+0x130/0x164 >> > > >> > > Fix it by correcting mapping->size value. >> > > >> > > Signed-off-by: Ritesh Harjani <ritesh.harjani@gmail.com> >> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> > > --- >> > > >> > > arch/arm/mm/dma-mapping.c | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > > >> > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c >> > > index f62aa06..6b00be1 100644 >> > > --- a/arch/arm/mm/dma-mapping.c >> > > +++ b/arch/arm/mm/dma-mapping.c >> > > @@ -1963,8 +1963,8 @@ arm_iommu_create_mapping(struct bus_type *bus, >> > > dma_addr_t base, size_t size)> > >> > > mapping->nr_bitmaps = 1; >> > > mapping->extensions = extensions; >> > > mapping->base = base; >> > > >> > > - mapping->size = bitmap_size << PAGE_SHIFT; >> > > >> > > mapping->bits = BITS_PER_BYTE * bitmap_size; >> > > >> > > + mapping->size = mapping->bits << PAGE_SHIFT; >> > >> > Ok, but given that mapping->size is derived from mapping->bits, do we >> > really need both of these fields in struct dma_iommu_mapping? >> >> You are right. I didn't notice this while I was refactoring the code. >> Ritesh, could you update your patch and simply replace all references of >> mapping->size with (mapping->bits << PAGE_SHIFT), probably with some >> temporary variable to make the code easier to understand? I've didn't apply >> your patch yet. > > As this patch fixes a v3.15 regression, shouldn't it be applied as-is and > ASAP, with the cleanup that removes mapping->size coming in a later, less > urgent patch ? I agree with Laurent. Anyway this cleanup can be taken care when we will be doing refactoring of common code to lib/iommu-helper.c. Anyways, if you still insist I can prepare and submit the patch. Let me know again on this. > > -- > Regards, > > Laurent Pinchart > Thanks Ritesh ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm: dma-mapping: Fix mapping size value 2014-04-23 10:04 ` Ritesh Harjani @ 2014-04-23 13:17 ` Marek Szyprowski 2014-04-23 13:22 ` Ritesh Harjani 0 siblings, 1 reply; 9+ messages in thread From: Marek Szyprowski @ 2014-04-23 13:17 UTC (permalink / raw) To: linux-arm-kernel Hello, On 2014-04-23 12:04, Ritesh Harjani wrote: > Hi Marek/Will > > On Wed, Apr 23, 2014 at 3:00 PM, Laurent Pinchart > <laurent.pinchart@ideasonboard.com> wrote: > > Hi Marek, > > > > On Wednesday 23 April 2014 10:53:24 Marek Szyprowski wrote: > >> On 2014-04-22 10:53, Will Deacon wrote: > >> > On Mon, Apr 21, 2014 at 07:47:27AM +0100, Ritesh Harjani wrote: > >> > > 68efd7d2fb("arm: dma-mapping: remove order parameter from > >> > > arm_iommu_create_mapping()") is causing kernel panic > >> > > because it wrongly sets the value of mapping->size: > >> > > > >> > > Unable to handle kernel NULL pointer dereference at virtual > >> > > address 000000a0 > >> > > pgd = e7a84000 > >> > > [000000a0] *pgd=00000000 > >> > > ... > >> > > PC is at bitmap_clear+0x48/0xd0 > >> > > LR is at __iommu_remove_mapping+0x130/0x164 > >> > > > >> > > Fix it by correcting mapping->size value. > >> > > > >> > > Signed-off-by: Ritesh Harjani <ritesh.harjani@gmail.com> > >> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> > > --- > >> > > > >> > > arch/arm/mm/dma-mapping.c | 2 +- > >> > > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > > >> > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > >> > > index f62aa06..6b00be1 100644 > >> > > --- a/arch/arm/mm/dma-mapping.c > >> > > +++ b/arch/arm/mm/dma-mapping.c > >> > > @@ -1963,8 +1963,8 @@ arm_iommu_create_mapping(struct bus_type *bus, > >> > > dma_addr_t base, size_t size)> > > >> > > mapping->nr_bitmaps = 1; > >> > > mapping->extensions = extensions; > >> > > mapping->base = base; > >> > > > >> > > - mapping->size = bitmap_size << PAGE_SHIFT; > >> > > > >> > > mapping->bits = BITS_PER_BYTE * bitmap_size; > >> > > > >> > > + mapping->size = mapping->bits << PAGE_SHIFT; > >> > > >> > Ok, but given that mapping->size is derived from mapping->bits, do we > >> > really need both of these fields in struct dma_iommu_mapping? > >> > >> You are right. I didn't notice this while I was refactoring the code. > >> Ritesh, could you update your patch and simply replace all references of > >> mapping->size with (mapping->bits << PAGE_SHIFT), probably with some > >> temporary variable to make the code easier to understand? I've didn't apply > >> your patch yet. > > > > As this patch fixes a v3.15 regression, shouldn't it be applied as-is and > > ASAP, with the cleanup that removes mapping->size coming in a later, less > > urgent patch ? > > I agree with Laurent. Anyway this cleanup can be taken care when we will be > doing refactoring of common code to lib/iommu-helper.c. > > Anyways, if you still insist I can prepare and submit the patch. Let me know > again on this. Ok, I've merged the patch as is and I will send pull request soon. Please include the above discussed cleanup while refactoring common code to lib. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm: dma-mapping: Fix mapping size value 2014-04-23 13:17 ` Marek Szyprowski @ 2014-04-23 13:22 ` Ritesh Harjani 0 siblings, 0 replies; 9+ messages in thread From: Ritesh Harjani @ 2014-04-23 13:22 UTC (permalink / raw) To: linux-arm-kernel Ok thanks Marek, I was about to send a new patch (as I had now got hold of my system). Anyways, I will add this discussion of cleaning up this variable in my to-do list. Thanks Ritesh On Wed, Apr 23, 2014 at 6:47 PM, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > Hello, > > > On 2014-04-23 12:04, Ritesh Harjani wrote: >> >> Hi Marek/Will >> >> On Wed, Apr 23, 2014 at 3:00 PM, Laurent Pinchart >> <laurent.pinchart@ideasonboard.com> wrote: >> > Hi Marek, >> > >> > On Wednesday 23 April 2014 10:53:24 Marek Szyprowski wrote: >> >> On 2014-04-22 10:53, Will Deacon wrote: >> >> > On Mon, Apr 21, 2014 at 07:47:27AM +0100, Ritesh Harjani wrote: >> >> > > 68efd7d2fb("arm: dma-mapping: remove order parameter from >> >> > > arm_iommu_create_mapping()") is causing kernel panic >> >> > > because it wrongly sets the value of mapping->size: >> >> > > >> >> > > Unable to handle kernel NULL pointer dereference at virtual >> >> > > address 000000a0 >> >> > > pgd = e7a84000 >> >> > > [000000a0] *pgd=00000000 >> >> > > ... >> >> > > PC is at bitmap_clear+0x48/0xd0 >> >> > > LR is at __iommu_remove_mapping+0x130/0x164 >> >> > > >> >> > > Fix it by correcting mapping->size value. >> >> > > >> >> > > Signed-off-by: Ritesh Harjani <ritesh.harjani@gmail.com> >> >> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> >> > > --- >> >> > > >> >> > > arch/arm/mm/dma-mapping.c | 2 +- >> >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> >> > > >> >> > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c >> >> > > index f62aa06..6b00be1 100644 >> >> > > --- a/arch/arm/mm/dma-mapping.c >> >> > > +++ b/arch/arm/mm/dma-mapping.c >> >> > > @@ -1963,8 +1963,8 @@ arm_iommu_create_mapping(struct bus_type >> >> > > *bus, >> >> > > dma_addr_t base, size_t size)> > >> >> > > mapping->nr_bitmaps = 1; >> >> > > mapping->extensions = extensions; >> >> > > mapping->base = base; >> >> > > >> >> > > - mapping->size = bitmap_size << PAGE_SHIFT; >> >> > > >> >> > > mapping->bits = BITS_PER_BYTE * bitmap_size; >> >> > > >> >> > > + mapping->size = mapping->bits << PAGE_SHIFT; >> >> > >> >> > Ok, but given that mapping->size is derived from mapping->bits, do we >> >> > really need both of these fields in struct dma_iommu_mapping? >> >> >> >> You are right. I didn't notice this while I was refactoring the code. >> >> Ritesh, could you update your patch and simply replace all references >> >> of >> >> mapping->size with (mapping->bits << PAGE_SHIFT), probably with some >> >> temporary variable to make the code easier to understand? I've didn't >> >> apply >> >> your patch yet. >> > >> > As this patch fixes a v3.15 regression, shouldn't it be applied as-is >> > and >> > ASAP, with the cleanup that removes mapping->size coming in a later, >> > less >> > urgent patch ? >> >> I agree with Laurent. Anyway this cleanup can be taken care when we will >> be >> doing refactoring of common code to lib/iommu-helper.c. >> >> Anyways, if you still insist I can prepare and submit the patch. Let me >> know >> again on this. > > > Ok, I've merged the patch as is and I will send pull request soon. > Please include the above discussed cleanup while refactoring common code to > lib. > > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm: dma-mapping: Fix mapping size value 2014-04-21 6:47 ` [PATCH] " Ritesh Harjani 2014-04-22 8:53 ` Will Deacon @ 2014-04-22 9:09 ` Marek Szyprowski 1 sibling, 0 replies; 9+ messages in thread From: Marek Szyprowski @ 2014-04-22 9:09 UTC (permalink / raw) To: linux-arm-kernel Hello, On 2014-04-21 08:47, Ritesh Harjani wrote: > 68efd7d2fb("arm: dma-mapping: remove order parameter from > arm_iommu_create_mapping()") is causing kernel panic > because it wrongly sets the value of mapping->size: > > Unable to handle kernel NULL pointer dereference at virtual > address 000000a0 > pgd = e7a84000 > [000000a0] *pgd=00000000 > ... > PC is at bitmap_clear+0x48/0xd0 > LR is at __iommu_remove_mapping+0x130/0x164 > > Fix it by correcting mapping->size value. > > Signed-off-by: Ritesh Harjani <ritesh.harjani@gmail.com> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks for spotting this issue! I'm really sorry for introducing it. I will push it to the fixes branch asap. > --- > arch/arm/mm/dma-mapping.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c > index f62aa06..6b00be1 100644 > --- a/arch/arm/mm/dma-mapping.c > +++ b/arch/arm/mm/dma-mapping.c > @@ -1963,8 +1963,8 @@ arm_iommu_create_mapping(struct bus_type *bus, dma_addr_t base, size_t size) > mapping->nr_bitmaps = 1; > mapping->extensions = extensions; > mapping->base = base; > - mapping->size = bitmap_size << PAGE_SHIFT; > mapping->bits = BITS_PER_BYTE * bitmap_size; > + mapping->size = mapping->bits << PAGE_SHIFT; > > spin_lock_init(&mapping->lock); Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-04-23 13:22 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-04-21 6:47 [PATCH RESEND] arm: dma-mapping: Fix mapping size value Ritesh Harjani 2014-04-21 6:47 ` [PATCH] " Ritesh Harjani 2014-04-22 8:53 ` Will Deacon 2014-04-23 8:53 ` Marek Szyprowski 2014-04-23 9:30 ` Laurent Pinchart 2014-04-23 10:04 ` Ritesh Harjani 2014-04-23 13:17 ` Marek Szyprowski 2014-04-23 13:22 ` Ritesh Harjani 2014-04-22 9:09 ` Marek Szyprowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).