From: elder@linaro.org (Alex Elder)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 RESEND 1/7] clk: bcm281xx: warn if ccu_wait_bit() fails
Date: Mon, 21 Apr 2014 16:11:37 -0500 [thread overview]
Message-ID: <1398114703-32410-2-git-send-email-elder@linaro.org> (raw)
In-Reply-To: <1398114703-32410-1-git-send-email-elder@linaro.org>
Don't let a failure of ccu_wait_bit() go unnoticed.
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/clk/bcm/clk-kona.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c
index db11a87..4b4e35a 100644
--- a/drivers/clk/bcm/clk-kona.c
+++ b/drivers/clk/bcm/clk-kona.c
@@ -207,6 +207,9 @@ __ccu_wait_bit(struct ccu_data *ccu, u32 reg_offset, u32 bit, bool want)
return true;
udelay(1);
}
+ pr_warn("%s: %s/0x%04x bit %u was never %s\n", __func__,
+ ccu->name, reg_offset, bit, want ? "set" : "clear");
+
return false;
}
--
1.9.1
next prev parent reply other threads:[~2014-04-21 21:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 21:11 [PATCH v4 RESEND 0/7] clk: bcm281xx: updates Alex Elder
2014-04-21 21:11 ` Alex Elder [this message]
2014-04-21 21:11 ` [PATCH v4 RESEND 2/7] clk: bcm281xx: use init_data.name for clock name Alex Elder
2014-04-21 21:11 ` [PATCH v4 RESEND 3/7] clk: bcm281xx: change some symbol names Alex Elder
2014-04-21 21:11 ` [PATCH v4 RESEND 4/7] clk: bcm281xx: initialize CCU structures statically Alex Elder
2014-04-21 21:11 ` [PATCH v4 RESEND 5/7] clk: bcm281xx: define CCU clock data statically Alex Elder
2014-04-21 21:11 ` [PATCH v4 RESEND 6/7] clk: bcm281xx: add clock policy support Alex Elder
2014-04-21 21:11 ` [PATCH v4 RESEND 7/7] clk: bcm281xx: add clock hysteresis support Alex Elder
2014-04-25 23:00 ` [PATCH v4 RESEND 0/7] clk: bcm281xx: updates Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398114703-32410-2-git-send-email-elder@linaro.org \
--to=elder@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).