From: joelf@ti.com (Joel Fernandes)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/8] ARM: OMAP2+: timer: Simplify clock event/source name setting
Date: Tue, 22 Apr 2014 20:27:03 -0500 [thread overview]
Message-ID: <1398216429-4681-3-git-send-email-joelf@ti.com> (raw)
In-Reply-To: <1398216429-4681-1-git-send-email-joelf@ti.com>
For the OMAPs, we're setting up only one clockevent and clocksource. Further,
for DT boot there's no easy way to get the timer name and currently this is
done in an ugly way by reading a hwmod entry. So let's just set it to a simpler
name like timer_clkev and timer_clksrc.
Signed-off-by: Joel Fernandes <joelf@ti.com>
---
arch/arm/mach-omap2/timer.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
index ec427e6..f192a41 100644
--- a/arch/arm/mach-omap2/timer.c
+++ b/arch/arm/mach-omap2/timer.c
@@ -251,7 +251,6 @@ static u32 __init omap_dm_timer_get_errata(void)
static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer,
const char *fck_source,
const char *property,
- const char **timer_name,
int posted)
{
char name[10]; /* 10 = sizeof("gptXX_Xck0") */
@@ -290,8 +289,6 @@ static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer,
if (!oh)
return -ENODEV;
- *timer_name = oh->name;
-
if (!of_have_populated_dt()) {
r = omap_hwmod_get_resource_byname(oh, IORESOURCE_IRQ, NULL,
&irq);
@@ -365,8 +362,10 @@ static void __init omap2_gp_clockevent_init(int gptimer_id,
*/
__omap_dm_timer_override_errata(&clkev, OMAP_TIMER_ERRATA_I103_I767);
+ clockevent_gpt.name = "timer_clkev";
+
res = omap_dm_timer_init_one(&clkev, fck_source, property,
- &clockevent_gpt.name, OMAP_TIMER_POSTED);
+ OMAP_TIMER_POSTED);
BUG_ON(res);
omap2_gp_timer_irq.dev_id = &clkev;
@@ -489,10 +488,11 @@ static void __init omap2_gptimer_clocksource_init(int gptimer_id,
clksrc.errata = omap_dm_timer_get_errata();
res = omap_dm_timer_init_one(&clksrc, fck_source, property,
- &clocksource_gpt.name,
OMAP_TIMER_NONPOSTED);
BUG_ON(res);
+ clocksource_gpt.name = "timer_clksrc";
+
__omap_dm_timer_load_start(&clksrc,
OMAP_TIMER_CTRL_AR, 0,
OMAP_TIMER_NONPOSTED);
--
1.7.9.5
next prev parent reply other threads:[~2014-04-23 1:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 1:27 [PATCH 0/8] OMAP2+ system timer cleanup series Joel Fernandes
2014-04-23 1:27 ` [PATCH 1/8] ARM: OMAP2+: timer: Add a powerup function Joel Fernandes
2014-07-21 11:00 ` Tony Lindgren
2014-04-23 1:27 ` Joel Fernandes [this message]
2014-07-21 11:05 ` [PATCH 2/8] ARM: OMAP2+: timer: Simplify clock event/source name setting Tony Lindgren
2014-04-23 1:27 ` [PATCH 3/8] ARM: OMAP2+: timer: Add comment on timer clk parenting Joel Fernandes
2014-07-21 11:07 ` Tony Lindgren
2014-04-23 1:27 ` [PATCH 4/8] ARM: OMAP2+: timer: Remove hwmod look-up dependency for DT-boot Joel Fernandes
2014-04-23 1:27 ` [PATCH 5/8] ARM: OMAP2+: timer: Use of_clk_get for DT platforms Joel Fernandes
2014-04-23 1:27 ` [PATCH 6/8] ARM: OMAP2+: timer: Fix error message to not use hwmod structure Joel Fernandes
2014-07-21 11:09 ` Tony Lindgren
2014-04-23 1:27 ` [PATCH 7/8] ARM: OMAP2+: timer: Add fallback for of_clk_get Joel Fernandes
2014-07-21 11:10 ` Tony Lindgren
2014-04-23 1:27 ` [PATCH 8/8] ARM: OMAP2+: timer: Add legacy code for old way of getting fclk Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398216429-4681-3-git-send-email-joelf@ti.com \
--to=joelf@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).