From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] dma: ste_dma40: Maintain spinlock order while handling pause
Date: Wed, 23 Apr 2014 21:52:01 +0200 [thread overview]
Message-ID: <1398282724-2607-1-git-send-email-ulf.hansson@linaro.org> (raw)
The runtime PM resume callback needs to be executed while holding the
spinlock, make sure to maintain this for the pause operation as well.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/dma/ste_dma40.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index bf18c78..6e97cf6 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -1495,8 +1495,8 @@ static int d40_pause(struct d40_chan *d40c)
if (!d40c->busy)
return 0;
- pm_runtime_get_sync(d40c->base->dev);
spin_lock_irqsave(&d40c->lock, flags);
+ pm_runtime_get_sync(d40c->base->dev);
res = d40_channel_execute_command(d40c, D40_DMA_SUSPEND_REQ);
--
1.7.9.5
next reply other threads:[~2014-04-23 19:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 19:52 Ulf Hansson [this message]
2014-04-23 19:52 ` [PATCH 2/4] dma: ste_dma40: Don't require CONFIG_PM_RUNTIME Ulf Hansson
2014-04-24 12:54 ` Linus Walleij
2014-04-23 19:52 ` [PATCH 3/4] dma: ste_dma40: Convert to PM macros while providing the PM callbacks Ulf Hansson
2014-04-24 12:55 ` Linus Walleij
2014-04-23 19:52 ` [PATCH 4/4] dma: ste_dma40: Fixup system suspend/resume Ulf Hansson
2014-04-24 12:55 ` Linus Walleij
2014-04-23 20:39 ` [PATCH 1/4] dma: ste_dma40: Maintain spinlock order while handling pause Sergei Shtylyov
2014-04-24 9:11 ` Ulf Hansson
2014-04-24 13:25 ` Linus Walleij
2014-05-07 6:22 ` Vinod Koul
2014-05-07 8:41 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398282724-2607-1-git-send-email-ulf.hansson@linaro.org \
--to=ulf.hansson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).